Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Tony Lindgren]

* Nathan Chancellor  [190412 05:00]:
> On Thu, Apr 11, 2019 at 01:56:57PM -0700, Tony Lindgren wrote:
> > Hi,
> > 
> > * Daniel Lezcano  [190411 19:21]:
> > > On 10/04/2019 22:07, Tony Lindgren wrote:
> > > > Hi,
> > > > 
> > > > * Daniel Lezcano  [190410 17:02]:
> > > >> can you ask for an acked-by before pulling a patch in your tree?
> > > > 
> > > > I certainly do ask and wait for acks where possible :)
> > > 
> > > Ok, I may have missed them.
> > > 
> > > > Note that I have not applied this patch. I just added
> > > > Keerthy to Cc on this thread so maybe you misread the
> > > > message earlier. My comment "seems like no other
> > > > takers" was for Ladislav regarding somebody picking up
> > > > his earlier work, not for picking up this patch :)
> > > 
> > > Actually I was referring to the commit 592ea6bd1fad. Anyway as stated
> > > above I could have miss your call.
> > 
> > Hmm so commit 592ea6bd1fad was part of the PWM timer series
> > that was posted several times from late 2017 to end of
> > February 2018. I did not get any timer related acks or
> > comments so I applied it together with the PWM timer
> > changes.
> > 
> > I'm guessing you may have accidentally checked out some
> > older deja-vu branch from about a year ago? Commit
> > 592ea6bd1fad is not related to this fix.. :)
> > 
> 
> Just for the record, I said this patch fixes 592ea6bd1fad because
> 592ea6bd1fad should have been marked this function as static, which
> would have exposed that this function was unused and it could have
> been removed at that time. I know it is a bit of a stretch for this
> commit (would be more appropriate for 008258d995a6 to have it) but
> that was my logic behind it. Not opposed to having it removed before
> committing.

Oh OK yes they should have all become static with the PWM
series.

Regards,

Tony

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Nathan Chancellor]

On Thu, Apr 11, 2019 at 01:56:57PM -0700, Tony Lindgren wrote:
> Hi,
> 
> * Daniel Lezcano  [190411 19:21]:
> > On 10/04/2019 22:07, Tony Lindgren wrote:
> > > Hi,
> > > 
> > > * Daniel Lezcano  [190410 17:02]:
> > >> can you ask for an acked-by before pulling a patch in your tree?
> > > 
> > > I certainly do ask and wait for acks where possible :)
> > 
> > Ok, I may have missed them.
> > 
> > > Note that I have not applied this patch. I just added
> > > Keerthy to Cc on this thread so maybe you misread the
> > > message earlier. My comment "seems like no other
> > > takers" was for Ladislav regarding somebody picking up
> > > his earlier work, not for picking up this patch :)
> > 
> > Actually I was referring to the commit 592ea6bd1fad. Anyway as stated
> > above I could have miss your call.
> 
> Hmm so commit 592ea6bd1fad was part of the PWM timer series
> that was posted several times from late 2017 to end of
> February 2018. I did not get any timer related acks or
> comments so I applied it together with the PWM timer
> changes.
> 
> I'm guessing you may have accidentally checked out some
> older deja-vu branch from about a year ago? Commit
> 592ea6bd1fad is not related to this fix.. :)
> 

Just for the record, I said this patch fixes 592ea6bd1fad because
592ea6bd1fad should have been marked this function as static, which
would have exposed that this function was unused and it could have
been removed at that time. I know it is a bit of a stretch for this
commit (would be more appropriate for 008258d995a6 to have it) but
that was my logic behind it. Not opposed to having it removed before
committing.

Thanks,
Nathan

> Regards,
> 
> Tony
> 
> 
> 

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Tony Lindgren]

Hi,

* Daniel Lezcano  [190411 19:21]:
> On 10/04/2019 22:07, Tony Lindgren wrote:
> > Hi,
> > 
> > * Daniel Lezcano  [190410 17:02]:
> >> can you ask for an acked-by before pulling a patch in your tree?
> > 
> > I certainly do ask and wait for acks where possible :)
> 
> Ok, I may have missed them.
> 
> > Note that I have not applied this patch. I just added
> > Keerthy to Cc on this thread so maybe you misread the
> > message earlier. My comment "seems like no other
> > takers" was for Ladislav regarding somebody picking up
> > his earlier work, not for picking up this patch :)
> 
> Actually I was referring to the commit 592ea6bd1fad. Anyway as stated
> above I could have miss your call.

Hmm so commit 592ea6bd1fad was part of the PWM timer series
that was posted several times from late 2017 to end of
February 2018. I did not get any timer related acks or
comments so I applied it together with the PWM timer
changes.

I'm guessing you may have accidentally checked out some
older deja-vu branch from about a year ago? Commit
592ea6bd1fad is not related to this fix.. :)

Regards,

Tony

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Tony Lindgren]

Hi,

* Daniel Lezcano  [190411 20:13]:
> I can see those fixes in timers/core:
> 
> Fixes: 592ea6bd1fad ("clocksource: timer-ti-dm: Make unexported
> functions static")

Hmm so this one was over a year ago related to the PWM series :)

> Fixes: 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
> omap_dm_timer_set_load_start() static")

Seems the warnings started with this one.

Regards,

Tony

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Daniel Lezcano]

On 11/04/2019 21:36, Nathan Chancellor wrote:
> On Thu, Apr 11, 2019 at 09:20:56PM +0200, Daniel Lezcano wrote:
>> On 10/04/2019 22:07, Tony Lindgren wrote:
>>> Hi,
>>>
>>> * Daniel Lezcano  [190410 17:02]:
 can you ask for an acked-by before pulling a patch in your tree?
>>>
>>> I certainly do ask and wait for acks where possible :)
>>
>> Ok, I may have missed them.
>>
>>> Note that I have not applied this patch. I just added
>>> Keerthy to Cc on this thread so maybe you misread the
>>> message earlier. My comment "seems like no other
>>> takers" was for Ladislav regarding somebody picking up
>>> his earlier work, not for picking up this patch :)
>>
>> Actually I was referring to the commit 592ea6bd1fad. Anyway as stated
>> above I could have miss your call.
>>
>>> In any case, I've been waiting for you guys to pick up
>>> the patch, here's my ack if you're waiting for it:
>>>
>>> Acked-by: Tony Lindgren 
>>
>> The patch does not apply. Is it aligned with tip/timers/core ?
>>
> 
> The commit this fixes is in timers/urgent and it doesn't look like that
> has been backmerged into timers/core.

Anyway, probably simple to apply it directly to timers/urgent then.
That's good I have other patches for the branch.




-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Daniel Lezcano]

On 11/04/2019 21:36, Nathan Chancellor wrote:
> On Thu, Apr 11, 2019 at 09:20:56PM +0200, Daniel Lezcano wrote:
>> On 10/04/2019 22:07, Tony Lindgren wrote:
>>> Hi,
>>>
>>> * Daniel Lezcano  [190410 17:02]:
 can you ask for an acked-by before pulling a patch in your tree?
>>>
>>> I certainly do ask and wait for acks where possible :)
>>
>> Ok, I may have missed them.
>>
>>> Note that I have not applied this patch. I just added
>>> Keerthy to Cc on this thread so maybe you misread the
>>> message earlier. My comment "seems like no other
>>> takers" was for Ladislav regarding somebody picking up
>>> his earlier work, not for picking up this patch :)
>>
>> Actually I was referring to the commit 592ea6bd1fad. Anyway as stated
>> above I could have miss your call.
>>
>>> In any case, I've been waiting for you guys to pick up
>>> the patch, here's my ack if you're waiting for it:
>>>
>>> Acked-by: Tony Lindgren 
>>
>> The patch does not apply. Is it aligned with tip/timers/core ?
>>
> 
> The commit this fixes is in timers/urgent and it doesn't look like that
> has been backmerged into timers/core.

I can see those fixes in timers/core:

Fixes: 592ea6bd1fad ("clocksource: timer-ti-dm: Make unexported
functions static")
Fixes: 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
omap_dm_timer_set_load_start() static")


Are you referring to another fix?

 On 04/04/2019 16:17, Tony Lindgren wrote:
> * Ladislav Michl  [190327 08:12]:
>> Hello Nathan,
>>
>> On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote:
>>> Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
>>> omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
>>> static because its prototype was not defined in a header. Unfortunately,
>>> this causes a build warning on multi_v7_defconfig because this function
>>> is not used anywhere in this translation unit:
>>>
>>> drivers/clocksource/timer-ti-dm.c:589:12: error: unused function
>>> 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]
>>>
>>> In fact, omap_dm_timer_set_load_start hasn't been used anywhere since
>>> commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the
>>> prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
>>> Make unexported functions static"), which is probably where this should
>>> have happened.
>>
>> Alternatively you might want to look at "clocksource: timer-ti-dm: Add 
>> event
>> capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of
>> function being removed here). It is a part of an attempt to add event 
>> capture
>> for OMAP. Of course I would like this functionality to be implemented, 
>> but
>> as I do not have a time to continue, I cannot really object removing this
>> function.
>>
>> Just in case you'd be interested in finishing this task ;-)
>
> Well seems like no other takers :) We can always find the missing
> function in git history when needed, so I suggest we apply this.
>
> Adding Keerthy to Cc as he just posted a similar patch.
>
> Regards,
>
> Tony
>


 -- 
   Linaro.org │ Open source software for ARM SoCs

 Follow Linaro:   Facebook |
  Twitter |
  Blog

>>
>>
>> -- 
>>   Linaro.org │ Open source software for ARM SoCs
>>
>> Follow Linaro:   Facebook |
>>  Twitter |
>>  Blog
>>


-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Nathan Chancellor]

On Thu, Apr 11, 2019 at 09:20:56PM +0200, Daniel Lezcano wrote:
> On 10/04/2019 22:07, Tony Lindgren wrote:
> > Hi,
> > 
> > * Daniel Lezcano  [190410 17:02]:
> >> can you ask for an acked-by before pulling a patch in your tree?
> > 
> > I certainly do ask and wait for acks where possible :)
> 
> Ok, I may have missed them.
> 
> > Note that I have not applied this patch. I just added
> > Keerthy to Cc on this thread so maybe you misread the
> > message earlier. My comment "seems like no other
> > takers" was for Ladislav regarding somebody picking up
> > his earlier work, not for picking up this patch :)
> 
> Actually I was referring to the commit 592ea6bd1fad. Anyway as stated
> above I could have miss your call.
> 
> > In any case, I've been waiting for you guys to pick up
> > the patch, here's my ack if you're waiting for it:
> > 
> > Acked-by: Tony Lindgren 
> 
> The patch does not apply. Is it aligned with tip/timers/core ?
> 

The commit this fixes is in timers/urgent and it doesn't look like that
has been backmerged into timers/core.

Nathan

> >> On 04/04/2019 16:17, Tony Lindgren wrote:
> >>> * Ladislav Michl  [190327 08:12]:
>  Hello Nathan,
> 
>  On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote:
> > Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
> > omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
> > static because its prototype was not defined in a header. Unfortunately,
> > this causes a build warning on multi_v7_defconfig because this function
> > is not used anywhere in this translation unit:
> >
> > drivers/clocksource/timer-ti-dm.c:589:12: error: unused function
> > 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]
> >
> > In fact, omap_dm_timer_set_load_start hasn't been used anywhere since
> > commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the
> > prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
> > Make unexported functions static"), which is probably where this should
> > have happened.
> 
>  Alternatively you might want to look at "clocksource: timer-ti-dm: Add 
>  event
>  capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of
>  function being removed here). It is a part of an attempt to add event 
>  capture
>  for OMAP. Of course I would like this functionality to be implemented, 
>  but
>  as I do not have a time to continue, I cannot really object removing this
>  function.
> 
>  Just in case you'd be interested in finishing this task ;-)
> >>>
> >>> Well seems like no other takers :) We can always find the missing
> >>> function in git history when needed, so I suggest we apply this.
> >>>
> >>> Adding Keerthy to Cc as he just posted a similar patch.
> >>>
> >>> Regards,
> >>>
> >>> Tony
> >>>
> >>
> >>
> >> -- 
> >>   Linaro.org │ Open source software for ARM SoCs
> >>
> >> Follow Linaro:   Facebook |
> >>  Twitter |
> >>  Blog
> >>
> 
> 
> -- 
>   Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:   Facebook |
>  Twitter |
>  Blog
> 

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Daniel Lezcano]

On 10/04/2019 22:07, Tony Lindgren wrote:
> Hi,
> 
> * Daniel Lezcano  [190410 17:02]:
>> can you ask for an acked-by before pulling a patch in your tree?
> 
> I certainly do ask and wait for acks where possible :)

Ok, I may have missed them.

> Note that I have not applied this patch. I just added
> Keerthy to Cc on this thread so maybe you misread the
> message earlier. My comment "seems like no other
> takers" was for Ladislav regarding somebody picking up
> his earlier work, not for picking up this patch :)

Actually I was referring to the commit 592ea6bd1fad. Anyway as stated
above I could have miss your call.

> In any case, I've been waiting for you guys to pick up
> the patch, here's my ack if you're waiting for it:
> 
> Acked-by: Tony Lindgren 

The patch does not apply. Is it aligned with tip/timers/core ?

>> On 04/04/2019 16:17, Tony Lindgren wrote:
>>> * Ladislav Michl  [190327 08:12]:
 Hello Nathan,

 On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote:
> Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
> omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
> static because its prototype was not defined in a header. Unfortunately,
> this causes a build warning on multi_v7_defconfig because this function
> is not used anywhere in this translation unit:
>
> drivers/clocksource/timer-ti-dm.c:589:12: error: unused function
> 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]
>
> In fact, omap_dm_timer_set_load_start hasn't been used anywhere since
> commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the
> prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
> Make unexported functions static"), which is probably where this should
> have happened.

 Alternatively you might want to look at "clocksource: timer-ti-dm: Add 
 event
 capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of
 function being removed here). It is a part of an attempt to add event 
 capture
 for OMAP. Of course I would like this functionality to be implemented, but
 as I do not have a time to continue, I cannot really object removing this
 function.

 Just in case you'd be interested in finishing this task ;-)
>>>
>>> Well seems like no other takers :) We can always find the missing
>>> function in git history when needed, so I suggest we apply this.
>>>
>>> Adding Keerthy to Cc as he just posted a similar patch.
>>>
>>> Regards,
>>>
>>> Tony
>>>
>>
>>
>> -- 
>>   Linaro.org │ Open source software for ARM SoCs
>>
>> Follow Linaro:   Facebook |
>>  Twitter |
>>  Blog
>>


-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Tony Lindgren]

Hi,

* Daniel Lezcano  [190410 17:02]:
> can you ask for an acked-by before pulling a patch in your tree?

I certainly do ask and wait for acks where possible :)

Note that I have not applied this patch. I just added
Keerthy to Cc on this thread so maybe you misread the
message earlier. My comment "seems like no other
takers" was for Ladislav regarding somebody picking up
his earlier work, not for picking up this patch :)

In any case, I've been waiting for you guys to pick up
the patch, here's my ack if you're waiting for it:

Acked-by: Tony Lindgren 


> On 04/04/2019 16:17, Tony Lindgren wrote:
> > * Ladislav Michl  [190327 08:12]:
> >> Hello Nathan,
> >>
> >> On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote:
> >>> Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
> >>> omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
> >>> static because its prototype was not defined in a header. Unfortunately,
> >>> this causes a build warning on multi_v7_defconfig because this function
> >>> is not used anywhere in this translation unit:
> >>>
> >>> drivers/clocksource/timer-ti-dm.c:589:12: error: unused function
> >>> 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]
> >>>
> >>> In fact, omap_dm_timer_set_load_start hasn't been used anywhere since
> >>> commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the
> >>> prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
> >>> Make unexported functions static"), which is probably where this should
> >>> have happened.
> >>
> >> Alternatively you might want to look at "clocksource: timer-ti-dm: Add 
> >> event
> >> capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of
> >> function being removed here). It is a part of an attempt to add event 
> >> capture
> >> for OMAP. Of course I would like this functionality to be implemented, but
> >> as I do not have a time to continue, I cannot really object removing this
> >> function.
> >>
> >> Just in case you'd be interested in finishing this task ;-)
> > 
> > Well seems like no other takers :) We can always find the missing
> > function in git history when needed, so I suggest we apply this.
> > 
> > Adding Keerthy to Cc as he just posted a similar patch.
> > 
> > Regards,
> > 
> > Tony
> > 
> 
> 
> -- 
>   Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:   Facebook |
>  Twitter |
>  Blog
> 

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Daniel Lezcano]

Hi Tony,

can you ask for an acked-by before pulling a patch in your tree?



On 04/04/2019 16:17, Tony Lindgren wrote:
> * Ladislav Michl  [190327 08:12]:
>> Hello Nathan,
>>
>> On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote:
>>> Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
>>> omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
>>> static because its prototype was not defined in a header. Unfortunately,
>>> this causes a build warning on multi_v7_defconfig because this function
>>> is not used anywhere in this translation unit:
>>>
>>> drivers/clocksource/timer-ti-dm.c:589:12: error: unused function
>>> 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]
>>>
>>> In fact, omap_dm_timer_set_load_start hasn't been used anywhere since
>>> commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the
>>> prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
>>> Make unexported functions static"), which is probably where this should
>>> have happened.
>>
>> Alternatively you might want to look at "clocksource: timer-ti-dm: Add event
>> capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of
>> function being removed here). It is a part of an attempt to add event capture
>> for OMAP. Of course I would like this functionality to be implemented, but
>> as I do not have a time to continue, I cannot really object removing this
>> function.
>>
>> Just in case you'd be interested in finishing this task ;-)
> 
> Well seems like no other takers :) We can always find the missing
> function in git history when needed, so I suggest we apply this.
> 
> Adding Keerthy to Cc as he just posted a similar patch.
> 
> Regards,
> 
> Tony
> 


-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Keerthy]

On 04/04/19 7:47 PM, Tony Lindgren wrote:

* Ladislav Michl  [190327 08:12]:

Hello Nathan,

On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote:

Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
static because its prototype was not defined in a header. Unfortunately,
this causes a build warning on multi_v7_defconfig because this function
is not used anywhere in this translation unit:

drivers/clocksource/timer-ti-dm.c:589:12: error: unused function
'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]

In fact, omap_dm_timer_set_load_start hasn't been used anywhere since
commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the
prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should
have happened.


Alternatively you might want to look at "clocksource: timer-ti-dm: Add event
capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of
function being removed here). It is a part of an attempt to add event capture
for OMAP. Of course I would like this functionality to be implemented, but
as I do not have a time to continue, I cannot really object removing this
function.

Just in case you'd be interested in finishing this task ;-)


Well seems like no other takers :) We can always find the missing
function in git history when needed, so I suggest we apply this.

Adding Keerthy to Cc as he just posted a similar patch.


I posted the duplicate. Thanks for looping in.



Regards,

Tony

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Tony Lindgren]

* Ladislav Michl  [190327 08:12]:
> Hello Nathan,
> 
> On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote:
> > Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
> > omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
> > static because its prototype was not defined in a header. Unfortunately,
> > this causes a build warning on multi_v7_defconfig because this function
> > is not used anywhere in this translation unit:
> > 
> > drivers/clocksource/timer-ti-dm.c:589:12: error: unused function
> > 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]
> > 
> > In fact, omap_dm_timer_set_load_start hasn't been used anywhere since
> > commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the
> > prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
> > Make unexported functions static"), which is probably where this should
> > have happened.
> 
> Alternatively you might want to look at "clocksource: timer-ti-dm: Add event
> capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of
> function being removed here). It is a part of an attempt to add event capture
> for OMAP. Of course I would like this functionality to be implemented, but
> as I do not have a time to continue, I cannot really object removing this
> function.
> 
> Just in case you'd be interested in finishing this task ;-)

Well seems like no other takers :) We can always find the missing
function in git history when needed, so I suggest we apply this.

Adding Keerthy to Cc as he just posted a similar patch.

Regards,

Tony

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Ladislav Michl]

Hello Nathan,

On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote:
> Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
> omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
> static because its prototype was not defined in a header. Unfortunately,
> this causes a build warning on multi_v7_defconfig because this function
> is not used anywhere in this translation unit:
> 
> drivers/clocksource/timer-ti-dm.c:589:12: error: unused function
> 'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]
> 
> In fact, omap_dm_timer_set_load_start hasn't been used anywhere since
> commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the
> prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
> Make unexported functions static"), which is probably where this should
> have happened.

Alternatively you might want to look at "clocksource: timer-ti-dm: Add event
capture": https://patchwork.kernel.org/patch/10237217/ (it makes use of
function being removed here). It is a part of an attempt to add event capture
for OMAP. Of course I would like this functionality to be implemented, but
as I do not have a time to continue, I cannot really object removing this
function.

Just in case you'd be interested in finishing this task ;-)

ladis

> Fixes: 592ea6bd1fad ("clocksource: timer-ti-dm: Make unexported functions 
> static")
> Fixes: 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make 
> omap_dm_timer_set_load_start() static")
> Signed-off-by: Nathan Chancellor 
> ---
> 
> My apologies if this has already been sent, I didn't see anything in tip
> or on LKML.
> 
>  drivers/clocksource/timer-ti-dm.c | 28 
>  1 file changed, 28 deletions(-)
> 
> diff --git a/drivers/clocksource/timer-ti-dm.c 
> b/drivers/clocksource/timer-ti-dm.c
> index 3352da6ed61f..ee8ec5a8cb16 100644
> --- a/drivers/clocksource/timer-ti-dm.c
> +++ b/drivers/clocksource/timer-ti-dm.c
> @@ -585,34 +585,6 @@ static int omap_dm_timer_set_load(struct omap_dm_timer 
> *timer, int autoreload,
>   return 0;
>  }
>  
> -/* Optimized set_load which removes costly spin wait in timer_start */
> -static int omap_dm_timer_set_load_start(struct omap_dm_timer *timer,
> - int autoreload, unsigned int load)
> -{
> - u32 l;
> -
> - if (unlikely(!timer))
> - return -EINVAL;
> -
> - omap_dm_timer_enable(timer);
> -
> - l = omap_dm_timer_read_reg(timer, OMAP_TIMER_CTRL_REG);
> - if (autoreload) {
> - l |= OMAP_TIMER_CTRL_AR;
> - omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load);
> - } else {
> - l &= ~OMAP_TIMER_CTRL_AR;
> - }
> - l |= OMAP_TIMER_CTRL_ST;
> -
> - __omap_dm_timer_load_start(timer, l, load, timer->posted);
> -
> - /* Save the context */
> - timer->context.tclr = l;
> - timer->context.tldr = load;
> - timer->context.tcrr = load;
> - return 0;
> -}
>  static int omap_dm_timer_set_match(struct omap_dm_timer *timer, int enable,
>  

[PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

[Nathan Chancellor]

Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
static because its prototype was not defined in a header. Unfortunately,
this causes a build warning on multi_v7_defconfig because this function
is not used anywhere in this translation unit:

drivers/clocksource/timer-ti-dm.c:589:12: error: unused function
'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]

In fact, omap_dm_timer_set_load_start hasn't been used anywhere since
commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the
prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should
have happened.

Fixes: 592ea6bd1fad ("clocksource: timer-ti-dm: Make unexported functions 
static")
Fixes: 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make 
omap_dm_timer_set_load_start() static")
Signed-off-by: Nathan Chancellor 
---

My apologies if this has already been sent, I didn't see anything in tip
or on LKML.

 drivers/clocksource/timer-ti-dm.c | 28 
 1 file changed, 28 deletions(-)

diff --git a/drivers/clocksource/timer-ti-dm.c 
b/drivers/clocksource/timer-ti-dm.c
index 3352da6ed61f..ee8ec5a8cb16 100644
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -585,34 +585,6 @@ static int omap_dm_timer_set_load(struct omap_dm_timer 
*timer, int autoreload,
return 0;
 }
 
-/* Optimized set_load which removes costly spin wait in timer_start */
-static int omap_dm_timer_set_load_start(struct omap_dm_timer *timer,
-   int autoreload, unsigned int load)
-{
-   u32 l;
-
-   if (unlikely(!timer))
-   return -EINVAL;
-
-   omap_dm_timer_enable(timer);
-
-   l = omap_dm_timer_read_reg(timer, OMAP_TIMER_CTRL_REG);
-   if (autoreload) {
-   l |= OMAP_TIMER_CTRL_AR;
-   omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load);
-   } else {
-   l &= ~OMAP_TIMER_CTRL_AR;
-   }
-   l |= OMAP_TIMER_CTRL_ST;
-
-   __omap_dm_timer_load_start(timer, l, load, timer->posted);
-
-   /* Save the context */
-   timer->context.tclr = l;
-   timer->context.tldr = load;
-   timer->context.tcrr = load;
-   return 0;
-}
 static int omap_dm_timer_set_match(struct omap_dm_timer *timer, int enable,
   unsigned int match)
 {
-- 
2.21.0