Re: [PATCH] colons are invalid characters in netdev names
On 02/17/2015 07:28 PM, Stephen Hemminger wrote: > On Tue, 17 Feb 2015 17:15:42 -0600 > Matthew Thode wrote: > >> colons are used as a separator in netdev device lookup in dev_ioctl.c >> >> Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME >> >> Signed-off-by: Matthew Thode > > What is the exact sequence that causes the problem? > SIOCSIFNAME already strips of colon. > > It strips the name one access, not creation. You can create a dummy device and not access it, escaping doesn't seem to help. ip link add name foo:asdasd type dummy ip link del dev foo:asdasd # will not be deleted -- Matthew Thode signature.asc Description: OpenPGP digital signature
Re: [PATCH] colons are invalid characters in netdev names
On Tue, 17 Feb 2015 17:15:42 -0600 Matthew Thode wrote: > colons are used as a separator in netdev device lookup in dev_ioctl.c > > Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME > > Signed-off-by: Matthew Thode What is the exact sequence that causes the problem? SIOCSIFNAME already strips of colon. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] colons are invalid characters in netdev names
On 18.02.2015 00:57, Matthew Thode wrote: >> > You are correct, should I resend a patch. Not really sure the > procedure of updating a patchset sent to the ML. > You could resend as [PATCH v2] to indicate that it is an updated version. But you should also try to improve the patch subject line and description, e.g. by writing it in the imperative. See "SubmittingPatches" in the Documents folder of the kernel (or take a look at other patches). Regards, Lino -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] colons are invalid characters in netdev names
On 02/17/2015 05:46 PM, Lino Sanfilippo wrote:
> On 18.02.2015 00:15, Matthew Thode wrote:
>> colons are used as a separator in netdev device lookup in dev_ioctl.c
>>
>> Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME
>>
>> Signed-off-by: Matthew Thode
>> ---
>> net/core/dev.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/core/dev.c b/net/core/dev.c
>> index d030575..e9b6d5a 100644
>> --- a/net/core/dev.c
>> +++ b/net/core/dev.c
>> @@ -942,7 +942,7 @@ bool dev_valid_name(const char *name)
>> return false;
>> if (strlen(name) >= IFNAMSIZ)
>> return false;
>> -if (!strcmp(name, ".") || !strcmp(name, ".."))
>> +if (!strcmp(name, ".") || !strcmp(name, "..") || !strcmp(name, ":"))
>> return false;
>>
>> while (*name) {
>>
>
> Hi,
>
> that check should be done in the loop below, shouldn't it?
>
> Regards,
> Lino
>
You are correct, should I resend a patch. Not really sure the
procedure of updating a patchset sent to the ML.
--
Matthew Thode
signature.asc
Description: OpenPGP digital signature
Re: [PATCH] colons are invalid characters in netdev names
On 18.02.2015 00:15, Matthew Thode wrote:
> colons are used as a separator in netdev device lookup in dev_ioctl.c
>
> Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME
>
> Signed-off-by: Matthew Thode
> ---
> net/core/dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index d030575..e9b6d5a 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -942,7 +942,7 @@ bool dev_valid_name(const char *name)
> return false;
> if (strlen(name) >= IFNAMSIZ)
> return false;
> - if (!strcmp(name, ".") || !strcmp(name, ".."))
> + if (!strcmp(name, ".") || !strcmp(name, "..") || !strcmp(name, ":"))
> return false;
>
> while (*name) {
>
Hi,
that check should be done in the loop below, shouldn't it?
Regards,
Lino
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] colons are invalid characters in netdev names
colons are used as a separator in netdev device lookup in dev_ioctl.c
Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME
Signed-off-by: Matthew Thode
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index d030575..e9b6d5a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -942,7 +942,7 @@ bool dev_valid_name(const char *name)
return false;
if (strlen(name) >= IFNAMSIZ)
return false;
- if (!strcmp(name, ".") || !strcmp(name, ".."))
+ if (!strcmp(name, ".") || !strcmp(name, "..") || !strcmp(name, ":"))
return false;
while (*name) {
--
2.0.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] colons are invalid characters in netdev names
On 18.02.2015 00:57, Matthew Thode wrote: You are correct, should I resend a patch. Not really sure the procedure of updating a patchset sent to the ML. You could resend as [PATCH v2] to indicate that it is an updated version. But you should also try to improve the patch subject line and description, e.g. by writing it in the imperative. See SubmittingPatches in the Documents folder of the kernel (or take a look at other patches). Regards, Lino -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] colons are invalid characters in netdev names
On 02/17/2015 07:28 PM, Stephen Hemminger wrote: On Tue, 17 Feb 2015 17:15:42 -0600 Matthew Thode mth...@mthode.org wrote: colons are used as a separator in netdev device lookup in dev_ioctl.c Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME Signed-off-by: Matthew Thode mth...@mthode.org What is the exact sequence that causes the problem? SIOCSIFNAME already strips of colon. It strips the name one access, not creation. You can create a dummy device and not access it, escaping doesn't seem to help. ip link add name foo:asdasd type dummy ip link del dev foo:asdasd # will not be deleted -- Matthew Thode signature.asc Description: OpenPGP digital signature
[PATCH] colons are invalid characters in netdev names
colons are used as a separator in netdev device lookup in dev_ioctl.c
Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME
Signed-off-by: Matthew Thode mth...@mthode.org
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index d030575..e9b6d5a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -942,7 +942,7 @@ bool dev_valid_name(const char *name)
return false;
if (strlen(name) = IFNAMSIZ)
return false;
- if (!strcmp(name, .) || !strcmp(name, ..))
+ if (!strcmp(name, .) || !strcmp(name, ..) || !strcmp(name, :))
return false;
while (*name) {
--
2.0.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] colons are invalid characters in netdev names
On 18.02.2015 00:15, Matthew Thode wrote:
colons are used as a separator in netdev device lookup in dev_ioctl.c
Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME
Signed-off-by: Matthew Thode mth...@mthode.org
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index d030575..e9b6d5a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -942,7 +942,7 @@ bool dev_valid_name(const char *name)
return false;
if (strlen(name) = IFNAMSIZ)
return false;
- if (!strcmp(name, .) || !strcmp(name, ..))
+ if (!strcmp(name, .) || !strcmp(name, ..) || !strcmp(name, :))
return false;
while (*name) {
Hi,
that check should be done in the loop below, shouldn't it?
Regards,
Lino
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] colons are invalid characters in netdev names
On 02/17/2015 05:46 PM, Lino Sanfilippo wrote:
On 18.02.2015 00:15, Matthew Thode wrote:
colons are used as a separator in netdev device lookup in dev_ioctl.c
Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME
Signed-off-by: Matthew Thode mth...@mthode.org
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index d030575..e9b6d5a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -942,7 +942,7 @@ bool dev_valid_name(const char *name)
return false;
if (strlen(name) = IFNAMSIZ)
return false;
-if (!strcmp(name, .) || !strcmp(name, ..))
+if (!strcmp(name, .) || !strcmp(name, ..) || !strcmp(name, :))
return false;
while (*name) {
Hi,
that check should be done in the loop below, shouldn't it?
Regards,
Lino
You are correct, should I resend a patch. Not really sure the
procedure of updating a patchset sent to the ML.
--
Matthew Thode
signature.asc
Description: OpenPGP digital signature
Re: [PATCH] colons are invalid characters in netdev names
On Tue, 17 Feb 2015 17:15:42 -0600 Matthew Thode mth...@mthode.org wrote: colons are used as a separator in netdev device lookup in dev_ioctl.c Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME Signed-off-by: Matthew Thode mth...@mthode.org What is the exact sequence that causes the problem? SIOCSIFNAME already strips of colon. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
