Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-12 Thread Ian Abbott 

On 11/11/15 15:54, Ranjith Thangavel wrote:

BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith Thangavel 
---
  drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
  #define PARPORT_DATA_REG  0x00
  #define PARPORT_STATUS_REG0x01
  #define PARPORT_CTRL_REG  0x02
-#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA   BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)

  static int parport_data_reg_insn_bits(struct comedi_device *dev,
  struct comedi_subdevice *s,



Thanks!

Reviewed-by: Ian Abbott 

--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-12 Thread Ian Abbott 

On 11/11/15 15:54, Ranjith Thangavel wrote:

BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith Thangavel 
---
  drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
  #define PARPORT_DATA_REG  0x00
  #define PARPORT_STATUS_REG0x01
  #define PARPORT_CTRL_REG  0x02
-#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA   BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)

  static int parport_data_reg_insn_bits(struct comedi_device *dev,
  struct comedi_subdevice *s,



Thanks!

Reviewed-by: Ian Abbott 

--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ranjith Thangavel 
BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith Thangavel 
---
 drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
 #define PARPORT_DATA_REG   0x00
 #define PARPORT_STATUS_REG 0x01
 #define PARPORT_CTRL_REG   0x02
-#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA   BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)
 
 static int parport_data_reg_insn_bits(struct comedi_device *dev,
  struct comedi_subdevice *s,
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ian Abbott 

On 11/11/15 14:18, Ranjith T wrote:

Actually my name is Ranjith and father name is Thangavel. So I used to
mention my name as Ranjith T.


How do you write your name on legal documents?  That is what you should 
use on the patch's "Signed-off-by:" line, and on the email's "From:" line.


Thanks.

--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ranjith T 
Actually my name is Ranjith and father name is Thangavel. So I used to
mention my name as Ranjith T.


Thanks,
Ranjith T

On Wed, Nov 11, 2015 at 7:41 PM, Ian Abbott  wrote:
> On 11/11/2015 13:44, Ranjith T wrote:
>>
>> Is this patch is fine?.
>>
>> Thanks,
>> Ranjith T.
>
>
> Fine apart from the "Signed-off-by" line.  I'm guessing your last name isn't
> really "T".
>
>
>> On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T  wrote:
>>>
>>> BIT macro is used for defining BIT location instead of
>>> shifting operator - coding style issue
>>>
>>> Signed-off-by: Ranjith T 
>>> ---
>>>   drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c
>>> b/drivers/staging/comedi/drivers/comedi_parport.c
>>> index 15a4093..1bf8ddc 100644
>>> --- a/drivers/staging/comedi/drivers/comedi_parport.c
>>> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
>>> @@ -75,8 +75,8 @@
>>>   #define PARPORT_DATA_REG   0x00
>>>   #define PARPORT_STATUS_REG 0x01
>>>   #define PARPORT_CTRL_REG   0x02
>>> -#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
>>> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
>>> +#define PARPORT_CTRL_IRQ_ENA   BIT(4)
>>> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>>>
>>>   static int parport_data_reg_insn_bits(struct comedi_device *dev,
>>>struct comedi_subdevice *s,
>>> --
>>> 1.7.10.4
>
>
> --
> -=( Ian Abbott @ MEV Ltd.E-mail:  )=-
> -=(  Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ian Abbott 

On 11/11/2015 13:44, Ranjith T wrote:

Is this patch is fine?.

Thanks,
Ranjith T.


Fine apart from the "Signed-off-by" line.  I'm guessing your last name 
isn't really "T".



On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T  wrote:

BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith T 
---
  drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
  #define PARPORT_DATA_REG   0x00
  #define PARPORT_STATUS_REG 0x01
  #define PARPORT_CTRL_REG   0x02
-#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA   BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)

  static int parport_data_reg_insn_bits(struct comedi_device *dev,
   struct comedi_subdevice *s,
--
1.7.10.4


--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ranjith T 
Is this patch is fine?.

Thanks,
Ranjith T.

On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T  wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith T 
> ---
>  drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
> b/drivers/staging/comedi/drivers/comedi_parport.c
> index 15a4093..1bf8ddc 100644
> --- a/drivers/staging/comedi/drivers/comedi_parport.c
> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
> @@ -75,8 +75,8 @@
>  #define PARPORT_DATA_REG   0x00
>  #define PARPORT_STATUS_REG 0x01
>  #define PARPORT_CTRL_REG   0x02
> -#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
> +#define PARPORT_CTRL_IRQ_ENA   BIT(4)
> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>
>  static int parport_data_reg_insn_bits(struct comedi_device *dev,
>   struct comedi_subdevice *s,
> --
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ranjith T 
Is this patch is fine?.

Thanks,
Ranjith T.

On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T  wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith T 
> ---
>  drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
> b/drivers/staging/comedi/drivers/comedi_parport.c
> index 15a4093..1bf8ddc 100644
> --- a/drivers/staging/comedi/drivers/comedi_parport.c
> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
> @@ -75,8 +75,8 @@
>  #define PARPORT_DATA_REG   0x00
>  #define PARPORT_STATUS_REG 0x01
>  #define PARPORT_CTRL_REG   0x02
> -#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
> +#define PARPORT_CTRL_IRQ_ENA   BIT(4)
> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>
>  static int parport_data_reg_insn_bits(struct comedi_device *dev,
>   struct comedi_subdevice *s,
> --
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ian Abbott 

On 11/11/15 14:18, Ranjith T wrote:

Actually my name is Ranjith and father name is Thangavel. So I used to
mention my name as Ranjith T.


How do you write your name on legal documents?  That is what you should 
use on the patch's "Signed-off-by:" line, and on the email's "From:" line.


Thanks.

--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ranjith Thangavel 
BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith Thangavel 
---
 drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
 #define PARPORT_DATA_REG   0x00
 #define PARPORT_STATUS_REG 0x01
 #define PARPORT_CTRL_REG   0x02
-#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA   BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)
 
 static int parport_data_reg_insn_bits(struct comedi_device *dev,
  struct comedi_subdevice *s,
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ian Abbott 

On 11/11/2015 13:44, Ranjith T wrote:

Is this patch is fine?.

Thanks,
Ranjith T.


Fine apart from the "Signed-off-by" line.  I'm guessing your last name 
isn't really "T".



On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T  wrote:

BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith T 
---
  drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
  #define PARPORT_DATA_REG   0x00
  #define PARPORT_STATUS_REG 0x01
  #define PARPORT_CTRL_REG   0x02
-#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA   BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)

  static int parport_data_reg_insn_bits(struct comedi_device *dev,
   struct comedi_subdevice *s,
--
1.7.10.4


--
-=( Ian Abbott @ MEV Ltd.E-mail:  )=-
-=(  Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ranjith T 
Actually my name is Ranjith and father name is Thangavel. So I used to
mention my name as Ranjith T.


Thanks,
Ranjith T

On Wed, Nov 11, 2015 at 7:41 PM, Ian Abbott  wrote:
> On 11/11/2015 13:44, Ranjith T wrote:
>>
>> Is this patch is fine?.
>>
>> Thanks,
>> Ranjith T.
>
>
> Fine apart from the "Signed-off-by" line.  I'm guessing your last name isn't
> really "T".
>
>
>> On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T  wrote:
>>>
>>> BIT macro is used for defining BIT location instead of
>>> shifting operator - coding style issue
>>>
>>> Signed-off-by: Ranjith T 
>>> ---
>>>   drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c
>>> b/drivers/staging/comedi/drivers/comedi_parport.c
>>> index 15a4093..1bf8ddc 100644
>>> --- a/drivers/staging/comedi/drivers/comedi_parport.c
>>> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
>>> @@ -75,8 +75,8 @@
>>>   #define PARPORT_DATA_REG   0x00
>>>   #define PARPORT_STATUS_REG 0x01
>>>   #define PARPORT_CTRL_REG   0x02
>>> -#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
>>> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
>>> +#define PARPORT_CTRL_IRQ_ENA   BIT(4)
>>> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>>>
>>>   static int parport_data_reg_insn_bits(struct comedi_device *dev,
>>>struct comedi_subdevice *s,
>>> --
>>> 1.7.10.4
>
>
> --
> -=( Ian Abbott @ MEV Ltd.E-mail:  )=-
> -=(  Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-09 Thread Ranjith T 
BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith T 
---
 drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
 #define PARPORT_DATA_REG   0x00
 #define PARPORT_STATUS_REG 0x01
 #define PARPORT_CTRL_REG   0x02
-#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA   BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)
 
 static int parport_data_reg_insn_bits(struct comedi_device *dev,
  struct comedi_subdevice *s,
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-09 Thread Hartley Sweeten 
On Monday, November 09, 2015 8:17 AM, Ranjith wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith 
> ---
>  drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
> b/drivers/staging/comedi/drivers/comedi_parport.c
> index 15a4093..1bf8ddc 100644
> --- a/drivers/staging/comedi/drivers/comedi_parport.c
> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
> @@ -75,8 +75,8 @@
>  #define PARPORT_DATA_REG 0x00
>  #define PARPORT_STATUS_REG   0x01
>  #define PARPORT_CTRL_REG 0x02
> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
> -#define PARPORT_CTRL_BIDIR_ENA   (1 << 5)
> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
> +#define PARPORT_CTRL_BIDIR_ENA   BIT(5)
>  
>  static int parport_data_reg_insn_bits(struct comedi_device *dev,
> struct comedi_subdevice *s,

Hello,

No problems with the patch but your sign-off needs to include your
full legal name.

Regards,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-09 Thread Ranjith 
BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith 
---
 drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
 #define PARPORT_DATA_REG   0x00
 #define PARPORT_STATUS_REG 0x01
 #define PARPORT_CTRL_REG   0x02
-#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA   BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)
 
 static int parport_data_reg_insn_bits(struct comedi_device *dev,
  struct comedi_subdevice *s,
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-09 Thread Ranjith T 
BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith T 
---
 drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
 #define PARPORT_DATA_REG   0x00
 #define PARPORT_STATUS_REG 0x01
 #define PARPORT_CTRL_REG   0x02
-#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA   BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)
 
 static int parport_data_reg_insn_bits(struct comedi_device *dev,
  struct comedi_subdevice *s,
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-09 Thread Hartley Sweeten 
On Monday, November 09, 2015 8:17 AM, Ranjith wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith 
> ---
>  drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
> b/drivers/staging/comedi/drivers/comedi_parport.c
> index 15a4093..1bf8ddc 100644
> --- a/drivers/staging/comedi/drivers/comedi_parport.c
> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
> @@ -75,8 +75,8 @@
>  #define PARPORT_DATA_REG 0x00
>  #define PARPORT_STATUS_REG   0x01
>  #define PARPORT_CTRL_REG 0x02
> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
> -#define PARPORT_CTRL_BIDIR_ENA   (1 << 5)
> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
> +#define PARPORT_CTRL_BIDIR_ENA   BIT(5)
>  
>  static int parport_data_reg_insn_bits(struct comedi_device *dev,
> struct comedi_subdevice *s,

Hello,

No problems with the patch but your sign-off needs to include your
full legal name.

Regards,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-09 Thread Ranjith 
BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith 
---
 drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c 
b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
 #define PARPORT_DATA_REG   0x00
 #define PARPORT_STATUS_REG 0x01
 #define PARPORT_CTRL_REG   0x02
-#define PARPORT_CTRL_IRQ_ENA   (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA   BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)
 
 static int parport_data_reg_insn_bits(struct comedi_device *dev,
  struct comedi_subdevice *s,
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/