Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
On Mon, Jul 23 2007, Andrew Morton wrote:
> On Sat, 21 Jul 2007 01:08:57 +0200
> Arnd Bergmann <[EMAIL PROTECTED]> wrote:
>
> > On Saturday 21 July 2007, Sebastian Siewior wrote:
> > >
> > > Got with randconfig
> > > include/linux/loop.h:66: error: expected specifier-qualifier-list before
> > > 'request_queue_t'
> > > make[1]: *** [fs/compat_ioctl.o] Error 1
> > >
> > > parts of compat ioctl require CONFIG_BLOCK to be set.
> > >
> > > Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
> > > Index: b/fs/compat_ioctl.c
> > > ===
> > > --- a/fs/compat_ioctl.c
> > > +++ b/fs/compat_ioctl.c
> > > @@ -63,7 +63,9 @@
> > > __#include
> > > __#include
> > > __#include
> > > +#ifdef CONFIG_BLOCK
> > > __#include
> > > +#endif
> >
> > Adding #ifdef around an #include is considered bad style. Better just
> > make loop.h compile without any conditionals. Does the below
> > patch work for you?
>
> This is the classic why-typedefs-are-bad. AFAIK there is no way of fixing
> this build error apart from adding otherwise-unneeded nested inclusions
> (very bad), or:
>
> > Arnd <><
> >
> > --- a/include/linux/loop.h
> > +++ b/include/linux/loop.h
> > @@ -63,7 +63,7 @@ struct loop_device {
> > struct task_struct *lo_thread;
> > wait_queue_head_t lo_event;
> >
> > - request_queue_t *lo_queue;
> > + struct request_queue*lo_queue;
> > struct gendisk *lo_disk;
> > struct list_headlo_list;
> > };
>
> Good start. Now can we do the rest of the kernel? ;)
Yep indeed, it's been my plan to kill that ugly typedef for some time...
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
On Mon, Jul 23 2007, Andrew Morton wrote:
On Sat, 21 Jul 2007 01:08:57 +0200
Arnd Bergmann [EMAIL PROTECTED] wrote:
On Saturday 21 July 2007, Sebastian Siewior wrote:
Got with randconfig
include/linux/loop.h:66: error: expected specifier-qualifier-list before
'request_queue_t'
make[1]: *** [fs/compat_ioctl.o] Error 1
parts of compat ioctl require CONFIG_BLOCK to be set.
Signed-off-by: Sebastian Siewior [EMAIL PROTECTED]
Index: b/fs/compat_ioctl.c
===
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -63,7 +63,9 @@
__#include linux/wireless.h
__#include linux/atalk.h
__#include linux/blktrace_api.h
+#ifdef CONFIG_BLOCK
__#include linux/loop.h
+#endif
Adding #ifdef around an #include is considered bad style. Better just
make loop.h compile without any conditionals. Does the below
patch work for you?
This is the classic why-typedefs-are-bad. AFAIK there is no way of fixing
this build error apart from adding otherwise-unneeded nested inclusions
(very bad), or:
Arnd
--- a/include/linux/loop.h
+++ b/include/linux/loop.h
@@ -63,7 +63,7 @@ struct loop_device {
struct task_struct *lo_thread;
wait_queue_head_t lo_event;
- request_queue_t *lo_queue;
+ struct request_queue*lo_queue;
struct gendisk *lo_disk;
struct list_headlo_list;
};
Good start. Now can we do the rest of the kernel? ;)
Yep indeed, it's been my plan to kill that ugly typedef for some time...
--
Jens Axboe
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
On Sat, 21 Jul 2007 01:08:57 +0200
Arnd Bergmann <[EMAIL PROTECTED]> wrote:
> On Saturday 21 July 2007, Sebastian Siewior wrote:
> >
> > Got with randconfig
> > include/linux/loop.h:66: error: expected specifier-qualifier-list before
> > 'request_queue_t'
> > make[1]: *** [fs/compat_ioctl.o] Error 1
> >
> > parts of compat ioctl require CONFIG_BLOCK to be set.
> >
> > Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
> > Index: b/fs/compat_ioctl.c
> > ===
> > --- a/fs/compat_ioctl.c
> > +++ b/fs/compat_ioctl.c
> > @@ -63,7 +63,9 @@
> > __#include
> > __#include
> > __#include
> > +#ifdef CONFIG_BLOCK
> > __#include
> > +#endif
>
> Adding #ifdef around an #include is considered bad style. Better just
> make loop.h compile without any conditionals. Does the below
> patch work for you?
This is the classic why-typedefs-are-bad. AFAIK there is no way of fixing
this build error apart from adding otherwise-unneeded nested inclusions
(very bad), or:
> Arnd <><
>
> --- a/include/linux/loop.h
> +++ b/include/linux/loop.h
> @@ -63,7 +63,7 @@ struct loop_device {
> struct task_struct *lo_thread;
> wait_queue_head_t lo_event;
>
> - request_queue_t *lo_queue;
> + struct request_queue*lo_queue;
> struct gendisk *lo_disk;
> struct list_headlo_list;
> };
Good start. Now can we do the rest of the kernel? ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
On Sat, 21 Jul 2007 01:08:57 +0200
Arnd Bergmann [EMAIL PROTECTED] wrote:
On Saturday 21 July 2007, Sebastian Siewior wrote:
Got with randconfig
include/linux/loop.h:66: error: expected specifier-qualifier-list before
'request_queue_t'
make[1]: *** [fs/compat_ioctl.o] Error 1
parts of compat ioctl require CONFIG_BLOCK to be set.
Signed-off-by: Sebastian Siewior [EMAIL PROTECTED]
Index: b/fs/compat_ioctl.c
===
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -63,7 +63,9 @@
__#include linux/wireless.h
__#include linux/atalk.h
__#include linux/blktrace_api.h
+#ifdef CONFIG_BLOCK
__#include linux/loop.h
+#endif
Adding #ifdef around an #include is considered bad style. Better just
make loop.h compile without any conditionals. Does the below
patch work for you?
This is the classic why-typedefs-are-bad. AFAIK there is no way of fixing
this build error apart from adding otherwise-unneeded nested inclusions
(very bad), or:
Arnd
--- a/include/linux/loop.h
+++ b/include/linux/loop.h
@@ -63,7 +63,7 @@ struct loop_device {
struct task_struct *lo_thread;
wait_queue_head_t lo_event;
- request_queue_t *lo_queue;
+ struct request_queue*lo_queue;
struct gendisk *lo_disk;
struct list_headlo_list;
};
Good start. Now can we do the rest of the kernel? ;)
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
On Saturday 21 July 2007, Christoph Hellwig wrote: > > > Adding #ifdef around an #include is considered bad style. Better just > > make loop.h compile without any conditionals. Does the below > > patch work for you? > > That patch looks good, but even better would be adding a compat_ioctl > handler to the loop driver. IIRC you even have an old patch for that No, that doesn't fly in this case. The loop driver actually has a compat_ioctl method, but the problem is that some tools try to call this ioctl on devices other than loop. We could of course add a fallback handler to compat_blkdev_ioctl(), but I'm not convinced that this is better than the IGNORE_IOCTL helper, unless we eventually move all of fs/compat_ioctl.c into drivers. Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
On Sat, Jul 21, 2007 at 01:08:57AM +0200, Arnd Bergmann wrote: > On Saturday 21 July 2007, Sebastian Siewior wrote: > > > > Got with randconfig > > include/linux/loop.h:66: error: expected specifier-qualifier-list before > > 'request_queue_t' > > make[1]: *** [fs/compat_ioctl.o] Error 1 > > > > parts of compat ioctl require CONFIG_BLOCK to be set. > > > > Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]> > > Index: b/fs/compat_ioctl.c > > === > > --- a/fs/compat_ioctl.c > > +++ b/fs/compat_ioctl.c > > @@ -63,7 +63,9 @@ > > ?#include > > ?#include > > ?#include > > +#ifdef CONFIG_BLOCK > > ?#include > > +#endif > > Adding #ifdef around an #include is considered bad style. Better just > make loop.h compile without any conditionals. Does the below > patch work for you? That patch looks good, but even better would be adding a compat_ioctl handler to the loop driver. IIRC you even have an old patch for that :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
* Arnd Bergmann | 2007-07-21 01:08:57 [+0200]:
>On Saturday 21 July 2007, Sebastian Siewior wrote:
>>
>> Got with randconfig
>> include/linux/loop.h:66: error: expected specifier-qualifier-list before
>> 'request_queue_t'
>> make[1]: *** [fs/compat_ioctl.o] Error 1
>>
>> parts of compat ioctl require CONFIG_BLOCK to be set.
>>
>> Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
>> Index: b/fs/compat_ioctl.c
>> ===
>> --- a/fs/compat_ioctl.c
>> +++ b/fs/compat_ioctl.c
>> @@ -63,7 +63,9 @@
>> #include
>> #include
>> #include
>> +#ifdef CONFIG_BLOCK
>> #include
>> +#endif
>
>Adding #ifdef around an #include is considered bad style. Better just
>make loop.h compile without any conditionals. Does the below
>patch work for you?
>
Yes it does.
> Arnd <><
Sebastian
>
>--- a/include/linux/loop.h
>+++ b/include/linux/loop.h
>@@ -63,7 +63,7 @@ struct loop_device {
> struct task_struct *lo_thread;
> wait_queue_head_t lo_event;
>
>- request_queue_t *lo_queue;
>+ struct request_queue*lo_queue;
> struct gendisk *lo_disk;
> struct list_headlo_list;
> };
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
* Arnd Bergmann | 2007-07-21 01:08:57 [+0200]:
On Saturday 21 July 2007, Sebastian Siewior wrote:
Got with randconfig
include/linux/loop.h:66: error: expected specifier-qualifier-list before
'request_queue_t'
make[1]: *** [fs/compat_ioctl.o] Error 1
parts of compat ioctl require CONFIG_BLOCK to be set.
Signed-off-by: Sebastian Siewior [EMAIL PROTECTED]
Index: b/fs/compat_ioctl.c
===
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -63,7 +63,9 @@
#include linux/wireless.h
#include linux/atalk.h
#include linux/blktrace_api.h
+#ifdef CONFIG_BLOCK
#include linux/loop.h
+#endif
Adding #ifdef around an #include is considered bad style. Better just
make loop.h compile without any conditionals. Does the below
patch work for you?
Yes it does.
Arnd
Sebastian
--- a/include/linux/loop.h
+++ b/include/linux/loop.h
@@ -63,7 +63,7 @@ struct loop_device {
struct task_struct *lo_thread;
wait_queue_head_t lo_event;
- request_queue_t *lo_queue;
+ struct request_queue*lo_queue;
struct gendisk *lo_disk;
struct list_headlo_list;
};
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
On Sat, Jul 21, 2007 at 01:08:57AM +0200, Arnd Bergmann wrote: On Saturday 21 July 2007, Sebastian Siewior wrote: Got with randconfig include/linux/loop.h:66: error: expected specifier-qualifier-list before 'request_queue_t' make[1]: *** [fs/compat_ioctl.o] Error 1 parts of compat ioctl require CONFIG_BLOCK to be set. Signed-off-by: Sebastian Siewior [EMAIL PROTECTED] Index: b/fs/compat_ioctl.c === --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c @@ -63,7 +63,9 @@ ?#include linux/wireless.h ?#include linux/atalk.h ?#include linux/blktrace_api.h +#ifdef CONFIG_BLOCK ?#include linux/loop.h +#endif Adding #ifdef around an #include is considered bad style. Better just make loop.h compile without any conditionals. Does the below patch work for you? That patch looks good, but even better would be adding a compat_ioctl handler to the loop driver. IIRC you even have an old patch for that :) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
On Saturday 21 July 2007, Christoph Hellwig wrote: Adding #ifdef around an #include is considered bad style. Better just make loop.h compile without any conditionals. Does the below patch work for you? That patch looks good, but even better would be adding a compat_ioctl handler to the loop driver. IIRC you even have an old patch for that No, that doesn't fly in this case. The loop driver actually has a compat_ioctl method, but the problem is that some tools try to call this ioctl on devices other than loop. We could of course add a fallback handler to compat_blkdev_ioctl(), but I'm not convinced that this is better than the IGNORE_IOCTL helper, unless we eventually move all of fs/compat_ioctl.c into drivers. Arnd - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
On Saturday 21 July 2007, Sebastian Siewior wrote:
>
> Got with randconfig
> include/linux/loop.h:66: error: expected specifier-qualifier-list before
> 'request_queue_t'
> make[1]: *** [fs/compat_ioctl.o] Error 1
>
> parts of compat ioctl require CONFIG_BLOCK to be set.
>
> Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
> Index: b/fs/compat_ioctl.c
> ===
> --- a/fs/compat_ioctl.c
> +++ b/fs/compat_ioctl.c
> @@ -63,7 +63,9 @@
> #include
> #include
> #include
> +#ifdef CONFIG_BLOCK
> #include
> +#endif
Adding #ifdef around an #include is considered bad style. Better just
make loop.h compile without any conditionals. Does the below
patch work for you?
Arnd <><
--- a/include/linux/loop.h
+++ b/include/linux/loop.h
@@ -63,7 +63,7 @@ struct loop_device {
struct task_struct *lo_thread;
wait_queue_head_t lo_event;
- request_queue_t *lo_queue;
+ struct request_queue*lo_queue;
struct gendisk *lo_disk;
struct list_headlo_list;
};
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] compat_ioctl requires CONFIG_BLOCK
Got with randconfig include/linux/loop.h:66: error: expected specifier-qualifier-list before 'request_queue_t' make[1]: *** [fs/compat_ioctl.o] Error 1 parts of compat ioctl require CONFIG_BLOCK to be set. Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]> Index: b/fs/compat_ioctl.c === --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c @@ -63,7 +63,9 @@ #include #include #include +#ifdef CONFIG_BLOCK #include +#endif #include #include @@ -3491,8 +3493,10 @@ HANDLE_IOCTL(LPSETTIMEOUT, lp_timeout_tr IGNORE_IOCTL(VFAT_IOCTL_READDIR_BOTH32) IGNORE_IOCTL(VFAT_IOCTL_READDIR_SHORT32) +#ifdef CONFIG_BLOCK /* loop */ IGNORE_IOCTL(LOOP_CLR_FD) +#endif }; #define IOCTL_HASHSIZE 256 -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] compat_ioctl requires CONFIG_BLOCK
Got with randconfig include/linux/loop.h:66: error: expected specifier-qualifier-list before 'request_queue_t' make[1]: *** [fs/compat_ioctl.o] Error 1 parts of compat ioctl require CONFIG_BLOCK to be set. Signed-off-by: Sebastian Siewior [EMAIL PROTECTED] Index: b/fs/compat_ioctl.c === --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c @@ -63,7 +63,9 @@ #include linux/wireless.h #include linux/atalk.h #include linux/blktrace_api.h +#ifdef CONFIG_BLOCK #include linux/loop.h +#endif #include net/bluetooth/bluetooth.h #include net/bluetooth/hci.h @@ -3491,8 +3493,10 @@ HANDLE_IOCTL(LPSETTIMEOUT, lp_timeout_tr IGNORE_IOCTL(VFAT_IOCTL_READDIR_BOTH32) IGNORE_IOCTL(VFAT_IOCTL_READDIR_SHORT32) +#ifdef CONFIG_BLOCK /* loop */ IGNORE_IOCTL(LOOP_CLR_FD) +#endif }; #define IOCTL_HASHSIZE 256 -- - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
On Saturday 21 July 2007, Sebastian Siewior wrote:
Got with randconfig
include/linux/loop.h:66: error: expected specifier-qualifier-list before
'request_queue_t'
make[1]: *** [fs/compat_ioctl.o] Error 1
parts of compat ioctl require CONFIG_BLOCK to be set.
Signed-off-by: Sebastian Siewior [EMAIL PROTECTED]
Index: b/fs/compat_ioctl.c
===
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -63,7 +63,9 @@
#include linux/wireless.h
#include linux/atalk.h
#include linux/blktrace_api.h
+#ifdef CONFIG_BLOCK
#include linux/loop.h
+#endif
Adding #ifdef around an #include is considered bad style. Better just
make loop.h compile without any conditionals. Does the below
patch work for you?
Arnd
--- a/include/linux/loop.h
+++ b/include/linux/loop.h
@@ -63,7 +63,7 @@ struct loop_device {
struct task_struct *lo_thread;
wait_queue_head_t lo_event;
- request_queue_t *lo_queue;
+ struct request_queue*lo_queue;
struct gendisk *lo_disk;
struct list_headlo_list;
};
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
