Re: [PATCH] configfs: export config_group_find_obj
On Thu, Aug 18, 2005 at 02:20:23PM -0700, Joel Becker wrote: > On Thu, Aug 18, 2005 at 02:17:49PM -0700, Joel Becker wrote: > > On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote: > > > In the dlm I use config_group_find_obj() which isn't exported. > > > > Did you notice the /* XXX Locking */? Let me go see how you use > > it, if it is the best way, we'll need to revisit the function and be > > sure it's happy. > > Yeah, your usage is unsafe, but the fault lies with find_obj(). > Needs fixing. And you copied the same issue into get_comm(). When navigating cg_children (or any part of the object tree), you need to be holding the subsystem semaphore. Someone could race with mkdir/rmdir. Joel -- "Senator let's be sincere, As much as you can." http://www.jlbec.org/ [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] configfs: export config_group_find_obj
On Thu, Aug 18, 2005 at 02:17:49PM -0700, Joel Becker wrote: > On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote: > > In the dlm I use config_group_find_obj() which isn't exported. > > Did you notice the /* XXX Locking */? Let me go see how you use > it, if it is the best way, we'll need to revisit the function and be > sure it's happy. Yeah, your usage is unsafe, but the fault lies with find_obj(). Needs fixing. Joel -- "Vote early and vote often." - Al Capone http://www.jlbec.org/ [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] configfs: export config_group_find_obj
On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote: > In the dlm I use config_group_find_obj() which isn't exported. Did you notice the /* XXX Locking */? Let me go see how you use it, if it is the best way, we'll need to revisit the function and be sure it's happy. Joel > > Signed-off-by: David Teigland <[EMAIL PROTECTED]> > > diff -urpN a/fs/configfs/item.c b/fs/configfs/item.c > --- a/fs/configfs/item.c 2005-08-17 17:19:23.0 +0800 > +++ b/fs/configfs/item.c 2005-08-18 14:15:51.681973168 +0800 > @@ -224,4 +224,5 @@ EXPORT_SYMBOL(config_item_init); > EXPORT_SYMBOL(config_group_init); > EXPORT_SYMBOL(config_item_get); > EXPORT_SYMBOL(config_item_put); > +EXPORT_SYMBOL(config_group_find_obj); > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- "Time is an illusion, lunchtime doubly so." -Douglas Adams http://www.jlbec.org/ [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] configfs: export config_group_find_obj
On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote: In the dlm I use config_group_find_obj() which isn't exported. Did you notice the /* XXX Locking */? Let me go see how you use it, if it is the best way, we'll need to revisit the function and be sure it's happy. Joel Signed-off-by: David Teigland [EMAIL PROTECTED] diff -urpN a/fs/configfs/item.c b/fs/configfs/item.c --- a/fs/configfs/item.c 2005-08-17 17:19:23.0 +0800 +++ b/fs/configfs/item.c 2005-08-18 14:15:51.681973168 +0800 @@ -224,4 +224,5 @@ EXPORT_SYMBOL(config_item_init); EXPORT_SYMBOL(config_group_init); EXPORT_SYMBOL(config_item_get); EXPORT_SYMBOL(config_item_put); +EXPORT_SYMBOL(config_group_find_obj); - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Time is an illusion, lunchtime doubly so. -Douglas Adams http://www.jlbec.org/ [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] configfs: export config_group_find_obj
On Thu, Aug 18, 2005 at 02:17:49PM -0700, Joel Becker wrote: On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote: In the dlm I use config_group_find_obj() which isn't exported. Did you notice the /* XXX Locking */? Let me go see how you use it, if it is the best way, we'll need to revisit the function and be sure it's happy. Yeah, your usage is unsafe, but the fault lies with find_obj(). Needs fixing. Joel -- Vote early and vote often. - Al Capone http://www.jlbec.org/ [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] configfs: export config_group_find_obj
On Thu, Aug 18, 2005 at 02:20:23PM -0700, Joel Becker wrote: On Thu, Aug 18, 2005 at 02:17:49PM -0700, Joel Becker wrote: On Thu, Aug 18, 2005 at 02:26:02PM +0800, David Teigland wrote: In the dlm I use config_group_find_obj() which isn't exported. Did you notice the /* XXX Locking */? Let me go see how you use it, if it is the best way, we'll need to revisit the function and be sure it's happy. Yeah, your usage is unsafe, but the fault lies with find_obj(). Needs fixing. And you copied the same issue into get_comm(). When navigating cg_children (or any part of the object tree), you need to be holding the subsystem semaphore. Someone could race with mkdir/rmdir. Joel -- Senator let's be sincere, As much as you can. http://www.jlbec.org/ [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] configfs: export config_group_find_obj
In the dlm I use config_group_find_obj() which isn't exported. Signed-off-by: David Teigland <[EMAIL PROTECTED]> diff -urpN a/fs/configfs/item.c b/fs/configfs/item.c --- a/fs/configfs/item.c2005-08-17 17:19:23.0 +0800 +++ b/fs/configfs/item.c2005-08-18 14:15:51.681973168 +0800 @@ -224,4 +224,5 @@ EXPORT_SYMBOL(config_item_init); EXPORT_SYMBOL(config_group_init); EXPORT_SYMBOL(config_item_get); EXPORT_SYMBOL(config_item_put); +EXPORT_SYMBOL(config_group_find_obj); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] configfs: export config_group_find_obj
In the dlm I use config_group_find_obj() which isn't exported. Signed-off-by: David Teigland [EMAIL PROTECTED] diff -urpN a/fs/configfs/item.c b/fs/configfs/item.c --- a/fs/configfs/item.c2005-08-17 17:19:23.0 +0800 +++ b/fs/configfs/item.c2005-08-18 14:15:51.681973168 +0800 @@ -224,4 +224,5 @@ EXPORT_SYMBOL(config_item_init); EXPORT_SYMBOL(config_group_init); EXPORT_SYMBOL(config_item_get); EXPORT_SYMBOL(config_item_put); +EXPORT_SYMBOL(config_group_find_obj); - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
