Re: [PATCH] cpufreq: pcc-cpufreq: Fail initialization if driver cannot be registered

[Rafael J. Wysocki]

On Friday, June 7, 2019 5:05:46 AM CEST Viresh Kumar wrote:
> On 06-06-19, 14:50, David Arcari wrote:
> > Make pcc_cpufreq_init() return error codes when the driver cannot be
> > registered.  Otherwise the driver can shows up loaded via lsmod even
> > though it failed initialization.  This is confusing to the user.
> > 
> > Signed-off-by: David Arcari 
> > Cc: "Rafael J. Wysocki" 
> > Cc: Viresh Kumar 
> > ---
> >  drivers/cpufreq/pcc-cpufreq.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
> > index 1e5e64643c3a..fdc767fdbe6a 100644
> > --- a/drivers/cpufreq/pcc-cpufreq.c
> > +++ b/drivers/cpufreq/pcc-cpufreq.c
> > @@ -582,10 +582,10 @@ static int __init pcc_cpufreq_init(void)
> >  
> > /* Skip initialization if another cpufreq driver is there. */
> > if (cpufreq_get_current_driver())
> > -   return 0;
> > +   return -EEXIST;
> >  
> > if (acpi_disabled)
> > -   return 0;
> > +   return -ENODEV;
> >  
> > ret = pcc_cpufreq_probe();
> > if (ret) {
> 
> Acked-by: Viresh Kumar 

Applied, thanks!

Re: [PATCH] cpufreq: pcc-cpufreq: Fail initialization if driver cannot be registered

[Viresh Kumar]

On 06-06-19, 14:50, David Arcari wrote:
> Make pcc_cpufreq_init() return error codes when the driver cannot be
> registered.  Otherwise the driver can shows up loaded via lsmod even
> though it failed initialization.  This is confusing to the user.
> 
> Signed-off-by: David Arcari 
> Cc: "Rafael J. Wysocki" 
> Cc: Viresh Kumar 
> ---
>  drivers/cpufreq/pcc-cpufreq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
> index 1e5e64643c3a..fdc767fdbe6a 100644
> --- a/drivers/cpufreq/pcc-cpufreq.c
> +++ b/drivers/cpufreq/pcc-cpufreq.c
> @@ -582,10 +582,10 @@ static int __init pcc_cpufreq_init(void)
>  
>   /* Skip initialization if another cpufreq driver is there. */
>   if (cpufreq_get_current_driver())
> - return 0;
> + return -EEXIST;
>  
>   if (acpi_disabled)
> - return 0;
> + return -ENODEV;
>  
>   ret = pcc_cpufreq_probe();
>   if (ret) {

Acked-by: Viresh Kumar 

-- 
viresh

[PATCH] cpufreq: pcc-cpufreq: Fail initialization if driver cannot be registered

[David Arcari]

Make pcc_cpufreq_init() return error codes when the driver cannot be
registered.  Otherwise the driver can shows up loaded via lsmod even
though it failed initialization.  This is confusing to the user.

Signed-off-by: David Arcari 
Cc: "Rafael J. Wysocki" 
Cc: Viresh Kumar 
---
 drivers/cpufreq/pcc-cpufreq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
index 1e5e64643c3a..fdc767fdbe6a 100644
--- a/drivers/cpufreq/pcc-cpufreq.c
+++ b/drivers/cpufreq/pcc-cpufreq.c
@@ -582,10 +582,10 @@ static int __init pcc_cpufreq_init(void)
 
/* Skip initialization if another cpufreq driver is there. */
if (cpufreq_get_current_driver())
-   return 0;
+   return -EEXIST;
 
if (acpi_disabled)
-   return 0;
+   return -ENODEV;
 
ret = pcc_cpufreq_probe();
if (ret) {
-- 
2.18.1