Re: [PATCH] crypto: be*_add_cpu conversion

2008-02-13 Thread Marcin Slusarz 
On Wed, Feb 13, 2008 at 09:25:47AM +0100, Roel Kluin wrote:
> [EMAIL PROTECTED] wrote:
> > From: Marcin Slusarz <[EMAIL PROTECTED]>
> > 
> > replace all:
> > big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) +
> > expression_in_cpu_byteorder);
> > with:
> > beX_add_cpu(_endian_variable, expression_in_cpu_byteorder);
> > generated with semantic patch
> > 
> > Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]>
> > Cc: Herbert Xu <[EMAIL PROTECTED]>
> > Cc: David S. Miller <[EMAIL PROTECTED]>
> > ---
> >  crypto/lrw.c |2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/crypto/lrw.c b/crypto/lrw.c
> > index 9d52e58..4d93928 100644
> > --- a/crypto/lrw.c
> > +++ b/crypto/lrw.c
> > @@ -92,7 +92,7 @@ struct sinfo {
> >  static inline void inc(be128 *iv)
> >  {
> > if (!(iv->b = cpu_to_be64(be64_to_cpu(iv->b) + 1)))
> 
> maybe you also want instead of the line above:
> 
>   be64_add_cpu(>b, 1);
>   if (!iv->b)
> 
> > -   iv->a = cpu_to_be64(be64_to_cpu(iv->a) + 1);
> > +   be64_add_cpu(>a, 1);
> >  }
> >  
> >  static inline void lrw_round(struct sinfo *s, void *dst, const void *src)
> 
I'm a bit ashamed... but here is updated patch:
---
crypto: replace all adds to big endians variables with be*_add_cpu

replace all:
big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) +
expression_in_cpu_byteorder);
with:
beX_add_cpu(_endian_variable, expression_in_cpu_byteorder);

Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]>
Cc: Herbert Xu <[EMAIL PROTECTED]>
Cc: David S. Miller <[EMAIL PROTECTED]>
Cc: Roel Kluin <[EMAIL PROTECTED]>
---
 crypto/lrw.c |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/crypto/lrw.c b/crypto/lrw.c
index 9d52e58..8ef664e 100644
--- a/crypto/lrw.c
+++ b/crypto/lrw.c
@@ -91,8 +91,9 @@ struct sinfo {
 
 static inline void inc(be128 *iv)
 {
-   if (!(iv->b = cpu_to_be64(be64_to_cpu(iv->b) + 1)))
-   iv->a = cpu_to_be64(be64_to_cpu(iv->a) + 1);
+   be64_add_cpu(>b, 1);
+   if (!iv->b)
+   be64_add_cpu(>a, 1);
 }
 
 static inline void lrw_round(struct sinfo *s, void *dst, const void *src)
-- 
1.5.3.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] crypto: be*_add_cpu conversion

2008-02-13 Thread Roel Kluin 
[EMAIL PROTECTED] wrote:
> From: Marcin Slusarz <[EMAIL PROTECTED]>
> 
> replace all:
> big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) +
>   expression_in_cpu_byteorder);
> with:
>   beX_add_cpu(_endian_variable, expression_in_cpu_byteorder);
> generated with semantic patch
> 
> Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]>
> Cc: Herbert Xu <[EMAIL PROTECTED]>
> Cc: David S. Miller <[EMAIL PROTECTED]>
> ---
>  crypto/lrw.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/crypto/lrw.c b/crypto/lrw.c
> index 9d52e58..4d93928 100644
> --- a/crypto/lrw.c
> +++ b/crypto/lrw.c
> @@ -92,7 +92,7 @@ struct sinfo {
>  static inline void inc(be128 *iv)
>  {
>   if (!(iv->b = cpu_to_be64(be64_to_cpu(iv->b) + 1)))

maybe you also want instead of the line above:

be64_add_cpu(>b, 1);
if (!iv->b)

> - iv->a = cpu_to_be64(be64_to_cpu(iv->a) + 1);
> + be64_add_cpu(>a, 1);
>  }
>  
>  static inline void lrw_round(struct sinfo *s, void *dst, const void *src)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] crypto: be*_add_cpu conversion

2008-02-13 Thread Roel Kluin 
[EMAIL PROTECTED] wrote:
 From: Marcin Slusarz [EMAIL PROTECTED]
 
 replace all:
 big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) +
   expression_in_cpu_byteorder);
 with:
   beX_add_cpu(big_endian_variable, expression_in_cpu_byteorder);
 generated with semantic patch
 
 Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
 Cc: Herbert Xu [EMAIL PROTECTED]
 Cc: David S. Miller [EMAIL PROTECTED]
 ---
  crypto/lrw.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/crypto/lrw.c b/crypto/lrw.c
 index 9d52e58..4d93928 100644
 --- a/crypto/lrw.c
 +++ b/crypto/lrw.c
 @@ -92,7 +92,7 @@ struct sinfo {
  static inline void inc(be128 *iv)
  {
   if (!(iv-b = cpu_to_be64(be64_to_cpu(iv-b) + 1)))

maybe you also want instead of the line above:

be64_add_cpu(iv-b, 1);
if (!iv-b)

 - iv-a = cpu_to_be64(be64_to_cpu(iv-a) + 1);
 + be64_add_cpu(iv-a, 1);
  }
  
  static inline void lrw_round(struct sinfo *s, void *dst, const void *src)

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] crypto: be*_add_cpu conversion

2008-02-13 Thread Marcin Slusarz 
On Wed, Feb 13, 2008 at 09:25:47AM +0100, Roel Kluin wrote:
 [EMAIL PROTECTED] wrote:
  From: Marcin Slusarz [EMAIL PROTECTED]
  
  replace all:
  big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) +
  expression_in_cpu_byteorder);
  with:
  beX_add_cpu(big_endian_variable, expression_in_cpu_byteorder);
  generated with semantic patch
  
  Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
  Cc: Herbert Xu [EMAIL PROTECTED]
  Cc: David S. Miller [EMAIL PROTECTED]
  ---
   crypto/lrw.c |2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)
  
  diff --git a/crypto/lrw.c b/crypto/lrw.c
  index 9d52e58..4d93928 100644
  --- a/crypto/lrw.c
  +++ b/crypto/lrw.c
  @@ -92,7 +92,7 @@ struct sinfo {
   static inline void inc(be128 *iv)
   {
  if (!(iv-b = cpu_to_be64(be64_to_cpu(iv-b) + 1)))
 
 maybe you also want instead of the line above:
 
   be64_add_cpu(iv-b, 1);
   if (!iv-b)
 
  -   iv-a = cpu_to_be64(be64_to_cpu(iv-a) + 1);
  +   be64_add_cpu(iv-a, 1);
   }
   
   static inline void lrw_round(struct sinfo *s, void *dst, const void *src)
 
I'm a bit ashamed... but here is updated patch:
---
crypto: replace all adds to big endians variables with be*_add_cpu

replace all:
big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) +
expression_in_cpu_byteorder);
with:
beX_add_cpu(big_endian_variable, expression_in_cpu_byteorder);

Signed-off-by: Marcin Slusarz [EMAIL PROTECTED]
Cc: Herbert Xu [EMAIL PROTECTED]
Cc: David S. Miller [EMAIL PROTECTED]
Cc: Roel Kluin [EMAIL PROTECTED]
---
 crypto/lrw.c |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/crypto/lrw.c b/crypto/lrw.c
index 9d52e58..8ef664e 100644
--- a/crypto/lrw.c
+++ b/crypto/lrw.c
@@ -91,8 +91,9 @@ struct sinfo {
 
 static inline void inc(be128 *iv)
 {
-   if (!(iv-b = cpu_to_be64(be64_to_cpu(iv-b) + 1)))
-   iv-a = cpu_to_be64(be64_to_cpu(iv-a) + 1);
+   be64_add_cpu(iv-b, 1);
+   if (!iv-b)
+   be64_add_cpu(iv-a, 1);
 }
 
 static inline void lrw_round(struct sinfo *s, void *dst, const void *src)
-- 
1.5.3.7

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] crypto: be*_add_cpu conversion

2008-02-12 Thread marcin . slusarz 
From: Marcin Slusarz <[EMAIL PROTECTED]>

replace all:
big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) +
expression_in_cpu_byteorder);
with:
beX_add_cpu(_endian_variable, expression_in_cpu_byteorder);
generated with semantic patch

Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]>
Cc: Herbert Xu <[EMAIL PROTECTED]>
Cc: David S. Miller <[EMAIL PROTECTED]>
---
 crypto/lrw.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/crypto/lrw.c b/crypto/lrw.c
index 9d52e58..4d93928 100644
--- a/crypto/lrw.c
+++ b/crypto/lrw.c
@@ -92,7 +92,7 @@ struct sinfo {
 static inline void inc(be128 *iv)
 {
if (!(iv->b = cpu_to_be64(be64_to_cpu(iv->b) + 1)))
-   iv->a = cpu_to_be64(be64_to_cpu(iv->a) + 1);
+   be64_add_cpu(>a, 1);
 }
 
 static inline void lrw_round(struct sinfo *s, void *dst, const void *src)
-- 
1.5.3.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/