Re: [PATCH] crypto: nx: use of_property_read_u32()

[Herbert Xu]

On Mon, Nov 23, 2015 at 03:26:54PM +0530, Saurabh Sengar wrote:
> use of_propert_read_u32() for reading int value,
> it can help reducing number of variables used
> 
> Signed-off-by: Saurabh Sengar 

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] crypto: nx: use of_property_read_u32()

[Dan Streetman]

On Mon, Nov 23, 2015 at 4:56 AM, Saurabh Sengar  wrote:
> use of_propert_read_u32() for reading int value,
> it can help reducing number of variables used
>
> Signed-off-by: Saurabh Sengar 

Acked-by: Dan Streetman 

> ---
>  drivers/crypto/nx/nx-842-powernv.c | 11 ---
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/crypto/nx/nx-842-powernv.c 
> b/drivers/crypto/nx/nx-842-powernv.c
> index 9ef51fa..87f7a0f 100644
> --- a/drivers/crypto/nx/nx-842-powernv.c
> +++ b/drivers/crypto/nx/nx-842-powernv.c
> @@ -525,7 +525,6 @@ static int nx842_powernv_decompress(const unsigned char 
> *in, unsigned int inlen,
>  static int __init nx842_powernv_probe(struct device_node *dn)
>  {
> struct nx842_coproc *coproc;
> -   struct property *ct_prop, *ci_prop;
> unsigned int ct, ci;
> int chip_id;
>
> @@ -534,18 +533,16 @@ static int __init nx842_powernv_probe(struct 
> device_node *dn)
> pr_err("ibm,chip-id missing\n");
> return -EINVAL;
> }
> -   ct_prop = of_find_property(dn, "ibm,842-coprocessor-type", NULL);
> -   if (!ct_prop) {
> +
> +   if (of_property_read_u32(dn, "ibm,842-coprocessor-type", &ct)) {
> pr_err("ibm,842-coprocessor-type missing\n");
> return -EINVAL;
> }
> -   ct = be32_to_cpu(*(unsigned int *)ct_prop->value);
> -   ci_prop = of_find_property(dn, "ibm,842-coprocessor-instance", NULL);
> -   if (!ci_prop) {
> +
> +   if (of_property_read_u32(dn, "ibm,842-coprocessor-instance", &ci)) {
> pr_err("ibm,842-coprocessor-instance missing\n");
> return -EINVAL;
> }
> -   ci = be32_to_cpu(*(unsigned int *)ci_prop->value);
>
> coproc = kmalloc(sizeof(*coproc), GFP_KERNEL);
> if (!coproc)
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] crypto: nx: use of_property_read_u32()

[Saurabh Sengar]

use of_propert_read_u32() for reading int value,
it can help reducing number of variables used

Signed-off-by: Saurabh Sengar 
---
 drivers/crypto/nx/nx-842-powernv.c | 11 ---
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/crypto/nx/nx-842-powernv.c 
b/drivers/crypto/nx/nx-842-powernv.c
index 9ef51fa..87f7a0f 100644
--- a/drivers/crypto/nx/nx-842-powernv.c
+++ b/drivers/crypto/nx/nx-842-powernv.c
@@ -525,7 +525,6 @@ static int nx842_powernv_decompress(const unsigned char 
*in, unsigned int inlen,
 static int __init nx842_powernv_probe(struct device_node *dn)
 {
struct nx842_coproc *coproc;
-   struct property *ct_prop, *ci_prop;
unsigned int ct, ci;
int chip_id;
 
@@ -534,18 +533,16 @@ static int __init nx842_powernv_probe(struct device_node 
*dn)
pr_err("ibm,chip-id missing\n");
return -EINVAL;
}
-   ct_prop = of_find_property(dn, "ibm,842-coprocessor-type", NULL);
-   if (!ct_prop) {
+
+   if (of_property_read_u32(dn, "ibm,842-coprocessor-type", &ct)) {
pr_err("ibm,842-coprocessor-type missing\n");
return -EINVAL;
}
-   ct = be32_to_cpu(*(unsigned int *)ct_prop->value);
-   ci_prop = of_find_property(dn, "ibm,842-coprocessor-instance", NULL);
-   if (!ci_prop) {
+
+   if (of_property_read_u32(dn, "ibm,842-coprocessor-instance", &ci)) {
pr_err("ibm,842-coprocessor-instance missing\n");
return -EINVAL;
}
-   ci = be32_to_cpu(*(unsigned int *)ci_prop->value);
 
coproc = kmalloc(sizeof(*coproc), GFP_KERNEL);
if (!coproc)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/