[PATCH] devfreq: fix double call put_device

2016-05-13 Thread Caizhiyong 
From: Cai Zhiyong 
Date: Sat, 14 May 2016 14:13:30 +0800
Subject: [PATCH] devfreq: fix double call put_device

1295  */
1296 void device_unregister(struct device *dev)
1297 {
1298 pr_debug("device: '%s': %s\n", dev_name(dev), __func__);
1299 device_del(dev);
1300 put_device(dev);
1301 }
1302 EXPORT_SYMBOL_GPL(device_unregister);
1303

device_unregister is called put_device, there is no need to call
put_device(&devfreq->dev) again.

Signed-off-by: Cai Zhiyong 
---
 drivers/devfreq/devfreq.c |1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 1d6c803..8de22c0 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -621,7 +621,6 @@ int devfreq_remove_device(struct devfreq *devfreq)
return -EINVAL;
 
device_unregister(&devfreq->dev);
-   put_device(&devfreq->dev);
 
return 0;
 }
-- 
1.7.9.5

[PATCH] devfreq: fix double call put_device

2016-05-13 Thread Caizhiyong 
From: Cai Zhiyong 
Date: Sat, 14 May 2016 14:13:30 +0800
Subject: [PATCH] devfreq: fix double call put_device

1295  */
1296 void device_unregister(struct device *dev)
1297 {
1298 pr_debug("device: '%s': %s\n", dev_name(dev), __func__);
1299 device_del(dev);
1300 put_device(dev);
1301 }
1302 EXPORT_SYMBOL_GPL(device_unregister);
1303

device_unregister is called put_device, there is no need to call
put_device(&devfreq->dev) again.

Signed-off-by: Cai Zhiyong 
---
 drivers/devfreq/devfreq.c |1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 1d6c803..8de22c0 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -621,7 +621,6 @@ int devfreq_remove_device(struct devfreq *devfreq)
return -EINVAL;
 
device_unregister(&devfreq->dev);
-   put_device(&devfreq->dev);
 
return 0;
 }
-- 
1.7.9.5

Re: [PATCH] devfreq: fix double call put_device

2016-06-01 Thread Chanwoo Choi 
Dear Myungjoo,

I reivewed this patch. But the merged patch[1] don't include the my
reviewed-by tag.

[1] 
https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=fixes&id=d90ea94c8f33dcda631885a3dbb2df063ba39efd

Regards,
Chanwoo Choi

On Wed, May 18, 2016 at 8:07 PM, Chanwoo Choi  wrote:
> Hi Cai,
>
> On 2016년 05월 14일 15:28, Caizhiyong wrote:
>> From: Cai Zhiyong 
>> Date: Sat, 14 May 2016 14:13:30 +0800
>> Subject: [PATCH] devfreq: fix double call put_device
>
> The patch description don't need to include the 'Date/Subject'.
> You need to delete them.
>
>>
>> 1295  */
>> 1296 void device_unregister(struct device *dev)
>> 1297 {
>> 1298 pr_debug("device: '%s': %s\n", dev_name(dev), __func__);
>> 1299 device_del(dev);
>> 1300 put_device(dev);
>> 1301 }
>> 1302 EXPORT_SYMBOL_GPL(device_unregister);
>> 1303
>
> Also, you don't need to include the source code of device_unregister()
> because below description explains the why this patch is needed.
>
>>
>> device_unregister is called put_device, there is no need to call
>> put_device(&devfreq->dev) again.
>>
>> Signed-off-by: Cai Zhiyong 
>> ---
>>  drivers/devfreq/devfreq.c |1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>> index 1d6c803..8de22c0 100644
>> --- a/drivers/devfreq/devfreq.c
>> +++ b/drivers/devfreq/devfreq.c
>> @@ -621,7 +621,6 @@ int devfreq_remove_device(struct devfreq *devfreq)
>>   return -EINVAL;
>>
>>   device_unregister(&devfreq->dev);
>> - put_device(&devfreq->dev);
>>
>>   return 0;
>>  }
>>
>
> If you modify the patch description, Looks good to me.
>
> Reviewed-by: Chanwoo Choi 
>
> Thanks,
> Chanwoo Choi

Re: [PATCH] devfreq: fix double call put_device

2016-05-18 Thread Chanwoo Choi 
Hi Cai,

On 2016년 05월 14일 15:28, Caizhiyong wrote:
> From: Cai Zhiyong 
> Date: Sat, 14 May 2016 14:13:30 +0800
> Subject: [PATCH] devfreq: fix double call put_device

The patch description don't need to include the 'Date/Subject'.
You need to delete them.

> 
> 1295  */
> 1296 void device_unregister(struct device *dev)
> 1297 {
> 1298 pr_debug("device: '%s': %s\n", dev_name(dev), __func__);
> 1299 device_del(dev);
> 1300 put_device(dev);
> 1301 }
> 1302 EXPORT_SYMBOL_GPL(device_unregister);
> 1303

Also, you don't need to include the source code of device_unregister()
because below description explains the why this patch is needed.

> 
> device_unregister is called put_device, there is no need to call
> put_device(&devfreq->dev) again.
> 
> Signed-off-by: Cai Zhiyong 
> ---
>  drivers/devfreq/devfreq.c |1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 1d6c803..8de22c0 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -621,7 +621,6 @@ int devfreq_remove_device(struct devfreq *devfreq)
>   return -EINVAL;
>  
>   device_unregister(&devfreq->dev);
> - put_device(&devfreq->dev);
>  
>   return 0;
>  }
> 

If you modify the patch description, Looks good to me.

Reviewed-by: Chanwoo Choi 

Thanks,
Chanwoo Choi