Re: [PATCH] dmaengine: ioat: use setup_timer

2017-04-23 Thread Vinod Koul 
On Sun, Apr 09, 2017 at 09:41:30AM +0800, Geliang Tang wrote:
> Use setup_timer() instead of init_timer() to simplify the code.

Applied, thanks

-- 
~Vinod

Re: [PATCH] dmaengine: ioat: use setup_timer

2017-04-23 Thread Vinod Koul 
On Sun, Apr 09, 2017 at 09:41:30AM +0800, Geliang Tang wrote:
> Use setup_timer() instead of init_timer() to simplify the code.

Applied, thanks

-- 
~Vinod

Re: [PATCH] dmaengine: ioat: use setup_timer

2017-04-09 Thread Dan Williams 
On Sat, Apr 8, 2017 at 6:41 PM, Geliang Tang  wrote:
> Use setup_timer() instead of init_timer() to simplify the code.
>
> Signed-off-by: Geliang Tang 
> ---
>  drivers/dma/ioat/init.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> index cc5259b..6ad4384 100644
> --- a/drivers/dma/ioat/init.c
> +++ b/drivers/dma/ioat/init.c
> @@ -760,9 +760,7 @@ ioat_init_channel(struct ioatdma_device *ioat_dma,
> dma_cookie_init(_chan->dma_chan);
> list_add_tail(_chan->dma_chan.device_node, >channels);
> ioat_dma->idx[idx] = ioat_chan;
> -   init_timer(_chan->timer);
> -   ioat_chan->timer.function = ioat_timer_event;
> -   ioat_chan->timer.data = data;
> +   setup_timer(_chan->timer, ioat_timer_event, data);
> tasklet_init(_chan->cleanup_task, ioat_cleanup_event, data);
>  }
>
> --
> 2.9.3
>

Reviewed-by: Dan Williams

Re: [PATCH] dmaengine: ioat: use setup_timer

2017-04-09 Thread Dan Williams 
On Sat, Apr 8, 2017 at 6:41 PM, Geliang Tang  wrote:
> Use setup_timer() instead of init_timer() to simplify the code.
>
> Signed-off-by: Geliang Tang 
> ---
>  drivers/dma/ioat/init.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> index cc5259b..6ad4384 100644
> --- a/drivers/dma/ioat/init.c
> +++ b/drivers/dma/ioat/init.c
> @@ -760,9 +760,7 @@ ioat_init_channel(struct ioatdma_device *ioat_dma,
> dma_cookie_init(_chan->dma_chan);
> list_add_tail(_chan->dma_chan.device_node, >channels);
> ioat_dma->idx[idx] = ioat_chan;
> -   init_timer(_chan->timer);
> -   ioat_chan->timer.function = ioat_timer_event;
> -   ioat_chan->timer.data = data;
> +   setup_timer(_chan->timer, ioat_timer_event, data);
> tasklet_init(_chan->cleanup_task, ioat_cleanup_event, data);
>  }
>
> --
> 2.9.3
>

Reviewed-by: Dan Williams

[PATCH] dmaengine: ioat: use setup_timer

2017-04-08 Thread Geliang Tang 
Use setup_timer() instead of init_timer() to simplify the code.

Signed-off-by: Geliang Tang 
---
 drivers/dma/ioat/init.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
index cc5259b..6ad4384 100644
--- a/drivers/dma/ioat/init.c
+++ b/drivers/dma/ioat/init.c
@@ -760,9 +760,7 @@ ioat_init_channel(struct ioatdma_device *ioat_dma,
dma_cookie_init(_chan->dma_chan);
list_add_tail(_chan->dma_chan.device_node, >channels);
ioat_dma->idx[idx] = ioat_chan;
-   init_timer(_chan->timer);
-   ioat_chan->timer.function = ioat_timer_event;
-   ioat_chan->timer.data = data;
+   setup_timer(_chan->timer, ioat_timer_event, data);
tasklet_init(_chan->cleanup_task, ioat_cleanup_event, data);
 }
 
-- 
2.9.3

[PATCH] dmaengine: ioat: use setup_timer

2017-04-08 Thread Geliang Tang 
Use setup_timer() instead of init_timer() to simplify the code.

Signed-off-by: Geliang Tang 
---
 drivers/dma/ioat/init.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
index cc5259b..6ad4384 100644
--- a/drivers/dma/ioat/init.c
+++ b/drivers/dma/ioat/init.c
@@ -760,9 +760,7 @@ ioat_init_channel(struct ioatdma_device *ioat_dma,
dma_cookie_init(_chan->dma_chan);
list_add_tail(_chan->dma_chan.device_node, >channels);
ioat_dma->idx[idx] = ioat_chan;
-   init_timer(_chan->timer);
-   ioat_chan->timer.function = ioat_timer_event;
-   ioat_chan->timer.data = data;
+   setup_timer(_chan->timer, ioat_timer_event, data);
tasklet_init(_chan->cleanup_task, ioat_cleanup_event, data);
 }
 
-- 
2.9.3