Re: [PATCH] do_sigaction: remove now unneeded recalc_sigpending()

[Roland McGrath]

> With the recent changes, do_sigaction()->recalc_sigpending_and_wake() can
> never clear TIF_SIGPENDING. Instead, it can set this flag and wake up the
> thread without any reason. Harmless, but unneeded and wastes CPU.
> 
> Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]>

ACK.  (We agreed months ago this was the thing to do.)


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] do_sigaction: remove now unneeded recalc_sigpending()

[Oleg Nesterov]

With the recent changes, do_sigaction()->recalc_sigpending_and_wake() can
never clear TIF_SIGPENDING. Instead, it can set this flag and wake up the
thread without any reason. Harmless, but unneeded and wastes CPU.

Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]>

--- t/kernel/signal.c~  2007-08-03 02:26:30.0 +0400
+++ t/kernel/signal.c   2007-08-03 02:28:50.0 +0400
@@ -2342,7 +2342,6 @@ int do_sigaction(int sig, struct k_sigac
rm_from_queue_full(&mask, &t->signal->shared_pending);
do {
rm_from_queue_full(&mask, &t->pending);
-   recalc_sigpending_and_wake(t);
t = next_thread(t);
} while (t != current);
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/