Re: [PATCH] docs: livepatch: Fix a typo

2021-03-25 Thread Jonathan Corbet
Bhaskar Chowdhury  writes:

> On 10:05 Thu 25 Mar 2021, Miroslav Benes wrote:

>>you sent the same fix a couple of weeks ago and Jon applied it.
>>
> Ah..difficult to rememberthanks for reminding ..it seems I need to keep
> track ...which I don't do at this moment ...so the patch get duplicated ..
>
> So.do you have any better policy to keep track???

1) Look at the emails that maintainers like me send you when patches
are applied.

2) Work against linux-next.

jon


Re: [PATCH] docs: livepatch: Fix a typo

2021-03-25 Thread Miroslav Benes
On Thu, 25 Mar 2021, Bhaskar Chowdhury wrote:

> On 10:05 Thu 25 Mar 2021, Miroslav Benes wrote:
> >Hi,
> >
> >On Thu, 25 Mar 2021, Bhaskar Chowdhury wrote:
> >
> >>
> >> s/varibles/variables/
> >>
> >> Signed-off-by: Bhaskar Chowdhury 
> >> ---
> >>  Documentation/livepatch/shadow-vars.rst | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/livepatch/shadow-vars.rst
> >> b/Documentation/livepatch/shadow-vars.rst
> >> index c05715aeafa4..8464866d18ba 100644
> >> --- a/Documentation/livepatch/shadow-vars.rst
> >> +++ b/Documentation/livepatch/shadow-vars.rst
> >> @@ -165,7 +165,7 @@ In-flight parent objects
> >>
> >>  Sometimes it may not be convenient or possible to allocate shadow
> >>  variables alongside their parent objects.  Or a livepatch fix may
> >> -require shadow varibles to only a subset of parent object instances.  In
> >> +require shadow variables to only a subset of parent object instances.  In
> >>  these cases, the klp_shadow_get_or_alloc() call can be used to attach
> >>  shadow variables to parents already in-flight.
> >
> >you sent the same fix a couple of weeks ago and Jon applied it.
> >
> Ah..difficult to rememberthanks for reminding ..it seems I need to keep
> track ...which I don't do at this moment ...so the patch get duplicated ..

Well, you definitely should.

> So.do you have any better policy to keep track???

I do not send a large amount of typo fixes, so it is quite easy to keep 
track of everything in my case. So please, just find something that suits 
you.

Miroslav


Re: [PATCH] docs: livepatch: Fix a typo

2021-03-25 Thread Bhaskar Chowdhury

On 10:05 Thu 25 Mar 2021, Miroslav Benes wrote:

Hi,

On Thu, 25 Mar 2021, Bhaskar Chowdhury wrote:



s/varibles/variables/

Signed-off-by: Bhaskar Chowdhury 
---
 Documentation/livepatch/shadow-vars.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/livepatch/shadow-vars.rst 
b/Documentation/livepatch/shadow-vars.rst
index c05715aeafa4..8464866d18ba 100644
--- a/Documentation/livepatch/shadow-vars.rst
+++ b/Documentation/livepatch/shadow-vars.rst
@@ -165,7 +165,7 @@ In-flight parent objects

 Sometimes it may not be convenient or possible to allocate shadow
 variables alongside their parent objects.  Or a livepatch fix may
-require shadow varibles to only a subset of parent object instances.  In
+require shadow variables to only a subset of parent object instances.  In
 these cases, the klp_shadow_get_or_alloc() call can be used to attach
 shadow variables to parents already in-flight.


you sent the same fix a couple of weeks ago and Jon applied it.


Ah..difficult to rememberthanks for reminding ..it seems I need to keep
track ...which I don't do at this moment ...so the patch get duplicated ..

So.do you have any better policy to keep track???


Miroslav


signature.asc
Description: PGP signature


Re: [PATCH] docs: livepatch: Fix a typo

2021-03-25 Thread Miroslav Benes
Hi,

On Thu, 25 Mar 2021, Bhaskar Chowdhury wrote:

> 
> s/varibles/variables/
> 
> Signed-off-by: Bhaskar Chowdhury 
> ---
>  Documentation/livepatch/shadow-vars.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/livepatch/shadow-vars.rst 
> b/Documentation/livepatch/shadow-vars.rst
> index c05715aeafa4..8464866d18ba 100644
> --- a/Documentation/livepatch/shadow-vars.rst
> +++ b/Documentation/livepatch/shadow-vars.rst
> @@ -165,7 +165,7 @@ In-flight parent objects
> 
>  Sometimes it may not be convenient or possible to allocate shadow
>  variables alongside their parent objects.  Or a livepatch fix may
> -require shadow varibles to only a subset of parent object instances.  In
> +require shadow variables to only a subset of parent object instances.  In
>  these cases, the klp_shadow_get_or_alloc() call can be used to attach
>  shadow variables to parents already in-flight.

you sent the same fix a couple of weeks ago and Jon applied it.

Miroslav


[PATCH] docs: livepatch: Fix a typo

2021-03-25 Thread Bhaskar Chowdhury


s/varibles/variables/

Signed-off-by: Bhaskar Chowdhury 
---
 Documentation/livepatch/shadow-vars.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/livepatch/shadow-vars.rst 
b/Documentation/livepatch/shadow-vars.rst
index c05715aeafa4..8464866d18ba 100644
--- a/Documentation/livepatch/shadow-vars.rst
+++ b/Documentation/livepatch/shadow-vars.rst
@@ -165,7 +165,7 @@ In-flight parent objects

 Sometimes it may not be convenient or possible to allocate shadow
 variables alongside their parent objects.  Or a livepatch fix may
-require shadow varibles to only a subset of parent object instances.  In
+require shadow variables to only a subset of parent object instances.  In
 these cases, the klp_shadow_get_or_alloc() call can be used to attach
 shadow variables to parents already in-flight.

--
2.30.1



Re: [PATCH] docs: livepatch: Fix a typo in the file shadow-vars.rst

2021-03-05 Thread Bhaskar Chowdhury

On 10:01 Fri 05 Mar 2021, Petr Mladek wrote:

On Fri 2021-03-05 07:47:20, Bhaskar Chowdhury wrote:


s/ varibles/variables/

Signed-off-by: Bhaskar Chowdhury 
---
 Documentation/livepatch/shadow-vars.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/livepatch/shadow-vars.rst 
b/Documentation/livepatch/shadow-vars.rst
index c05715aeafa4..8464866d18ba 100644
--- a/Documentation/livepatch/shadow-vars.rst
+++ b/Documentation/livepatch/shadow-vars.rst
@@ -165,7 +165,7 @@ In-flight parent objects

 Sometimes it may not be convenient or possible to allocate shadow
 variables alongside their parent objects.  Or a livepatch fix may
-require shadow varibles to only a subset of parent object instances.  In
+require shadow variables to only a subset of parent object instances.  In
 these cases, the klp_shadow_get_or_alloc() call can be used to attach
 shadow variables to parents already in-flight.


It might make sense to move the "In" to the next line. It sticks out
even more now.

Eitherway:


Thanks, your wish will get fulfilled in V2 ...will send your way :)

~Bhaskar


Reviewed-by: Petr Mladek 

Best Regards,
Petr


signature.asc
Description: PGP signature


Re: [PATCH] docs: livepatch: Fix a typo in the file shadow-vars.rst

2021-03-05 Thread Petr Mladek
On Fri 2021-03-05 07:47:20, Bhaskar Chowdhury wrote:
> 
> s/ varibles/variables/
> 
> Signed-off-by: Bhaskar Chowdhury 
> ---
>  Documentation/livepatch/shadow-vars.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/livepatch/shadow-vars.rst 
> b/Documentation/livepatch/shadow-vars.rst
> index c05715aeafa4..8464866d18ba 100644
> --- a/Documentation/livepatch/shadow-vars.rst
> +++ b/Documentation/livepatch/shadow-vars.rst
> @@ -165,7 +165,7 @@ In-flight parent objects
> 
>  Sometimes it may not be convenient or possible to allocate shadow
>  variables alongside their parent objects.  Or a livepatch fix may
> -require shadow varibles to only a subset of parent object instances.  In
> +require shadow variables to only a subset of parent object instances.  In
>  these cases, the klp_shadow_get_or_alloc() call can be used to attach
>  shadow variables to parents already in-flight.

It might make sense to move the "In" to the next line. It sticks out
even more now.

Eitherway:

Reviewed-by: Petr Mladek 

Best Regards,
Petr


[PATCH] docs: livepatch: Fix a typo in the file shadow-vars.rst

2021-03-04 Thread Bhaskar Chowdhury


s/ varibles/variables/

Signed-off-by: Bhaskar Chowdhury 
---
 Documentation/livepatch/shadow-vars.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/livepatch/shadow-vars.rst 
b/Documentation/livepatch/shadow-vars.rst
index c05715aeafa4..8464866d18ba 100644
--- a/Documentation/livepatch/shadow-vars.rst
+++ b/Documentation/livepatch/shadow-vars.rst
@@ -165,7 +165,7 @@ In-flight parent objects

 Sometimes it may not be convenient or possible to allocate shadow
 variables alongside their parent objects.  Or a livepatch fix may
-require shadow varibles to only a subset of parent object instances.  In
+require shadow variables to only a subset of parent object instances.  In
 these cases, the klp_shadow_get_or_alloc() call can be used to attach
 shadow variables to parents already in-flight.

--
2.30.1