Re: [PATCH] drivers/memstick/host/tifm_ms.c breakage
--- Al Viro <[EMAIL PROTECTED]> wrote: > readl(sock + ...) that should've been readl(sock->addr + ...) > Thanks. It's a first member in struct, so the problem was just sitting there unnoticed. Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] drivers/memstick/host/tifm_ms.c breakage
On Wed, Feb 13, 2008 at 03:56:59AM +, Al Viro wrote: > readl(sock + ...) that should've been readl(sock->addr + ...) s/readl(/writel(..., / in the changelog message... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] drivers/memstick/host/tifm_ms.c breakage
readl(sock + ...) that should've been readl(sock->addr + ...) Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c index f55b71a..4fb2421 100644 --- a/drivers/memstick/host/tifm_ms.c +++ b/drivers/memstick/host/tifm_ms.c @@ -282,7 +282,7 @@ static int tifm_ms_issue_cmd(struct tifm_ms *host) writel(TIFM_MS_SYS_LATCH | readl(sock->addr + SOCK_MS_SYSTEM), - sock + SOCK_MS_SYSTEM); + sock->addr + SOCK_MS_SYSTEM); writel(0, sock->addr + SOCK_MS_DATA); dev_dbg(>dev, "writing %x\n", 0); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] drivers/memstick/host/tifm_ms.c breakage
readl(sock + ...) that should've been readl(sock-addr + ...) Signed-off-by: Al Viro [EMAIL PROTECTED] --- diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c index f55b71a..4fb2421 100644 --- a/drivers/memstick/host/tifm_ms.c +++ b/drivers/memstick/host/tifm_ms.c @@ -282,7 +282,7 @@ static int tifm_ms_issue_cmd(struct tifm_ms *host) writel(TIFM_MS_SYS_LATCH | readl(sock-addr + SOCK_MS_SYSTEM), - sock + SOCK_MS_SYSTEM); + sock-addr + SOCK_MS_SYSTEM); writel(0, sock-addr + SOCK_MS_DATA); dev_dbg(sock-dev, writing %x\n, 0); -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] drivers/memstick/host/tifm_ms.c breakage
--- Al Viro [EMAIL PROTECTED] wrote: readl(sock + ...) that should've been readl(sock-addr + ...) Thanks. It's a first member in struct, so the problem was just sitting there unnoticed. Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] drivers/memstick/host/tifm_ms.c breakage
On Wed, Feb 13, 2008 at 03:56:59AM +, Al Viro wrote: readl(sock + ...) that should've been readl(sock-addr + ...) s/readl(/writel(..., / in the changelog message... -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
