Re: [PATCH] drivers: dma: Remove extra check
On Fri, Feb 20, 2015 at 05:58:44PM +0530, Tapasweni Pathak wrote: > Remove double check on chan->desc. > > Found by Coccinelle. > Please use the right substem name in patches. Hint git log is your friend Applied, now -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] drivers: dma: Remove extra check
On Fri, Feb 20, 2015 at 05:58:44PM +0530, Tapasweni Pathak wrote: Remove double check on chan-desc. Found by Coccinelle. Please use the right substem name in patches. Hint git log is your friend Applied, now -- ~Vinod -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] drivers: dma: Remove extra check
Remove double check on chan->desc.
Found by Coccinelle.
Signed-off-by: Tapasweni Pathak
Acked-by: Julia Lawall
---
drivers/dma/dma-jz4740.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dma-jz4740.c b/drivers/dma/dma-jz4740.c
index 4527a3e..f6a4c42 100644
--- a/drivers/dma/dma-jz4740.c
+++ b/drivers/dma/dma-jz4740.c
@@ -343,7 +343,7 @@ static void jz4740_dma_chan_irq(struct
jz4740_dmaengine_chan *chan)
{
spin_lock(>vchan.lock);
if (chan->desc) {
- if (chan->desc && chan->desc->cyclic) {
+ if (chan->desc->cyclic) {
vchan_cyclic_callback(>desc->vdesc);
} else {
if (chan->next_sg == chan->desc->num_sgs) {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] drivers: dma: Remove extra check
Remove double check on chan-desc.
Found by Coccinelle.
Signed-off-by: Tapasweni Pathak tapaswenipat...@gmail.com
Acked-by: Julia Lawall julia.law...@lip6.fr
---
drivers/dma/dma-jz4740.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dma-jz4740.c b/drivers/dma/dma-jz4740.c
index 4527a3e..f6a4c42 100644
--- a/drivers/dma/dma-jz4740.c
+++ b/drivers/dma/dma-jz4740.c
@@ -343,7 +343,7 @@ static void jz4740_dma_chan_irq(struct
jz4740_dmaengine_chan *chan)
{
spin_lock(chan-vchan.lock);
if (chan-desc) {
- if (chan-desc chan-desc-cyclic) {
+ if (chan-desc-cyclic) {
vchan_cyclic_callback(chan-desc-vdesc);
} else {
if (chan-next_sg == chan-desc-num_sgs) {
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
