[PATCH] drivers: staging: rtl8723au: Fix '"(foo*)" should be "(foo *)"' errors

[Greg Donald]

Fix checkpatch.pl '"(foo*)" should be "(foo *)"' errors

Signed-off-by: Greg Donald 
---
 drivers/staging/rtl8723au/core/rtw_ap.c| 14 --
 drivers/staging/rtl8723au/core/rtw_cmd.c   |  6 +++---
 drivers/staging/rtl8723au/core/rtw_mlme.c  |  4 ++--
 drivers/staging/rtl8723au/core/rtw_mlme_ext.c  | 12 ++--
 drivers/staging/rtl8723au/core/rtw_wlan_util.c |  2 +-
 5 files changed, 20 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c 
b/drivers/staging/rtl8723au/core/rtw_ap.c
index 888abeb..be85b7e 100644
--- a/drivers/staging/rtl8723au/core/rtw_ap.c
+++ b/drivers/staging/rtl8723au/core/rtw_ap.c
@@ -143,7 +143,7 @@ static void update_BCNTIM(struct rtw_adapter *padapter)
*dst_ie++ = 0;
 
if (tim_ielen == 4) {
-   *dst_ie++ = *(u8*)_bitmap_le;
+   *dst_ie++ = *(u8 *)_bitmap_le;
} else if (tim_ielen == 5) {
memcpy(dst_ie, _bitmap_le, 2);
dst_ie+= 2;
@@ -463,7 +463,8 @@ static void update_bmc_sta(struct rtw_adapter *padapter)
 
psta->ieee8021x_blocked = 0;
 
-   memset((void*)>sta_stats, 0, sizeof(struct 
stainfo_stats));
+   memset((void *)>sta_stats, 0,
+  sizeof(struct stainfo_stats));
 
/* prepare for add_RATid23a */
supportRateNum = 
rtw_get_rateset_len23a((u8*)_network->SupportedRates);
@@ -599,7 +600,7 @@ void update_sta_info23a_apmode23a(struct rtw_adapter 
*padapter, struct sta_info
 
/* todo: init other variables */
 
-   memset((void*)>sta_stats, 0, sizeof(struct stainfo_stats));
+   memset((void *)>sta_stats, 0, sizeof(struct stainfo_stats));
 
spin_lock_bh(>lock);
psta->state |= _FW_LINKED;
@@ -1021,7 +1022,7 @@ int rtw_check_beacon_data23a(struct rtw_adapter *padapter,
pbss_network->Length = get_wlan_bssid_ex_sz(pbss_network);
 
/* issue beacon to start bss network */
-   start_bss_network(padapter, (u8*)pbss_network);
+   start_bss_network(padapter, (u8 *)pbss_network);
 
/* alloc sta_info for ap itself */
psta = rtw_get_stainfo23a(>stapriv, pbss_network->MacAddress);
@@ -1674,7 +1675,8 @@ u8 ap_free_sta23a(struct rtw_adapter *padapter, struct 
sta_info *psta, bool acti
 
/* clear cam entry / key */
/* clear_cam_entry23a(padapter, (psta->mac_id + 3)); */
-   rtw_clearstakey_cmd23a(padapter, (u8*)psta, (u8)(psta->mac_id + 3), 
true);
+   rtw_clearstakey_cmd23a(padapter, (u8 *)psta, (u8)(psta->mac_id + 3),
+  true);
 
spin_lock_bh(>lock);
psta->state &= ~_FW_LINKED;
@@ -1829,7 +1831,7 @@ void rtw_ap_restore_network(struct rtw_adapter *padapter)
 
set_channel_bwmode23a(padapter, pmlmeext->cur_channel, 
pmlmeext->cur_ch_offset, pmlmeext->cur_bwmode);
 
-   start_bss_network(padapter, (u8*)>cur_network.network);
+   start_bss_network(padapter, (u8 *)>cur_network.network);
 
if (padapter->securitypriv.dot11PrivacyAlgrthm ==
WLAN_CIPHER_SUITE_TKIP ||
diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c 
b/drivers/staging/rtl8723au/core/rtw_cmd.c
index 71a0878..9fd9b10 100644
--- a/drivers/staging/rtl8723au/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723au/core/rtw_cmd.c
@@ -677,7 +677,7 @@ int rtw_setstakey_cmd23a(struct rtw_adapter *padapter, u8 
*psta, u8 unicast_key)
struct set_stakey_rsp *psetstakey_rsp = NULL;
struct mlme_priv *pmlmepriv = >mlmepriv;
struct security_priv *psecuritypriv = >securitypriv;
-   struct sta_info *sta = (struct sta_info*)psta;
+   struct sta_info *sta = (struct sta_info *)psta;
int res = _SUCCESS;
 
ph2c = kzalloc(sizeof(struct cmd_obj), GFP_KERNEL);
@@ -1493,7 +1493,7 @@ void rtw_setstaKey_cmdrsp_callback23a(struct rtw_adapter 
*padapter,
struct sta_info *psta;
 
pstapriv = >stapriv;
-   psetstakey_rsp = (struct set_stakey_rsp*) (pcmd->rsp);
+   psetstakey_rsp = (struct set_stakey_rsp *) (pcmd->rsp);
psta = rtw_get_stainfo23a(pstapriv, psetstakey_rsp->addr);
 
if (!psta) {
@@ -1518,7 +1518,7 @@ void rtw_setassocsta_cmdrsp_callback23a(struct 
rtw_adapter *padapter,
struct sta_info *psta;
 
passocsta_parm = (struct set_assocsta_parm *)(pcmd->parmbuf);
-   passocsta_rsp = (struct set_assocsta_rsp*) (pcmd->rsp);
+   passocsta_rsp = (struct set_assocsta_rsp *) (pcmd->rsp);
psta = rtw_get_stainfo23a(pstapriv, passocsta_parm->addr);
 
if (psta == NULL) {
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c 
b/drivers/staging/rtl8723au/core/rtw_mlme.c
index 57f93f5..099ef8c 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme.c
@@ -1256,7 +1256,7 @@ void rtw_stassoc_event_callback23a(struct rtw_adapter 
*adapter, const u8 *pbuf)
 {
struct sta_info *psta;
struct mlme_priv 

[PATCH] drivers: staging: rtl8723au: Fix '(foo*) should be (foo *)' errors

[Greg Donald]

Fix checkpatch.pl '(foo*) should be (foo *)' errors

Signed-off-by: Greg Donald gdon...@gmail.com
---
 drivers/staging/rtl8723au/core/rtw_ap.c| 14 --
 drivers/staging/rtl8723au/core/rtw_cmd.c   |  6 +++---
 drivers/staging/rtl8723au/core/rtw_mlme.c  |  4 ++--
 drivers/staging/rtl8723au/core/rtw_mlme_ext.c  | 12 ++--
 drivers/staging/rtl8723au/core/rtw_wlan_util.c |  2 +-
 5 files changed, 20 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c 
b/drivers/staging/rtl8723au/core/rtw_ap.c
index 888abeb..be85b7e 100644
--- a/drivers/staging/rtl8723au/core/rtw_ap.c
+++ b/drivers/staging/rtl8723au/core/rtw_ap.c
@@ -143,7 +143,7 @@ static void update_BCNTIM(struct rtw_adapter *padapter)
*dst_ie++ = 0;
 
if (tim_ielen == 4) {
-   *dst_ie++ = *(u8*)tim_bitmap_le;
+   *dst_ie++ = *(u8 *)tim_bitmap_le;
} else if (tim_ielen == 5) {
memcpy(dst_ie, tim_bitmap_le, 2);
dst_ie+= 2;
@@ -463,7 +463,8 @@ static void update_bmc_sta(struct rtw_adapter *padapter)
 
psta-ieee8021x_blocked = 0;
 
-   memset((void*)psta-sta_stats, 0, sizeof(struct 
stainfo_stats));
+   memset((void *)psta-sta_stats, 0,
+  sizeof(struct stainfo_stats));
 
/* prepare for add_RATid23a */
supportRateNum = 
rtw_get_rateset_len23a((u8*)pcur_network-SupportedRates);
@@ -599,7 +600,7 @@ void update_sta_info23a_apmode23a(struct rtw_adapter 
*padapter, struct sta_info
 
/* todo: init other variables */
 
-   memset((void*)psta-sta_stats, 0, sizeof(struct stainfo_stats));
+   memset((void *)psta-sta_stats, 0, sizeof(struct stainfo_stats));
 
spin_lock_bh(psta-lock);
psta-state |= _FW_LINKED;
@@ -1021,7 +1022,7 @@ int rtw_check_beacon_data23a(struct rtw_adapter *padapter,
pbss_network-Length = get_wlan_bssid_ex_sz(pbss_network);
 
/* issue beacon to start bss network */
-   start_bss_network(padapter, (u8*)pbss_network);
+   start_bss_network(padapter, (u8 *)pbss_network);
 
/* alloc sta_info for ap itself */
psta = rtw_get_stainfo23a(padapter-stapriv, pbss_network-MacAddress);
@@ -1674,7 +1675,8 @@ u8 ap_free_sta23a(struct rtw_adapter *padapter, struct 
sta_info *psta, bool acti
 
/* clear cam entry / key */
/* clear_cam_entry23a(padapter, (psta-mac_id + 3)); */
-   rtw_clearstakey_cmd23a(padapter, (u8*)psta, (u8)(psta-mac_id + 3), 
true);
+   rtw_clearstakey_cmd23a(padapter, (u8 *)psta, (u8)(psta-mac_id + 3),
+  true);
 
spin_lock_bh(psta-lock);
psta-state = ~_FW_LINKED;
@@ -1829,7 +1831,7 @@ void rtw_ap_restore_network(struct rtw_adapter *padapter)
 
set_channel_bwmode23a(padapter, pmlmeext-cur_channel, 
pmlmeext-cur_ch_offset, pmlmeext-cur_bwmode);
 
-   start_bss_network(padapter, (u8*)mlmepriv-cur_network.network);
+   start_bss_network(padapter, (u8 *)mlmepriv-cur_network.network);
 
if (padapter-securitypriv.dot11PrivacyAlgrthm ==
WLAN_CIPHER_SUITE_TKIP ||
diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c 
b/drivers/staging/rtl8723au/core/rtw_cmd.c
index 71a0878..9fd9b10 100644
--- a/drivers/staging/rtl8723au/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723au/core/rtw_cmd.c
@@ -677,7 +677,7 @@ int rtw_setstakey_cmd23a(struct rtw_adapter *padapter, u8 
*psta, u8 unicast_key)
struct set_stakey_rsp *psetstakey_rsp = NULL;
struct mlme_priv *pmlmepriv = padapter-mlmepriv;
struct security_priv *psecuritypriv = padapter-securitypriv;
-   struct sta_info *sta = (struct sta_info*)psta;
+   struct sta_info *sta = (struct sta_info *)psta;
int res = _SUCCESS;
 
ph2c = kzalloc(sizeof(struct cmd_obj), GFP_KERNEL);
@@ -1493,7 +1493,7 @@ void rtw_setstaKey_cmdrsp_callback23a(struct rtw_adapter 
*padapter,
struct sta_info *psta;
 
pstapriv = padapter-stapriv;
-   psetstakey_rsp = (struct set_stakey_rsp*) (pcmd-rsp);
+   psetstakey_rsp = (struct set_stakey_rsp *) (pcmd-rsp);
psta = rtw_get_stainfo23a(pstapriv, psetstakey_rsp-addr);
 
if (!psta) {
@@ -1518,7 +1518,7 @@ void rtw_setassocsta_cmdrsp_callback23a(struct 
rtw_adapter *padapter,
struct sta_info *psta;
 
passocsta_parm = (struct set_assocsta_parm *)(pcmd-parmbuf);
-   passocsta_rsp = (struct set_assocsta_rsp*) (pcmd-rsp);
+   passocsta_rsp = (struct set_assocsta_rsp *) (pcmd-rsp);
psta = rtw_get_stainfo23a(pstapriv, passocsta_parm-addr);
 
if (psta == NULL) {
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c 
b/drivers/staging/rtl8723au/core/rtw_mlme.c
index 57f93f5..099ef8c 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme.c
@@ -1256,7 +1256,7 @@ void rtw_stassoc_event_callback23a(struct rtw_adapter 
*adapter, 

Re: [PATCH] drivers: staging: rtl8723au: Fix "(foo*)" should be "(foo *)" errors

[Joe Perches]

On Fri, 2014-08-22 at 12:20 -0500, Greg Donald wrote:
> Fix checkpatch.pl "(foo*)" should be "(foo *)" errors

Hello Greg.

> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c 
> b/drivers/staging/rtl8723au/core/rtw_ap.c
[]
> @@ -599,7 +599,7 @@ void update_sta_info23a_apmode23a(struct rtw_adapter 
> *padapter, struct sta_info
>  
>   /* todo: init other variables */
>  
> - memset((void*)>sta_stats, 0, sizeof(struct stainfo_stats));
> + memset((void *)>sta_stats, 0, sizeof(struct stainfo_stats));

It'd be better to remove the (void *) cast instead.

[]
> diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c 
> b/drivers/staging/rtl8723au/core/rtw_cmd.c
[]
> @@ -1493,7 +1493,7 @@ void rtw_setstaKey_cmdrsp_callback23a(struct 
> rtw_adapter *padapter,
>   struct sta_info *psta;
>  
>   pstapriv = >stapriv;
> - psetstakey_rsp = (struct set_stakey_rsp*) (pcmd->rsp);
> + psetstakey_rsp = (struct set_stakey_rsp *) (pcmd->rsp);

Probably better to remove the space and the
unnecessary parentheses:

psetstakey_rsp = (struct set_stakey_rsp *)pcmd->rsp;

> @@ -1518,7 +1518,7 @@ void rtw_setassocsta_cmdrsp_callback23a(struct 
> rtw_adapter *padapter,
>   struct sta_info *psta;
>  
>   passocsta_parm = (struct set_assocsta_parm *)(pcmd->parmbuf);
> - passocsta_rsp = (struct set_assocsta_rsp*) (pcmd->rsp);
> + passocsta_rsp = (struct set_assocsta_rsp *) (pcmd->rsp);

same unnecessary parentheses, maybe
submit separate patches for those.

> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c 
> b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
[]
> @@ -4763,7 +4763,7 @@ void report_survey_event23a(struct rtw_adapter 
> *padapter,
>   pcmd_obj->rsp = NULL;
>   pcmd_obj->rspsz  = 0;
>  
> - pc2h_evt_hdr = (struct C2HEvent_Header*)(pevtcmd);
> + pc2h_evt_hdr = (struct C2HEvent_Header *)(pevtcmd);

more unnecessary parentheses, etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] drivers: staging: rtl8723au: Fix "(foo*)" should be "(foo *)" errors

[Greg Donald]

Fix checkpatch.pl "(foo*)" should be "(foo *)" errors

Signed-off-by: Greg Donald 
---
 drivers/staging/rtl8723au/core/rtw_ap.c|  8 
 drivers/staging/rtl8723au/core/rtw_cmd.c   |  6 +++---
 drivers/staging/rtl8723au/core/rtw_mlme.c  |  4 ++--
 drivers/staging/rtl8723au/core/rtw_mlme_ext.c  | 12 ++--
 drivers/staging/rtl8723au/core/rtw_wlan_util.c |  2 +-
 5 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c 
b/drivers/staging/rtl8723au/core/rtw_ap.c
index 4d2880a..c2e190e 100644
--- a/drivers/staging/rtl8723au/core/rtw_ap.c
+++ b/drivers/staging/rtl8723au/core/rtw_ap.c
@@ -143,7 +143,7 @@ static void update_BCNTIM(struct rtw_adapter *padapter)
*dst_ie++ = 0;
 
if (tim_ielen == 4) {
-   *dst_ie++ = *(u8*)_bitmap_le;
+   *dst_ie++ = *(u8 *)_bitmap_le;
} else if (tim_ielen == 5) {
memcpy(dst_ie, _bitmap_le, 2);
dst_ie+= 2;
@@ -599,7 +599,7 @@ void update_sta_info23a_apmode23a(struct rtw_adapter 
*padapter, struct sta_info
 
/* todo: init other variables */
 
-   memset((void*)>sta_stats, 0, sizeof(struct stainfo_stats));
+   memset((void *)>sta_stats, 0, sizeof(struct stainfo_stats));
 
spin_lock_bh(>lock);
psta->state |= _FW_LINKED;
@@ -1021,7 +1021,7 @@ int rtw_check_beacon_data23a(struct rtw_adapter *padapter,
pbss_network->Length = get_wlan_bssid_ex_sz(pbss_network);
 
/* issue beacon to start bss network */
-   start_bss_network(padapter, (u8*)pbss_network);
+   start_bss_network(padapter, (u8 *)pbss_network);
 
/* alloc sta_info for ap itself */
psta = rtw_get_stainfo23a(>stapriv, pbss_network->MacAddress);
@@ -1829,7 +1829,7 @@ void rtw_ap_restore_network(struct rtw_adapter *padapter)
 
set_channel_bwmode23a(padapter, pmlmeext->cur_channel, 
pmlmeext->cur_ch_offset, pmlmeext->cur_bwmode);
 
-   start_bss_network(padapter, (u8*)>cur_network.network);
+   start_bss_network(padapter, (u8 *)>cur_network.network);
 
if (padapter->securitypriv.dot11PrivacyAlgrthm ==
WLAN_CIPHER_SUITE_TKIP ||
diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c 
b/drivers/staging/rtl8723au/core/rtw_cmd.c
index 7241a5a..c95946c 100644
--- a/drivers/staging/rtl8723au/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723au/core/rtw_cmd.c
@@ -677,7 +677,7 @@ int rtw_setstakey_cmd23a(struct rtw_adapter *padapter, u8 
*psta, u8 unicast_key)
struct set_stakey_rsp *psetstakey_rsp = NULL;
struct mlme_priv *pmlmepriv = >mlmepriv;
struct security_priv *psecuritypriv = >securitypriv;
-   struct sta_info *sta = (struct sta_info*)psta;
+   struct sta_info *sta = (struct sta_info *)psta;
int res = _SUCCESS;
 
ph2c = kzalloc(sizeof(struct cmd_obj), GFP_KERNEL);
@@ -1493,7 +1493,7 @@ void rtw_setstaKey_cmdrsp_callback23a(struct rtw_adapter 
*padapter,
struct sta_info *psta;
 
pstapriv = >stapriv;
-   psetstakey_rsp = (struct set_stakey_rsp*) (pcmd->rsp);
+   psetstakey_rsp = (struct set_stakey_rsp *) (pcmd->rsp);
psta = rtw_get_stainfo23a(pstapriv, psetstakey_rsp->addr);
 
if (!psta) {
@@ -1518,7 +1518,7 @@ void rtw_setassocsta_cmdrsp_callback23a(struct 
rtw_adapter *padapter,
struct sta_info *psta;
 
passocsta_parm = (struct set_assocsta_parm *)(pcmd->parmbuf);
-   passocsta_rsp = (struct set_assocsta_rsp*) (pcmd->rsp);
+   passocsta_rsp = (struct set_assocsta_rsp *) (pcmd->rsp);
psta = rtw_get_stainfo23a(pstapriv, passocsta_parm->addr);
 
if (psta == NULL) {
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c 
b/drivers/staging/rtl8723au/core/rtw_mlme.c
index c475b79..dddc5b2 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme.c
@@ -1256,7 +1256,7 @@ void rtw_stassoc_event_callback23a(struct rtw_adapter 
*adapter, const u8 *pbuf)
 {
struct sta_info *psta;
struct mlme_priv *pmlmepriv = >mlmepriv;
-   struct stassoc_event *pstassoc = (struct stassoc_event*)pbuf;
+   struct stassoc_event *pstassoc = (struct stassoc_event *)pbuf;
struct wlan_network *cur_network = >cur_network;
struct wlan_network *ptarget_wlan;
 
@@ -2187,7 +2187,7 @@ bool rtw_restructure_ht_ie23a(struct rtw_adapter 
*padapter, u8 *in_ie,
 
pframe = rtw_set_ie23a(out_ie + out_len, WLAN_EID_HT_CAPABILITY,
sizeof(struct ieee80211_ht_cap),
-   (unsigned char*)_capie, pout_len);
+   (unsigned char *)_capie, pout_len);
 
phtpriv->ht_option = true;
 
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c 
b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index c5fdcb8..03a1f01 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
+++ 

[PATCH] drivers: staging: rtl8723au: Fix (foo*) should be (foo *) errors

[Greg Donald]

Fix checkpatch.pl (foo*) should be (foo *) errors

Signed-off-by: Greg Donald gdon...@gmail.com
---
 drivers/staging/rtl8723au/core/rtw_ap.c|  8 
 drivers/staging/rtl8723au/core/rtw_cmd.c   |  6 +++---
 drivers/staging/rtl8723au/core/rtw_mlme.c  |  4 ++--
 drivers/staging/rtl8723au/core/rtw_mlme_ext.c  | 12 ++--
 drivers/staging/rtl8723au/core/rtw_wlan_util.c |  2 +-
 5 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c 
b/drivers/staging/rtl8723au/core/rtw_ap.c
index 4d2880a..c2e190e 100644
--- a/drivers/staging/rtl8723au/core/rtw_ap.c
+++ b/drivers/staging/rtl8723au/core/rtw_ap.c
@@ -143,7 +143,7 @@ static void update_BCNTIM(struct rtw_adapter *padapter)
*dst_ie++ = 0;
 
if (tim_ielen == 4) {
-   *dst_ie++ = *(u8*)tim_bitmap_le;
+   *dst_ie++ = *(u8 *)tim_bitmap_le;
} else if (tim_ielen == 5) {
memcpy(dst_ie, tim_bitmap_le, 2);
dst_ie+= 2;
@@ -599,7 +599,7 @@ void update_sta_info23a_apmode23a(struct rtw_adapter 
*padapter, struct sta_info
 
/* todo: init other variables */
 
-   memset((void*)psta-sta_stats, 0, sizeof(struct stainfo_stats));
+   memset((void *)psta-sta_stats, 0, sizeof(struct stainfo_stats));
 
spin_lock_bh(psta-lock);
psta-state |= _FW_LINKED;
@@ -1021,7 +1021,7 @@ int rtw_check_beacon_data23a(struct rtw_adapter *padapter,
pbss_network-Length = get_wlan_bssid_ex_sz(pbss_network);
 
/* issue beacon to start bss network */
-   start_bss_network(padapter, (u8*)pbss_network);
+   start_bss_network(padapter, (u8 *)pbss_network);
 
/* alloc sta_info for ap itself */
psta = rtw_get_stainfo23a(padapter-stapriv, pbss_network-MacAddress);
@@ -1829,7 +1829,7 @@ void rtw_ap_restore_network(struct rtw_adapter *padapter)
 
set_channel_bwmode23a(padapter, pmlmeext-cur_channel, 
pmlmeext-cur_ch_offset, pmlmeext-cur_bwmode);
 
-   start_bss_network(padapter, (u8*)mlmepriv-cur_network.network);
+   start_bss_network(padapter, (u8 *)mlmepriv-cur_network.network);
 
if (padapter-securitypriv.dot11PrivacyAlgrthm ==
WLAN_CIPHER_SUITE_TKIP ||
diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c 
b/drivers/staging/rtl8723au/core/rtw_cmd.c
index 7241a5a..c95946c 100644
--- a/drivers/staging/rtl8723au/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723au/core/rtw_cmd.c
@@ -677,7 +677,7 @@ int rtw_setstakey_cmd23a(struct rtw_adapter *padapter, u8 
*psta, u8 unicast_key)
struct set_stakey_rsp *psetstakey_rsp = NULL;
struct mlme_priv *pmlmepriv = padapter-mlmepriv;
struct security_priv *psecuritypriv = padapter-securitypriv;
-   struct sta_info *sta = (struct sta_info*)psta;
+   struct sta_info *sta = (struct sta_info *)psta;
int res = _SUCCESS;
 
ph2c = kzalloc(sizeof(struct cmd_obj), GFP_KERNEL);
@@ -1493,7 +1493,7 @@ void rtw_setstaKey_cmdrsp_callback23a(struct rtw_adapter 
*padapter,
struct sta_info *psta;
 
pstapriv = padapter-stapriv;
-   psetstakey_rsp = (struct set_stakey_rsp*) (pcmd-rsp);
+   psetstakey_rsp = (struct set_stakey_rsp *) (pcmd-rsp);
psta = rtw_get_stainfo23a(pstapriv, psetstakey_rsp-addr);
 
if (!psta) {
@@ -1518,7 +1518,7 @@ void rtw_setassocsta_cmdrsp_callback23a(struct 
rtw_adapter *padapter,
struct sta_info *psta;
 
passocsta_parm = (struct set_assocsta_parm *)(pcmd-parmbuf);
-   passocsta_rsp = (struct set_assocsta_rsp*) (pcmd-rsp);
+   passocsta_rsp = (struct set_assocsta_rsp *) (pcmd-rsp);
psta = rtw_get_stainfo23a(pstapriv, passocsta_parm-addr);
 
if (psta == NULL) {
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c 
b/drivers/staging/rtl8723au/core/rtw_mlme.c
index c475b79..dddc5b2 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme.c
@@ -1256,7 +1256,7 @@ void rtw_stassoc_event_callback23a(struct rtw_adapter 
*adapter, const u8 *pbuf)
 {
struct sta_info *psta;
struct mlme_priv *pmlmepriv = adapter-mlmepriv;
-   struct stassoc_event *pstassoc = (struct stassoc_event*)pbuf;
+   struct stassoc_event *pstassoc = (struct stassoc_event *)pbuf;
struct wlan_network *cur_network = pmlmepriv-cur_network;
struct wlan_network *ptarget_wlan;
 
@@ -2187,7 +2187,7 @@ bool rtw_restructure_ht_ie23a(struct rtw_adapter 
*padapter, u8 *in_ie,
 
pframe = rtw_set_ie23a(out_ie + out_len, WLAN_EID_HT_CAPABILITY,
sizeof(struct ieee80211_ht_cap),
-   (unsigned char*)ht_capie, pout_len);
+   (unsigned char *)ht_capie, pout_len);
 
phtpriv-ht_option = true;
 
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c 
b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index c5fdcb8..03a1f01 

Re: [PATCH] drivers: staging: rtl8723au: Fix (foo*) should be (foo *) errors

[Joe Perches]

On Fri, 2014-08-22 at 12:20 -0500, Greg Donald wrote:
 Fix checkpatch.pl (foo*) should be (foo *) errors

Hello Greg.

 diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c 
 b/drivers/staging/rtl8723au/core/rtw_ap.c
[]
 @@ -599,7 +599,7 @@ void update_sta_info23a_apmode23a(struct rtw_adapter 
 *padapter, struct sta_info
  
   /* todo: init other variables */
  
 - memset((void*)psta-sta_stats, 0, sizeof(struct stainfo_stats));
 + memset((void *)psta-sta_stats, 0, sizeof(struct stainfo_stats));

It'd be better to remove the (void *) cast instead.

[]
 diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c 
 b/drivers/staging/rtl8723au/core/rtw_cmd.c
[]
 @@ -1493,7 +1493,7 @@ void rtw_setstaKey_cmdrsp_callback23a(struct 
 rtw_adapter *padapter,
   struct sta_info *psta;
  
   pstapriv = padapter-stapriv;
 - psetstakey_rsp = (struct set_stakey_rsp*) (pcmd-rsp);
 + psetstakey_rsp = (struct set_stakey_rsp *) (pcmd-rsp);

Probably better to remove the space and the
unnecessary parentheses:

psetstakey_rsp = (struct set_stakey_rsp *)pcmd-rsp;

 @@ -1518,7 +1518,7 @@ void rtw_setassocsta_cmdrsp_callback23a(struct 
 rtw_adapter *padapter,
   struct sta_info *psta;
  
   passocsta_parm = (struct set_assocsta_parm *)(pcmd-parmbuf);
 - passocsta_rsp = (struct set_assocsta_rsp*) (pcmd-rsp);
 + passocsta_rsp = (struct set_assocsta_rsp *) (pcmd-rsp);

same unnecessary parentheses, maybe
submit separate patches for those.

 diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c 
 b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
[]
 @@ -4763,7 +4763,7 @@ void report_survey_event23a(struct rtw_adapter 
 *padapter,
   pcmd_obj-rsp = NULL;
   pcmd_obj-rspsz  = 0;
  
 - pc2h_evt_hdr = (struct C2HEvent_Header*)(pevtcmd);
 + pc2h_evt_hdr = (struct C2HEvent_Header *)(pevtcmd);

more unnecessary parentheses, etc...


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/