Re: [PATCH] drm: armada: make of_device_ids const.

[Daniel Vetter]

On Tue, Jun 20, 2017 at 10:44:33AM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by  work with const
> of_device_ids. So mark the non-const structs as const.
> 
> File size before:
>text  data bss dec hex filename
>8836   744   09580256c 
> drivers/gpu/drm/armada/armada_crtc.o
> 
> File size after constify armada_lcd_of_match:
>text  data bss dec hex filename
>9220   328   09548254c 
> drivers/gpu/drm/armada/armada_crtc.o
> 
> Signed-off-by: Arvind Yadav 

Applied to drm-misc-next, thanks.
-Daniel

> ---
>  drivers/gpu/drm/armada/armada_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/armada/armada_crtc.c 
> b/drivers/gpu/drm/armada/armada_crtc.c
> index 4fe19fd..94b76bd 100644
> --- a/drivers/gpu/drm/armada/armada_crtc.c
> +++ b/drivers/gpu/drm/armada/armada_crtc.c
> @@ -1364,7 +1364,7 @@ static int armada_lcd_remove(struct platform_device 
> *pdev)
>   return 0;
>  }
>  
> -static struct of_device_id armada_lcd_of_match[] = {
> +static const struct of_device_id armada_lcd_of_match[] = {
>   {
>   .compatible = "marvell,dove-lcd",
>   .data   = _ops,
> -- 
> 1.9.1
> 
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [PATCH] drm: armada: make of_device_ids const.

[Daniel Vetter]

On Tue, Jun 20, 2017 at 10:44:33AM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by  work with const
> of_device_ids. So mark the non-const structs as const.
> 
> File size before:
>text  data bss dec hex filename
>8836   744   09580256c 
> drivers/gpu/drm/armada/armada_crtc.o
> 
> File size after constify armada_lcd_of_match:
>text  data bss dec hex filename
>9220   328   09548254c 
> drivers/gpu/drm/armada/armada_crtc.o
> 
> Signed-off-by: Arvind Yadav 

Applied to drm-misc-next, thanks.
-Daniel

> ---
>  drivers/gpu/drm/armada/armada_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/armada/armada_crtc.c 
> b/drivers/gpu/drm/armada/armada_crtc.c
> index 4fe19fd..94b76bd 100644
> --- a/drivers/gpu/drm/armada/armada_crtc.c
> +++ b/drivers/gpu/drm/armada/armada_crtc.c
> @@ -1364,7 +1364,7 @@ static int armada_lcd_remove(struct platform_device 
> *pdev)
>   return 0;
>  }
>  
> -static struct of_device_id armada_lcd_of_match[] = {
> +static const struct of_device_id armada_lcd_of_match[] = {
>   {
>   .compatible = "marvell,dove-lcd",
>   .data   = _ops,
> -- 
> 1.9.1
> 
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

[PATCH] drm: armada: make of_device_ids const.

[Arvind Yadav]

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by  work with const
of_device_ids. So mark the non-const structs as const.

File size before:
   textdata bss dec hex filename
   8836 744   09580256c drivers/gpu/drm/armada/armada_crtc.o

File size after constify armada_lcd_of_match:
   textdata bss dec hex filename
   9220 328   09548254c drivers/gpu/drm/armada/armada_crtc.o

Signed-off-by: Arvind Yadav 
---
 drivers/gpu/drm/armada/armada_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/armada/armada_crtc.c 
b/drivers/gpu/drm/armada/armada_crtc.c
index 4fe19fd..94b76bd 100644
--- a/drivers/gpu/drm/armada/armada_crtc.c
+++ b/drivers/gpu/drm/armada/armada_crtc.c
@@ -1364,7 +1364,7 @@ static int armada_lcd_remove(struct platform_device *pdev)
return 0;
 }
 
-static struct of_device_id armada_lcd_of_match[] = {
+static const struct of_device_id armada_lcd_of_match[] = {
{
.compatible = "marvell,dove-lcd",
.data   = _ops,
-- 
1.9.1

[PATCH] drm: armada: make of_device_ids const.

[Arvind Yadav]

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by  work with const
of_device_ids. So mark the non-const structs as const.

File size before:
   textdata bss dec hex filename
   8836 744   09580256c drivers/gpu/drm/armada/armada_crtc.o

File size after constify armada_lcd_of_match:
   textdata bss dec hex filename
   9220 328   09548254c drivers/gpu/drm/armada/armada_crtc.o

Signed-off-by: Arvind Yadav 
---
 drivers/gpu/drm/armada/armada_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/armada/armada_crtc.c 
b/drivers/gpu/drm/armada/armada_crtc.c
index 4fe19fd..94b76bd 100644
--- a/drivers/gpu/drm/armada/armada_crtc.c
+++ b/drivers/gpu/drm/armada/armada_crtc.c
@@ -1364,7 +1364,7 @@ static int armada_lcd_remove(struct platform_device *pdev)
return 0;
 }
 
-static struct of_device_id armada_lcd_of_match[] = {
+static const struct of_device_id armada_lcd_of_match[] = {
{
.compatible = "marvell,dove-lcd",
.data   = _ops,
-- 
1.9.1