Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings
On Tue, Mar 16, 2021 at 01:49:18PM -0600, Rob Herring wrote: > Adding checks for undocumented compatible strings reveals a bunch of > warnings in the DT binding examples. Fix the cases which are typos, just > a mismatch between the schema and the example, or aren't documented at all. > In a couple of cases, fixing the compatible revealed some schema errors > which are fixed. > > There's a bunch of others remaining after this which have bindings, but > those aren't converted to schema yet. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Vinod Koul > Cc: Alexandre Belloni > Cc: Jonathan Cameron > Cc: Pavel Machek > Cc: Kishon Vijay Abraham I > Cc: Sebastian Reichel > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: dmaeng...@vger.kernel.org > Cc: linux-...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Cc: linux-l...@vger.kernel.org > Cc: linux...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../clock/allwinner,sun4i-a10-pll1-clk.yaml | 2 +- > .../bindings/clock/milbeaut-clock.yaml| 12 + > .../bindings/display/brcm,bcm2835-dsi0.yaml | 6 - > .../bindings/display/panel/panel-dpi.yaml | 2 +- > .../devicetree/bindings/dma/qcom,gpi.yaml | 2 +- > .../devicetree/bindings/i3c/i3c.yaml | 7 ++--- > .../iio/adc/brcm,iproc-static-adc.yaml| 5 > .../iio/gyroscope/nxp,fxas21002c.yaml | 2 +- > .../bindings/iio/light/upisemi,us5182.yaml| 4 +-- > .../interrupt-controller/loongson,htpic.yaml | 2 +- > .../devicetree/bindings/leds/leds-lgm.yaml| 26 --- > .../bindings/phy/ti,phy-j721e-wiz.yaml| 2 +- > .../bindings/power/supply/cw2015_battery.yaml | 2 +- > .../bindings/power/supply/power-supply.yaml | 22 > .../devicetree/bindings/serial/serial.yaml| 2 +- > .../bindings/spi/amlogic,meson-gx-spicc.yaml | 4 +-- > .../bindings/spi/spi-controller.yaml | 21 --- > .../devicetree/bindings/spi/spi-mux.yaml | 8 ++ > .../devicetree/bindings/spi/st,stm32-spi.yaml | 6 - > 19 files changed, 58 insertions(+), 79 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature
Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings
On Tue, 16 Mar 2021 13:49:18 -0600 Rob Herring wrote: > Adding checks for undocumented compatible strings reveals a bunch of > warnings in the DT binding examples. Fix the cases which are typos, just > a mismatch between the schema and the example, or aren't documented at all. > In a couple of cases, fixing the compatible revealed some schema errors > which are fixed. > > There's a bunch of others remaining after this which have bindings, but > those aren't converted to schema yet. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Vinod Koul > Cc: Alexandre Belloni > Cc: Jonathan Cameron > Cc: Pavel Machek > Cc: Kishon Vijay Abraham I > Cc: Sebastian Reichel > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: dmaeng...@vger.kernel.org > Cc: linux-...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Cc: linux-l...@vger.kernel.org > Cc: linux...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring For iio one Acked-by: Jonathan Cameron > --- > .../clock/allwinner,sun4i-a10-pll1-clk.yaml | 2 +- > .../bindings/clock/milbeaut-clock.yaml| 12 + > .../bindings/display/brcm,bcm2835-dsi0.yaml | 6 - > .../bindings/display/panel/panel-dpi.yaml | 2 +- > .../devicetree/bindings/dma/qcom,gpi.yaml | 2 +- > .../devicetree/bindings/i3c/i3c.yaml | 7 ++--- > .../iio/adc/brcm,iproc-static-adc.yaml| 5 > .../iio/gyroscope/nxp,fxas21002c.yaml | 2 +- > .../bindings/iio/light/upisemi,us5182.yaml| 4 +-- > .../interrupt-controller/loongson,htpic.yaml | 2 +- > .../devicetree/bindings/leds/leds-lgm.yaml| 26 --- > .../bindings/phy/ti,phy-j721e-wiz.yaml| 2 +- > .../bindings/power/supply/cw2015_battery.yaml | 2 +- > .../bindings/power/supply/power-supply.yaml | 22 > .../devicetree/bindings/serial/serial.yaml| 2 +- > .../bindings/spi/amlogic,meson-gx-spicc.yaml | 4 +-- > .../bindings/spi/spi-controller.yaml | 21 --- > .../devicetree/bindings/spi/spi-mux.yaml | 8 ++ > .../devicetree/bindings/spi/st,stm32-spi.yaml | 6 - > 19 files changed, 58 insertions(+), 79 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > b/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > index e9c4cf834aa7..e5d9d45dab8a 100644 > --- > a/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > +++ > b/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > @@ -44,7 +44,7 @@ examples: >- | > clk@1c2 { > #clock-cells = <0>; > -compatible = "allwinner,sun4i-a10-pll1"; > +compatible = "allwinner,sun4i-a10-pll1-clk"; > reg = <0x01c2 0x4>; > clocks = <&osc24M>; > clock-output-names = "osc24M"; > diff --git a/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > b/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > index 0e8b07710451..6d39344d2b70 100644 > --- a/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > @@ -18,10 +18,12 @@ description: | > > properties: >compatible: > -oneOf: > - - items: > - - enum: > - - socionext,milbeaut-m10v-ccu > +enum: > + - socionext,milbeaut-m10v-ccu > + > + reg: > +maxItems: 1 > + >clocks: > maxItems: 1 > description: external clock > @@ -41,7 +43,7 @@ examples: ># Clock controller node: >- | > m10v-clk-ctrl@1d021000 { > -compatible = "socionext,milbeaut-m10v-clk-ccu"; > +compatible = "socionext,milbeaut-m10v-ccu"; > reg = <0x1d021000 0x4000>; > #clock-cells = <1>; > clocks = <&clki40mhz>; > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > b/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > index 55c60919991f..32608578a352 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > @@ -77,12 +77,6 @@ examples: > > clock-output-names = "dsi1_byte", "dsi1_ddr2", "dsi1_ddr"; > > -pitouchscreen: panel@0 { > -compatible = "raspberrypi,touchscreen"; > -reg = <0>; > - > -/* ... */ > -}; > }; > > ... > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > index 0cd74c8dab42..dae0676b5c6e 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > @@ -40,7 +40,7 @@ additionalProperties: false > examples: >- | >
Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings
On Tue, Mar 16, 2021 at 01:49:18PM -0600, Rob Herring wrote: > Adding checks for undocumented compatible strings reveals a bunch of > warnings in the DT binding examples. Fix the cases which are typos, just > a mismatch between the schema and the example, or aren't documented at all. > In a couple of cases, fixing the compatible revealed some schema errors > which are fixed. > > There's a bunch of others remaining after this which have bindings, but > those aren't converted to schema yet. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Vinod Koul > Cc: Alexandre Belloni > Cc: Jonathan Cameron > Cc: Pavel Machek > Cc: Kishon Vijay Abraham I > Cc: Sebastian Reichel > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: dmaeng...@vger.kernel.org > Cc: linux-...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Cc: linux-l...@vger.kernel.org > Cc: linux...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../clock/allwinner,sun4i-a10-pll1-clk.yaml | 2 +- > .../bindings/clock/milbeaut-clock.yaml| 12 + > .../bindings/display/brcm,bcm2835-dsi0.yaml | 6 - > .../bindings/display/panel/panel-dpi.yaml | 2 +- > .../devicetree/bindings/dma/qcom,gpi.yaml | 2 +- > .../devicetree/bindings/i3c/i3c.yaml | 7 ++--- > .../iio/adc/brcm,iproc-static-adc.yaml| 5 > .../iio/gyroscope/nxp,fxas21002c.yaml | 2 +- > .../bindings/iio/light/upisemi,us5182.yaml| 4 +-- > .../interrupt-controller/loongson,htpic.yaml | 2 +- > .../devicetree/bindings/leds/leds-lgm.yaml| 26 --- > .../bindings/phy/ti,phy-j721e-wiz.yaml| 2 +- > .../bindings/power/supply/cw2015_battery.yaml | 2 +- > .../bindings/power/supply/power-supply.yaml | 22 > .../devicetree/bindings/serial/serial.yaml| 2 +- > .../bindings/spi/amlogic,meson-gx-spicc.yaml | 4 +-- > .../bindings/spi/spi-controller.yaml | 21 --- > .../devicetree/bindings/spi/spi-mux.yaml | 8 ++ > .../devicetree/bindings/spi/st,stm32-spi.yaml | 6 - Acked-by: Alain Volmat > 19 files changed, 58 insertions(+), 79 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > b/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > index e9c4cf834aa7..e5d9d45dab8a 100644 > --- > a/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > +++ > b/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > @@ -44,7 +44,7 @@ examples: >- | > clk@1c2 { > #clock-cells = <0>; > -compatible = "allwinner,sun4i-a10-pll1"; > +compatible = "allwinner,sun4i-a10-pll1-clk"; > reg = <0x01c2 0x4>; > clocks = <&osc24M>; > clock-output-names = "osc24M"; > diff --git a/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > b/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > index 0e8b07710451..6d39344d2b70 100644 > --- a/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > @@ -18,10 +18,12 @@ description: | > > properties: >compatible: > -oneOf: > - - items: > - - enum: > - - socionext,milbeaut-m10v-ccu > +enum: > + - socionext,milbeaut-m10v-ccu > + > + reg: > +maxItems: 1 > + >clocks: > maxItems: 1 > description: external clock > @@ -41,7 +43,7 @@ examples: ># Clock controller node: >- | > m10v-clk-ctrl@1d021000 { > -compatible = "socionext,milbeaut-m10v-clk-ccu"; > +compatible = "socionext,milbeaut-m10v-ccu"; > reg = <0x1d021000 0x4000>; > #clock-cells = <1>; > clocks = <&clki40mhz>; > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > b/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > index 55c60919991f..32608578a352 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > @@ -77,12 +77,6 @@ examples: > > clock-output-names = "dsi1_byte", "dsi1_ddr2", "dsi1_ddr"; > > -pitouchscreen: panel@0 { > -compatible = "raspberrypi,touchscreen"; > -reg = <0>; > - > -/* ... */ > -}; > }; > > ... > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > index 0cd74c8dab42..dae0676b5c6e 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > @@ -40,7 +40,7 @@ additionalProperties: false > examples: >- | > panel {
Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings
On 16/03/2021 13:49:18-0600, Rob Herring wrote: > Adding checks for undocumented compatible strings reveals a bunch of > warnings in the DT binding examples. Fix the cases which are typos, just > a mismatch between the schema and the example, or aren't documented at all. > In a couple of cases, fixing the compatible revealed some schema errors > which are fixed. > > There's a bunch of others remaining after this which have bindings, but > those aren't converted to schema yet. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Vinod Koul > Cc: Alexandre Belloni > Cc: Jonathan Cameron > Cc: Pavel Machek > Cc: Kishon Vijay Abraham I > Cc: Sebastian Reichel > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: dmaeng...@vger.kernel.org > Cc: linux-...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Cc: linux-l...@vger.kernel.org > Cc: linux...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Alexandre Belloni -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings
On 16-03-21, 13:49, Rob Herring wrote: > --- > .../clock/allwinner,sun4i-a10-pll1-clk.yaml | 2 +- > .../bindings/clock/milbeaut-clock.yaml| 12 + > .../bindings/display/brcm,bcm2835-dsi0.yaml | 6 - > .../bindings/display/panel/panel-dpi.yaml | 2 +- > .../devicetree/bindings/dma/qcom,gpi.yaml | 2 +- ... > .../bindings/phy/ti,phy-j721e-wiz.yaml| 2 +- Acked-By: Vinod Koul -- ~Vinod
Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings
Hi, On Tue, Mar 16, 2021 at 01:49:18PM -0600, Rob Herring wrote: > Adding checks for undocumented compatible strings reveals a bunch of > warnings in the DT binding examples. Fix the cases which are typos, just > a mismatch between the schema and the example, or aren't documented at all. > In a couple of cases, fixing the compatible revealed some schema errors > which are fixed. > > There's a bunch of others remaining after this which have bindings, but > those aren't converted to schema yet. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Vinod Koul > Cc: Alexandre Belloni > Cc: Jonathan Cameron > Cc: Pavel Machek > Cc: Kishon Vijay Abraham I > Cc: Sebastian Reichel > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: dmaeng...@vger.kernel.org > Cc: linux-...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Cc: linux-l...@vger.kernel.org > Cc: linux...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../clock/allwinner,sun4i-a10-pll1-clk.yaml | 2 +- > .../bindings/clock/milbeaut-clock.yaml| 12 + > .../bindings/display/brcm,bcm2835-dsi0.yaml | 6 - > .../bindings/display/panel/panel-dpi.yaml | 2 +- > .../devicetree/bindings/dma/qcom,gpi.yaml | 2 +- > .../devicetree/bindings/i3c/i3c.yaml | 7 ++--- > .../iio/adc/brcm,iproc-static-adc.yaml| 5 > .../iio/gyroscope/nxp,fxas21002c.yaml | 2 +- > .../bindings/iio/light/upisemi,us5182.yaml| 4 +-- > .../interrupt-controller/loongson,htpic.yaml | 2 +- > .../devicetree/bindings/leds/leds-lgm.yaml| 26 --- > .../bindings/phy/ti,phy-j721e-wiz.yaml| 2 +- > .../bindings/power/supply/cw2015_battery.yaml | 2 +- > .../bindings/power/supply/power-supply.yaml | 22 > .../devicetree/bindings/serial/serial.yaml| 2 +- > .../bindings/spi/amlogic,meson-gx-spicc.yaml | 4 +-- > .../bindings/spi/spi-controller.yaml | 21 --- > .../devicetree/bindings/spi/spi-mux.yaml | 8 ++ > .../devicetree/bindings/spi/st,stm32-spi.yaml | 6 - > 19 files changed, 58 insertions(+), 79 deletions(-) Acked-by: Maxime Ripard Thanks! Maxime signature.asc Description: PGP signature
Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings
Hi, On Tue, Mar 16, 2021 at 01:49:18PM -0600, Rob Herring wrote: > Adding checks for undocumented compatible strings reveals a bunch of > warnings in the DT binding examples. Fix the cases which are typos, just > a mismatch between the schema and the example, or aren't documented at all. > In a couple of cases, fixing the compatible revealed some schema errors > which are fixed. > > There's a bunch of others remaining after this which have bindings, but > those aren't converted to schema yet. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Vinod Koul > Cc: Alexandre Belloni > Cc: Jonathan Cameron > Cc: Pavel Machek > Cc: Kishon Vijay Abraham I > Cc: Sebastian Reichel > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: dmaeng...@vger.kernel.org > Cc: linux-...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Cc: linux-l...@vger.kernel.org > Cc: linux...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring > --- Acked-by: Sebastian Reichel -- Sebastian > .../clock/allwinner,sun4i-a10-pll1-clk.yaml | 2 +- > .../bindings/clock/milbeaut-clock.yaml| 12 + > .../bindings/display/brcm,bcm2835-dsi0.yaml | 6 - > .../bindings/display/panel/panel-dpi.yaml | 2 +- > .../devicetree/bindings/dma/qcom,gpi.yaml | 2 +- > .../devicetree/bindings/i3c/i3c.yaml | 7 ++--- > .../iio/adc/brcm,iproc-static-adc.yaml| 5 > .../iio/gyroscope/nxp,fxas21002c.yaml | 2 +- > .../bindings/iio/light/upisemi,us5182.yaml| 4 +-- > .../interrupt-controller/loongson,htpic.yaml | 2 +- > .../devicetree/bindings/leds/leds-lgm.yaml| 26 --- > .../bindings/phy/ti,phy-j721e-wiz.yaml| 2 +- > .../bindings/power/supply/cw2015_battery.yaml | 2 +- > .../bindings/power/supply/power-supply.yaml | 22 > .../devicetree/bindings/serial/serial.yaml| 2 +- > .../bindings/spi/amlogic,meson-gx-spicc.yaml | 4 +-- > .../bindings/spi/spi-controller.yaml | 21 --- > .../devicetree/bindings/spi/spi-mux.yaml | 8 ++ > .../devicetree/bindings/spi/st,stm32-spi.yaml | 6 - > 19 files changed, 58 insertions(+), 79 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > b/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > index e9c4cf834aa7..e5d9d45dab8a 100644 > --- > a/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > +++ > b/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > @@ -44,7 +44,7 @@ examples: >- | > clk@1c2 { > #clock-cells = <0>; > -compatible = "allwinner,sun4i-a10-pll1"; > +compatible = "allwinner,sun4i-a10-pll1-clk"; > reg = <0x01c2 0x4>; > clocks = <&osc24M>; > clock-output-names = "osc24M"; > diff --git a/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > b/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > index 0e8b07710451..6d39344d2b70 100644 > --- a/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > @@ -18,10 +18,12 @@ description: | > > properties: >compatible: > -oneOf: > - - items: > - - enum: > - - socionext,milbeaut-m10v-ccu > +enum: > + - socionext,milbeaut-m10v-ccu > + > + reg: > +maxItems: 1 > + >clocks: > maxItems: 1 > description: external clock > @@ -41,7 +43,7 @@ examples: ># Clock controller node: >- | > m10v-clk-ctrl@1d021000 { > -compatible = "socionext,milbeaut-m10v-clk-ccu"; > +compatible = "socionext,milbeaut-m10v-ccu"; > reg = <0x1d021000 0x4000>; > #clock-cells = <1>; > clocks = <&clki40mhz>; > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > b/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > index 55c60919991f..32608578a352 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > @@ -77,12 +77,6 @@ examples: > > clock-output-names = "dsi1_byte", "dsi1_ddr2", "dsi1_ddr"; > > -pitouchscreen: panel@0 { > -compatible = "raspberrypi,touchscreen"; > -reg = <0>; > - > -/* ... */ > -}; > }; > > ... > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > index 0cd74c8dab42..dae0676b5c6e 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > @@ -40,7 +40,7 @@ additionalProperties: false > examples:
Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings
On 17/03/21 1:19 am, Rob Herring wrote: > Adding checks for undocumented compatible strings reveals a bunch of > warnings in the DT binding examples. Fix the cases which are typos, just > a mismatch between the schema and the example, or aren't documented at all. > In a couple of cases, fixing the compatible revealed some schema errors > which are fixed. > > There's a bunch of others remaining after this which have bindings, but > those aren't converted to schema yet. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Vinod Koul > Cc: Alexandre Belloni > Cc: Jonathan Cameron > Cc: Pavel Machek > Cc: Kishon Vijay Abraham I > Cc: Sebastian Reichel > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: dmaeng...@vger.kernel.org > Cc: linux-...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Cc: linux-l...@vger.kernel.org > Cc: linux...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Kishon Vijay Abraham I > --- > .../clock/allwinner,sun4i-a10-pll1-clk.yaml | 2 +- > .../bindings/clock/milbeaut-clock.yaml| 12 + > .../bindings/display/brcm,bcm2835-dsi0.yaml | 6 - > .../bindings/display/panel/panel-dpi.yaml | 2 +- > .../devicetree/bindings/dma/qcom,gpi.yaml | 2 +- > .../devicetree/bindings/i3c/i3c.yaml | 7 ++--- > .../iio/adc/brcm,iproc-static-adc.yaml| 5 > .../iio/gyroscope/nxp,fxas21002c.yaml | 2 +- > .../bindings/iio/light/upisemi,us5182.yaml| 4 +-- > .../interrupt-controller/loongson,htpic.yaml | 2 +- > .../devicetree/bindings/leds/leds-lgm.yaml| 26 --- > .../bindings/phy/ti,phy-j721e-wiz.yaml| 2 +- > .../bindings/power/supply/cw2015_battery.yaml | 2 +- > .../bindings/power/supply/power-supply.yaml | 22 > .../devicetree/bindings/serial/serial.yaml| 2 +- > .../bindings/spi/amlogic,meson-gx-spicc.yaml | 4 +-- > .../bindings/spi/spi-controller.yaml | 21 --- > .../devicetree/bindings/spi/spi-mux.yaml | 8 ++ > .../devicetree/bindings/spi/st,stm32-spi.yaml | 6 - > 19 files changed, 58 insertions(+), 79 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > b/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > index e9c4cf834aa7..e5d9d45dab8a 100644 > --- > a/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > +++ > b/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml > @@ -44,7 +44,7 @@ examples: >- | > clk@1c2 { > #clock-cells = <0>; > -compatible = "allwinner,sun4i-a10-pll1"; > +compatible = "allwinner,sun4i-a10-pll1-clk"; > reg = <0x01c2 0x4>; > clocks = <&osc24M>; > clock-output-names = "osc24M"; > diff --git a/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > b/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > index 0e8b07710451..6d39344d2b70 100644 > --- a/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml > @@ -18,10 +18,12 @@ description: | > > properties: >compatible: > -oneOf: > - - items: > - - enum: > - - socionext,milbeaut-m10v-ccu > +enum: > + - socionext,milbeaut-m10v-ccu > + > + reg: > +maxItems: 1 > + >clocks: > maxItems: 1 > description: external clock > @@ -41,7 +43,7 @@ examples: ># Clock controller node: >- | > m10v-clk-ctrl@1d021000 { > -compatible = "socionext,milbeaut-m10v-clk-ccu"; > +compatible = "socionext,milbeaut-m10v-ccu"; > reg = <0x1d021000 0x4000>; > #clock-cells = <1>; > clocks = <&clki40mhz>; > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > b/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > index 55c60919991f..32608578a352 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml > @@ -77,12 +77,6 @@ examples: > > clock-output-names = "dsi1_byte", "dsi1_ddr2", "dsi1_ddr"; > > -pitouchscreen: panel@0 { > -compatible = "raspberrypi,touchscreen"; > -reg = <0>; > - > -/* ... */ > -}; > }; > > ... > diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > index 0cd74c8dab42..dae0676b5c6e 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml > @@ -40,7 +40,7 @@ additionalProperties: false > examples: >- | > panel { > -
Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings
On Tue, Mar 16, 2021 at 01:49:18PM -0600, Rob Herring wrote: > Adding checks for undocumented compatible strings reveals a bunch of > warnings in the DT binding examples. Fix the cases which are typos, just > a mismatch between the schema and the example, or aren't documented at all. > In a couple of cases, fixing the compatible revealed some schema errors > which are fixed. > > There's a bunch of others remaining after this which have bindings, but > those aren't converted to schema yet. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Vinod Koul > Cc: Alexandre Belloni > Cc: Jonathan Cameron > Cc: Pavel Machek > Cc: Kishon Vijay Abraham I > Cc: Sebastian Reichel > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: dmaeng...@vger.kernel.org > Cc: linux-...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Cc: linux-l...@vger.kernel.org > Cc: linux...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Greg Kroah-Hartman
Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings
Quoting Rob Herring (2021-03-16 12:49:18) > Adding checks for undocumented compatible strings reveals a bunch of > warnings in the DT binding examples. Fix the cases which are typos, just > a mismatch between the schema and the example, or aren't documented at all. > In a couple of cases, fixing the compatible revealed some schema errors > which are fixed. > > There's a bunch of others remaining after this which have bindings, but > those aren't converted to schema yet. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: Vinod Koul > Cc: Alexandre Belloni > Cc: Jonathan Cameron > Cc: Pavel Machek > Cc: Kishon Vijay Abraham I > Cc: Sebastian Reichel > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: dmaeng...@vger.kernel.org > Cc: linux-...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Cc: linux-l...@vger.kernel.org > Cc: linux...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring > --- Acked-by: Stephen Boyd
Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings
On Tue, Mar 16, 2021 at 01:49:18PM -0600, Rob Herring wrote: > Adding checks for undocumented compatible strings reveals a bunch of > warnings in the DT binding examples. Fix the cases which are typos, just > a mismatch between the schema and the example, or aren't documented at all. > In a couple of cases, fixing the compatible revealed some schema errors > which are fixed. Acked-by: Mark Brown signature.asc Description: PGP signature
[PATCH] dt-bindings: Clean-up undocumented compatible strings
Adding checks for undocumented compatible strings reveals a bunch of warnings in the DT binding examples. Fix the cases which are typos, just a mismatch between the schema and the example, or aren't documented at all. In a couple of cases, fixing the compatible revealed some schema errors which are fixed. There's a bunch of others remaining after this which have bindings, but those aren't converted to schema yet. Cc: Stephen Boyd Cc: Maxime Ripard Cc: Thierry Reding Cc: Sam Ravnborg Cc: Vinod Koul Cc: Alexandre Belloni Cc: Jonathan Cameron Cc: Pavel Machek Cc: Kishon Vijay Abraham I Cc: Sebastian Reichel Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org Cc: dmaeng...@vger.kernel.org Cc: linux-...@lists.infradead.org Cc: linux-...@vger.kernel.org Cc: linux-l...@vger.kernel.org Cc: linux...@vger.kernel.org Cc: linux-ser...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Rob Herring --- .../clock/allwinner,sun4i-a10-pll1-clk.yaml | 2 +- .../bindings/clock/milbeaut-clock.yaml| 12 + .../bindings/display/brcm,bcm2835-dsi0.yaml | 6 - .../bindings/display/panel/panel-dpi.yaml | 2 +- .../devicetree/bindings/dma/qcom,gpi.yaml | 2 +- .../devicetree/bindings/i3c/i3c.yaml | 7 ++--- .../iio/adc/brcm,iproc-static-adc.yaml| 5 .../iio/gyroscope/nxp,fxas21002c.yaml | 2 +- .../bindings/iio/light/upisemi,us5182.yaml| 4 +-- .../interrupt-controller/loongson,htpic.yaml | 2 +- .../devicetree/bindings/leds/leds-lgm.yaml| 26 --- .../bindings/phy/ti,phy-j721e-wiz.yaml| 2 +- .../bindings/power/supply/cw2015_battery.yaml | 2 +- .../bindings/power/supply/power-supply.yaml | 22 .../devicetree/bindings/serial/serial.yaml| 2 +- .../bindings/spi/amlogic,meson-gx-spicc.yaml | 4 +-- .../bindings/spi/spi-controller.yaml | 21 --- .../devicetree/bindings/spi/spi-mux.yaml | 8 ++ .../devicetree/bindings/spi/st,stm32-spi.yaml | 6 - 19 files changed, 58 insertions(+), 79 deletions(-) diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml index e9c4cf834aa7..e5d9d45dab8a 100644 --- a/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml +++ b/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-pll1-clk.yaml @@ -44,7 +44,7 @@ examples: - | clk@1c2 { #clock-cells = <0>; -compatible = "allwinner,sun4i-a10-pll1"; +compatible = "allwinner,sun4i-a10-pll1-clk"; reg = <0x01c2 0x4>; clocks = <&osc24M>; clock-output-names = "osc24M"; diff --git a/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml b/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml index 0e8b07710451..6d39344d2b70 100644 --- a/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml +++ b/Documentation/devicetree/bindings/clock/milbeaut-clock.yaml @@ -18,10 +18,12 @@ description: | properties: compatible: -oneOf: - - items: - - enum: - - socionext,milbeaut-m10v-ccu +enum: + - socionext,milbeaut-m10v-ccu + + reg: +maxItems: 1 + clocks: maxItems: 1 description: external clock @@ -41,7 +43,7 @@ examples: # Clock controller node: - | m10v-clk-ctrl@1d021000 { -compatible = "socionext,milbeaut-m10v-clk-ccu"; +compatible = "socionext,milbeaut-m10v-ccu"; reg = <0x1d021000 0x4000>; #clock-cells = <1>; clocks = <&clki40mhz>; diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml index 55c60919991f..32608578a352 100644 --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml @@ -77,12 +77,6 @@ examples: clock-output-names = "dsi1_byte", "dsi1_ddr2", "dsi1_ddr"; -pitouchscreen: panel@0 { -compatible = "raspberrypi,touchscreen"; -reg = <0>; - -/* ... */ -}; }; ... diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml index 0cd74c8dab42..dae0676b5c6e 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml @@ -40,7 +40,7 @@ additionalProperties: false examples: - | panel { -compatible = "osddisplays,osd057T0559-34ts", "panel-dpi"; +compatible = "startek,startek-kd050c", "panel-dpi"; label = "osddisplay"; power-supply = <&vcc_supply>; backlight = <&backlight>; diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom