RE: [PATCH] efi, pstore: Cocci spatch "memdup.spatch"
> Who wants to pick this one up? Tony? Sure - I'll take it. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] efi, pstore: Cocci spatch "memdup.spatch"
On Sat, 01 Jun, at 11:40:02AM, Thomas Meyer wrote: > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/drivers/firmware/efi/efi-pstore.c > b/drivers/firmware/efi/efi-pstore.c > --- a/drivers/firmware/efi/efi-pstore.c > +++ b/drivers/firmware/efi/efi-pstore.c > @@ -79,10 +79,9 @@ static int efi_pstore_read_func(struct e > >var.DataSize, entry->var.Data); > size = entry->var.DataSize; > > - *cb_data->buf = kmalloc(size, GFP_KERNEL); > + *cb_data->buf = kmemdup(entry->var.Data, size, GFP_KERNEL); > if (*cb_data->buf == NULL) > return -ENOMEM; > - memcpy(*cb_data->buf, entry->var.Data, size); > return size; > } Who wants to pick this one up? Tony? -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] efi, pstore: Cocci spatch memdup.spatch
On Sat, 01 Jun, at 11:40:02AM, Thomas Meyer wrote: Signed-off-by: Thomas Meyer tho...@m3y3r.de --- diff -u -p a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c --- a/drivers/firmware/efi/efi-pstore.c +++ b/drivers/firmware/efi/efi-pstore.c @@ -79,10 +79,9 @@ static int efi_pstore_read_func(struct e entry-var.DataSize, entry-var.Data); size = entry-var.DataSize; - *cb_data-buf = kmalloc(size, GFP_KERNEL); + *cb_data-buf = kmemdup(entry-var.Data, size, GFP_KERNEL); if (*cb_data-buf == NULL) return -ENOMEM; - memcpy(*cb_data-buf, entry-var.Data, size); return size; } Who wants to pick this one up? Tony? -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] efi, pstore: Cocci spatch memdup.spatch
Who wants to pick this one up? Tony? Sure - I'll take it. -Tony -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] efi, pstore: Cocci spatch "memdup.spatch"
On Sat, Jun 1, 2013 at 2:40 AM, Thomas Meyer wrote: > > Signed-off-by: Thomas Meyer Acked-by: Kees Cook Thanks! -Kees > --- > > diff -u -p a/drivers/firmware/efi/efi-pstore.c > b/drivers/firmware/efi/efi-pstore.c > --- a/drivers/firmware/efi/efi-pstore.c > +++ b/drivers/firmware/efi/efi-pstore.c > @@ -79,10 +79,9 @@ static int efi_pstore_read_func(struct e >>var.DataSize, entry->var.Data); > size = entry->var.DataSize; > > - *cb_data->buf = kmalloc(size, GFP_KERNEL); > + *cb_data->buf = kmemdup(entry->var.Data, size, GFP_KERNEL); > if (*cb_data->buf == NULL) > return -ENOMEM; > - memcpy(*cb_data->buf, entry->var.Data, size); > return size; > } > > > > -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] efi, pstore: Cocci spatch "memdup.spatch"
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c --- a/drivers/firmware/efi/efi-pstore.c +++ b/drivers/firmware/efi/efi-pstore.c @@ -79,10 +79,9 @@ static int efi_pstore_read_func(struct e >var.DataSize, entry->var.Data); size = entry->var.DataSize; - *cb_data->buf = kmalloc(size, GFP_KERNEL); + *cb_data->buf = kmemdup(entry->var.Data, size, GFP_KERNEL); if (*cb_data->buf == NULL) return -ENOMEM; - memcpy(*cb_data->buf, entry->var.Data, size); return size; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] efi, pstore: Cocci spatch memdup.spatch
Signed-off-by: Thomas Meyer tho...@m3y3r.de --- diff -u -p a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c --- a/drivers/firmware/efi/efi-pstore.c +++ b/drivers/firmware/efi/efi-pstore.c @@ -79,10 +79,9 @@ static int efi_pstore_read_func(struct e entry-var.DataSize, entry-var.Data); size = entry-var.DataSize; - *cb_data-buf = kmalloc(size, GFP_KERNEL); + *cb_data-buf = kmemdup(entry-var.Data, size, GFP_KERNEL); if (*cb_data-buf == NULL) return -ENOMEM; - memcpy(*cb_data-buf, entry-var.Data, size); return size; } -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] efi, pstore: Cocci spatch memdup.spatch
On Sat, Jun 1, 2013 at 2:40 AM, Thomas Meyer tho...@m3y3r.de wrote: Signed-off-by: Thomas Meyer tho...@m3y3r.de Acked-by: Kees Cook keesc...@chromium.org Thanks! -Kees --- diff -u -p a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c --- a/drivers/firmware/efi/efi-pstore.c +++ b/drivers/firmware/efi/efi-pstore.c @@ -79,10 +79,9 @@ static int efi_pstore_read_func(struct e entry-var.DataSize, entry-var.Data); size = entry-var.DataSize; - *cb_data-buf = kmalloc(size, GFP_KERNEL); + *cb_data-buf = kmemdup(entry-var.Data, size, GFP_KERNEL); if (*cb_data-buf == NULL) return -ENOMEM; - memcpy(*cb_data-buf, entry-var.Data, size); return size; } -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
