Re: [PATCH] export.h: clarify comment in relation to avoiding includes
Paul Gortmaker writes: > The existing comment indicated what was desired, but it didn't > necessarily convey the reasoning behind it in an effective way. > > Cc: Rusty Russell > Signed-off-by: Paul Gortmaker > --- > include/linux/export.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/export.h b/include/linux/export.h > index 696c0f4..d14cf26 100644 > --- a/include/linux/export.h > +++ b/include/linux/export.h > @@ -5,8 +5,9 @@ > * to reduce the amount of pointless cruft we feed to gcc when only > * exporting a simple symbol or two. > * > - * If you feel the need to add #include to this file > - * then you are doing something wrong and should go away silently. > + * More specifically, it was all the #include lines in > + * module.h that we wanted to avoid, so please avoid adding any such > + * similar include lines here, if at all possible. > */ > > /* Some toolchains use a `_' prefix for all user symbols. */ > -- > 1.8.1.2 I prefer that :) Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] export.h: clarify comment in relation to avoiding includes
The existing comment indicated what was desired, but it didn't necessarily convey the reasoning behind it in an effective way. Cc: Rusty Russell Signed-off-by: Paul Gortmaker --- include/linux/export.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/linux/export.h b/include/linux/export.h index 696c0f4..d14cf26 100644 --- a/include/linux/export.h +++ b/include/linux/export.h @@ -5,8 +5,9 @@ * to reduce the amount of pointless cruft we feed to gcc when only * exporting a simple symbol or two. * - * If you feel the need to add #include to this file - * then you are doing something wrong and should go away silently. + * More specifically, it was all the #include lines in + * module.h that we wanted to avoid, so please avoid adding any such + * similar include lines here, if at all possible. */ /* Some toolchains use a `_' prefix for all user symbols. */ -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
