Re: [PATCH] firmware: Update Kconfig help text for Google firmware
On Mon, 2018-06-18 at 13:04 -0700, Julius Werner wrote: [...] > nit: Technically, most of the stuff is useful on all coreboot devices, > not just Chromebooks. (Ideally we'd want to factor that out into a > separate drivers/firmware/coreboot, but it's a bit tricky because the > same memconsole frontend is used for both coreboot and a proprietary > Google server BIOS, so it's a little tricky to decide where everything > should go. Nobody had the time to go untangle it yet.) [...] > GSMI is also used by Chromebooks AFAIK. (I think it's sort of become a > general coreboot interface by now as well, although the name still > says Google.) OK, I'll send a v2 to fix these. Ben. -- Ben Hutchings I'm not a reverse psychological virus. Please don't copy me into your signature. signature.asc Description: This is a digitally signed message part
Re: [PATCH] firmware: Update Kconfig help text for Google firmware
On Mon, 2018-06-18 at 13:04 -0700, Julius Werner wrote: [...] > nit: Technically, most of the stuff is useful on all coreboot devices, > not just Chromebooks. (Ideally we'd want to factor that out into a > separate drivers/firmware/coreboot, but it's a bit tricky because the > same memconsole frontend is used for both coreboot and a proprietary > Google server BIOS, so it's a little tricky to decide where everything > should go. Nobody had the time to go untangle it yet.) [...] > GSMI is also used by Chromebooks AFAIK. (I think it's sort of become a > general coreboot interface by now as well, although the name still > says Google.) OK, I'll send a v2 to fix these. Ben. -- Ben Hutchings I'm not a reverse psychological virus. Please don't copy me into your signature. signature.asc Description: This is a digitally signed message part
Re: [PATCH] firmware: Update Kconfig help text for Google firmware
On Sat, Jun 16, 2018 at 3:05 PM Ben Hutchings wrote:
>
> The help text for GOOGLE_FIRMWARE states that it should only be
> enabled when building a kernel for Google's own servers. However, it
> is now also a dependency for various Chromebook firmware drivers.
>
> Update the help text to reflect this double duty. Add the qualifier
> "server" to the help text for GOOGLE_SMI, which doesn't appear to be
> useful on Chromebooks.
>
> Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
> Signed-off-by: Ben Hutchings
> ---
> drivers/firmware/google/Kconfig | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> index f16b381a569c..6fda2c5c69e4 100644
> --- a/drivers/firmware/google/Kconfig
> +++ b/drivers/firmware/google/Kconfig
> @@ -2,9 +2,8 @@ menuconfig GOOGLE_FIRMWARE
> bool "Google Firmware Drivers"
> default n
> help
> - These firmware drivers are used by Google's servers. They are
> - only useful if you are working directly on one of their
> - proprietary servers. If in doubt, say "N".
> + These firmware drivers are used by Google servers and
> + Chromebooks. If in doubt, say "N".
nit: Technically, most of the stuff is useful on all coreboot devices,
not just Chromebooks. (Ideally we'd want to factor that out into a
separate drivers/firmware/coreboot, but it's a bit tricky because the
same memconsole frontend is used for both coreboot and a proprietary
Google server BIOS, so it's a little tricky to decide where everything
should go. Nobody had the time to go untangle it yet.)
> if GOOGLE_FIRMWARE
>
> @@ -14,8 +13,8 @@ config GOOGLE_SMI
> select EFI_VARS
> help
> Say Y here if you want to enable SMI callbacks for Google
> - platforms. This provides an interface for writing to and
> - clearing the EFI event log and reading and writing NVRAM
> + server platforms. This provides an interface for writing to
> + and clearing the EFI event log and reading and writing NVRAM
> variables.
GSMI is also used by Chromebooks AFAIK. (I think it's sort of become a
general coreboot interface by now as well, although the name still
says Google.)
Re: [PATCH] firmware: Update Kconfig help text for Google firmware
On Sat, Jun 16, 2018 at 3:05 PM Ben Hutchings wrote:
>
> The help text for GOOGLE_FIRMWARE states that it should only be
> enabled when building a kernel for Google's own servers. However, it
> is now also a dependency for various Chromebook firmware drivers.
>
> Update the help text to reflect this double duty. Add the qualifier
> "server" to the help text for GOOGLE_SMI, which doesn't appear to be
> useful on Chromebooks.
>
> Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
> Signed-off-by: Ben Hutchings
> ---
> drivers/firmware/google/Kconfig | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> index f16b381a569c..6fda2c5c69e4 100644
> --- a/drivers/firmware/google/Kconfig
> +++ b/drivers/firmware/google/Kconfig
> @@ -2,9 +2,8 @@ menuconfig GOOGLE_FIRMWARE
> bool "Google Firmware Drivers"
> default n
> help
> - These firmware drivers are used by Google's servers. They are
> - only useful if you are working directly on one of their
> - proprietary servers. If in doubt, say "N".
> + These firmware drivers are used by Google servers and
> + Chromebooks. If in doubt, say "N".
nit: Technically, most of the stuff is useful on all coreboot devices,
not just Chromebooks. (Ideally we'd want to factor that out into a
separate drivers/firmware/coreboot, but it's a bit tricky because the
same memconsole frontend is used for both coreboot and a proprietary
Google server BIOS, so it's a little tricky to decide where everything
should go. Nobody had the time to go untangle it yet.)
> if GOOGLE_FIRMWARE
>
> @@ -14,8 +13,8 @@ config GOOGLE_SMI
> select EFI_VARS
> help
> Say Y here if you want to enable SMI callbacks for Google
> - platforms. This provides an interface for writing to and
> - clearing the EFI event log and reading and writing NVRAM
> + server platforms. This provides an interface for writing to
> + and clearing the EFI event log and reading and writing NVRAM
> variables.
GSMI is also used by Chromebooks AFAIK. (I think it's sort of become a
general coreboot interface by now as well, although the name still
says Google.)
[PATCH] firmware: Update Kconfig help text for Google firmware
The help text for GOOGLE_FIRMWARE states that it should only be
enabled when building a kernel for Google's own servers. However, it
is now also a dependency for various Chromebook firmware drivers.
Update the help text to reflect this double duty. Add the qualifier
"server" to the help text for GOOGLE_SMI, which doesn't appear to be
useful on Chromebooks.
Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
Signed-off-by: Ben Hutchings
---
drivers/firmware/google/Kconfig | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
index f16b381a569c..6fda2c5c69e4 100644
--- a/drivers/firmware/google/Kconfig
+++ b/drivers/firmware/google/Kconfig
@@ -2,9 +2,8 @@ menuconfig GOOGLE_FIRMWARE
bool "Google Firmware Drivers"
default n
help
- These firmware drivers are used by Google's servers. They are
- only useful if you are working directly on one of their
- proprietary servers. If in doubt, say "N".
+ These firmware drivers are used by Google servers and
+ Chromebooks. If in doubt, say "N".
if GOOGLE_FIRMWARE
@@ -14,8 +13,8 @@ config GOOGLE_SMI
select EFI_VARS
help
Say Y here if you want to enable SMI callbacks for Google
- platforms. This provides an interface for writing to and
- clearing the EFI event log and reading and writing NVRAM
+ server platforms. This provides an interface for writing to
+ and clearing the EFI event log and reading and writing NVRAM
variables.
config GOOGLE_COREBOOT_TABLE
signature.asc
Description: Digital signature
[PATCH] firmware: Update Kconfig help text for Google firmware
The help text for GOOGLE_FIRMWARE states that it should only be
enabled when building a kernel for Google's own servers. However, it
is now also a dependency for various Chromebook firmware drivers.
Update the help text to reflect this double duty. Add the qualifier
"server" to the help text for GOOGLE_SMI, which doesn't appear to be
useful on Chromebooks.
Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
Signed-off-by: Ben Hutchings
---
drivers/firmware/google/Kconfig | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
index f16b381a569c..6fda2c5c69e4 100644
--- a/drivers/firmware/google/Kconfig
+++ b/drivers/firmware/google/Kconfig
@@ -2,9 +2,8 @@ menuconfig GOOGLE_FIRMWARE
bool "Google Firmware Drivers"
default n
help
- These firmware drivers are used by Google's servers. They are
- only useful if you are working directly on one of their
- proprietary servers. If in doubt, say "N".
+ These firmware drivers are used by Google servers and
+ Chromebooks. If in doubt, say "N".
if GOOGLE_FIRMWARE
@@ -14,8 +13,8 @@ config GOOGLE_SMI
select EFI_VARS
help
Say Y here if you want to enable SMI callbacks for Google
- platforms. This provides an interface for writing to and
- clearing the EFI event log and reading and writing NVRAM
+ server platforms. This provides an interface for writing to
+ and clearing the EFI event log and reading and writing NVRAM
variables.
config GOOGLE_COREBOOT_TABLE
signature.asc
Description: Digital signature
