RE: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update
> I swear this had been fixed before. Thanks for catching it! Maybe I missed it? > Acked-by: Kees Cook Got it this time - should show up in the next linux-next build. Thanks -Tony
Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update
On Mon, Mar 9, 2015 at 12:39 AM, Wang Long wrote: > In the function ramoops_probe, the console_size, pmsg_size, > ftrace_size may be update because the value is not the power > of two. We should update the module parameter variables > as well so they are visible through /sys/module/ramoops/parameters > correctly. > > Signed-off-by: Wang Long > --- > fs/pstore/ram.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c > index 5df325e..1aaa8dc 100644 > --- a/fs/pstore/ram.c > +++ b/fs/pstore/ram.c > @@ -559,6 +559,9 @@ pr_info("[%s] pstore_register", __func__); > mem_address = pdata->mem_address; > record_size = pdata->record_size; > dump_oops = pdata->dump_oops; > + ramoops_console_size = pdata->console_size; > + ramoops_pmsg_size = pdata->pmsg_size; > + ramoops_ftrace_size = pdata->ftrace_size; > > pr_info("attached 0x%lx@0x%llx, ecc: %d/%d\n", > cxt->size, (unsigned long long)cxt->phys_addr, I swear this had been fixed before. Thanks for catching it! Acked-by: Kees Cook -Kees > -- > 1.8.3.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update
On 03/09/2015 04:17 AM, long.wanglong wrote: In the function ramoops_probe, the console_size, pmsg_size, ftrace_size may be update because the value is not the power of two. We should update the module parameter variables as well so they are visible through /sys/module/ramoops/parameters correctly. Signed-off-by: Wang Long --- fs/pstore/ram.c | 3 +++ 1 file changed, 3 insertions(+) Ack -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update
On 2015/3/9 15:39, Wang Long wrote: cc: marco.storne...@gmail.com cc: anton.voront...@linaro.org cc: saly...@android.com cc: ser...@chromium.org > In the function ramoops_probe, the console_size, pmsg_size, > ftrace_size may be update because the value is not the power > of two. We should update the module parameter variables > as well so they are visible through /sys/module/ramoops/parameters > correctly. > > Signed-off-by: Wang Long > --- > fs/pstore/ram.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c > index 5df325e..1aaa8dc 100644 > --- a/fs/pstore/ram.c > +++ b/fs/pstore/ram.c > @@ -559,6 +559,9 @@ pr_info("[%s] pstore_register", __func__); > mem_address = pdata->mem_address; > record_size = pdata->record_size; > dump_oops = pdata->dump_oops; > + ramoops_console_size = pdata->console_size; > + ramoops_pmsg_size = pdata->pmsg_size; > + ramoops_ftrace_size = pdata->ftrace_size; > > pr_info("attached 0x%lx@0x%llx, ecc: %d/%d\n", > cxt->size, (unsigned long long)cxt->phys_addr, > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update
In the function ramoops_probe, the console_size, pmsg_size, ftrace_size may be update because the value is not the power of two. We should update the module parameter variables as well so they are visible through /sys/module/ramoops/parameters correctly. Signed-off-by: Wang Long --- fs/pstore/ram.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index 5df325e..1aaa8dc 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -559,6 +559,9 @@ pr_info("[%s] pstore_register", __func__); mem_address = pdata->mem_address; record_size = pdata->record_size; dump_oops = pdata->dump_oops; + ramoops_console_size = pdata->console_size; + ramoops_pmsg_size = pdata->pmsg_size; + ramoops_ftrace_size = pdata->ftrace_size; pr_info("attached 0x%lx@0x%llx, ecc: %d/%d\n", cxt->size, (unsigned long long)cxt->phys_addr, -- 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/