Re: [PATCH] fs: cifs: remove unneeded variable in smb3_fs_context_dup

2021-01-12 Thread Aurélien Aptel


Reviewed-by: Aurelien Aptel 

Thanks,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)



[PATCH] fs: cifs: remove unneeded variable in smb3_fs_context_dup

2021-01-12 Thread menglong8 . dong
From: Menglong Dong 

'rc' in smb3_fs_context_dup is not used and can be removed.

Signed-off-by: Menglong Dong 
---
 fs/cifs/fs_context.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/cifs/fs_context.c b/fs/cifs/fs_context.c
index 0afccbbed2e6..076bcadc756a 100644
--- a/fs/cifs/fs_context.c
+++ b/fs/cifs/fs_context.c
@@ -303,8 +303,6 @@ do {
\
 int
 smb3_fs_context_dup(struct smb3_fs_context *new_ctx, struct smb3_fs_context 
*ctx)
 {
-   int rc = 0;
-
memcpy(new_ctx, ctx, sizeof(*ctx));
new_ctx->prepath = NULL;
new_ctx->mount_options = NULL;
@@ -327,7 +325,7 @@ smb3_fs_context_dup(struct smb3_fs_context *new_ctx, struct 
smb3_fs_context *ctx
DUP_CTX_STR(nodename);
DUP_CTX_STR(iocharset);
 
-   return rc;
+   return 0;
 }
 
 static int
-- 
2.17.1