Re: [PATCH] gpio: eic-sprd: break loop when getting NULL device resource

[Linus Walleij]

On Wed, Dec 9, 2020 at 6:51 AM Chunyan Zhang  wrote:

> EIC controller have unfixed numbers of banks on different Spreadtrum SoCs,
> and each bank has its own base address, the loop of getting there base
> address in driver should break if the resource gotten via
> platform_get_resource() is NULL already. The later ones would be all NULL
> even if the loop continues.
>
> Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
> Signed-off-by: Chunyan Zhang 

Patch applied for fixes!

Yours,
Linus Walleij

[PATCH] gpio: eic-sprd: break loop when getting NULL device resource

[Chunyan Zhang]

From: Chunyan Zhang 

EIC controller have unfixed numbers of banks on different Spreadtrum SoCs,
and each bank has its own base address, the loop of getting there base
address in driver should break if the resource gotten via
platform_get_resource() is NULL already. The later ones would be all NULL
even if the loop continues.

Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
Signed-off-by: Chunyan Zhang 
---
 drivers/gpio/gpio-eic-sprd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
index ad61daf6c212..865ab2b34fdd 100644
--- a/drivers/gpio/gpio-eic-sprd.c
+++ b/drivers/gpio/gpio-eic-sprd.c
@@ -598,7 +598,7 @@ static int sprd_eic_probe(struct platform_device *pdev)
 */
res = platform_get_resource(pdev, IORESOURCE_MEM, i);
if (!res)
-   continue;
+   break;
 
sprd_eic->base[i] = devm_ioremap_resource(>dev, res);
if (IS_ERR(sprd_eic->base[i]))
-- 
2.25.1