Re: [PATCH] gpio: gpio-reg: fix build
On Sun, Dec 24, 2017 at 06:44:07PM +0100, Linus Walleij wrote: > On Sun, Dec 24, 2017 at 4:56 PM, Russell King - ARM Linux > wrote: > > > But the main thing is, this needs to be fixed - it's been causing build > > errors for those of us carrying patches to use it, and thereby destroying > > the usefulness of nightly testing. > > I'm sorry, it's my fault for not being swift enough. :( > > I sent a combined seasonal greetings and pull request to > Torvalds this morning. Thanks, and Seasons Greetings to you! -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
Re: [PATCH] gpio: gpio-reg: fix build
On Sun, Dec 24, 2017 at 4:56 PM, Russell King - ARM Linux wrote: > But the main thing is, this needs to be fixed - it's been causing build > errors for those of us carrying patches to use it, and thereby destroying > the usefulness of nightly testing. I'm sorry, it's my fault for not being swift enough. :( I sent a combined seasonal greetings and pull request to Torvalds this morning. Yours, Linus Walleij
Re: [PATCH] gpio: gpio-reg: fix build
On Sun, Dec 24, 2017 at 04:49:39PM +0100, Geert Uytterhoeven wrote:
> Hi Grygorii,
>
> On Wed, Dec 6, 2017 at 6:37 PM, Grygorii Strashko
> wrote:
> > Revert changes introduced by commit f0fbe7bce733 ("gpio: Move irqdomain
> > into struct gpio_irq_chip") as they are not aplicable to this driver.
> >
> > Cc: Russell King - ARM Linux
> > Fixes: f0fbe7bce733 ("gpio: Move irqdomain into struct gpio_irq_chip")
> > Signed-off-by: Grygorii Strashko
> > ---
> > Sorry, for inconvenience, but this driver has no users in lkml and
> > it can't be enabled through defconfig - only selected, so builds can't
> > be verified in standard way.
>
> Seems like we need:
>
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -392,7 +392,7 @@ config GPIO_RCAR
> Say yes here to support GPIO on Renesas R-Car SoCs.
>
> config GPIO_REG
> - bool
> + bool "32-bit single register GPIO fixed in/out support" if
> COMPILE_TEST
> help
> A 32-bit single register GPIO fixed in/out implementation. This
> can be used to represent any register as a set of GPIO signals.
>
> Any dependencies to be added?
No need, once some patches go in, this will be selected and then it'll
get build coverage.
But the main thing is, this needs to be fixed - it's been causing build
errors for those of us carrying patches to use it, and thereby destroying
the usefulness of nightly testing.
http://www.home.armlinux.org.uk/developer/build/index.php?id=2002
http://www.home.armlinux.org.uk/developer/build/index.php?id=2004
Can we please get the fix into -rc? Keeping the _regression_ _fix_ out
of -rc not only means that we're stuck with these build failures, but
also means that we create bisect problems for the next merge window.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
Re: [PATCH] gpio: gpio-reg: fix build
Hi Grygorii,
On Wed, Dec 6, 2017 at 6:37 PM, Grygorii Strashko
wrote:
> Revert changes introduced by commit f0fbe7bce733 ("gpio: Move irqdomain
> into struct gpio_irq_chip") as they are not aplicable to this driver.
>
> Cc: Russell King - ARM Linux
> Fixes: f0fbe7bce733 ("gpio: Move irqdomain into struct gpio_irq_chip")
> Signed-off-by: Grygorii Strashko
> ---
> Sorry, for inconvenience, but this driver has no users in lkml and
> it can't be enabled through defconfig - only selected, so builds can't
> be verified in standard way.
Seems like we need:
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -392,7 +392,7 @@ config GPIO_RCAR
Say yes here to support GPIO on Renesas R-Car SoCs.
config GPIO_REG
- bool
+ bool "32-bit single register GPIO fixed in/out support" if COMPILE_TEST
help
A 32-bit single register GPIO fixed in/out implementation. This
can be used to represent any register as a set of GPIO signals.
Any dependencies to be added?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH] gpio: gpio-reg: fix build
On Wed, Dec 6, 2017 at 6:37 PM, Grygorii Strashko
wrote:
> Revert changes introduced by commit f0fbe7bce733 ("gpio: Move irqdomain
> into struct gpio_irq_chip") as they are not aplicable to this driver.
>
> Cc: Russell King - ARM Linux
> Fixes: f0fbe7bce733 ("gpio: Move irqdomain into struct gpio_irq_chip")
> Signed-off-by: Grygorii Strashko
Patch applied for fixes.
Yours,
Linus Walleij
[PATCH] gpio: gpio-reg: fix build
Revert changes introduced by commit f0fbe7bce733 ("gpio: Move irqdomain
into struct gpio_irq_chip") as they are not aplicable to this driver.
Cc: Russell King - ARM Linux
Fixes: f0fbe7bce733 ("gpio: Move irqdomain into struct gpio_irq_chip")
Signed-off-by: Grygorii Strashko
---
Sorry, for inconvenience, but this driver has no users in lkml and
it can't be enabled through defconfig - only selected, so builds can't
be verified in standard way.
drivers/gpio/gpio-reg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-reg.c b/drivers/gpio/gpio-reg.c
index 23e771d..e85903e 100644
--- a/drivers/gpio/gpio-reg.c
+++ b/drivers/gpio/gpio-reg.c
@@ -103,8 +103,8 @@ static int gpio_reg_to_irq(struct gpio_chip *gc, unsigned
offset)
struct gpio_reg *r = to_gpio_reg(gc);
int irq = r->irqs[offset];
- if (irq >= 0 && r->irq.domain)
- irq = irq_find_mapping(r->irq.domain, irq);
+ if (irq >= 0 && r->irqdomain)
+ irq = irq_find_mapping(r->irqdomain, irq);
return irq;
}
--
2.10.5
