Re: [PATCH] gpio: intel-mid: Fix build warning when !CONFIG_PM
On Mon, Jan 16, 2017 at 3:30 PM, Augusto Mecking Caringiwrote: > The only usage of function intel_gpio_runtime_idle() is here (in the > same file): > > static const struct dev_pm_ops intel_gpio_pm_ops = { > SET_RUNTIME_PM_OPS(NULL, NULL, intel_gpio_runtime_idle) > }; > > And when CONFIG_PM is not set, the macro SET_RUNTIME_PM_OPS expands to > nothing, causing the following compiler warning: > > drivers/gpio/gpio-intel-mid.c:324:12: warning: ‘intel_gpio_runtime_idle’ > defined but not used [-Wunused-function] > static int intel_gpio_runtime_idle(struct device *dev) > > Fix it by annotating the function with __maybe_unused. > > Signed-off-by: Augusto Mecking Caringi Patch applied with Andy's ACK. Yours, Linus Walleij
Re: [PATCH] gpio: intel-mid: Fix build warning when !CONFIG_PM
On Mon, Jan 16, 2017 at 3:30 PM, Augusto Mecking Caringi wrote: > The only usage of function intel_gpio_runtime_idle() is here (in the > same file): > > static const struct dev_pm_ops intel_gpio_pm_ops = { > SET_RUNTIME_PM_OPS(NULL, NULL, intel_gpio_runtime_idle) > }; > > And when CONFIG_PM is not set, the macro SET_RUNTIME_PM_OPS expands to > nothing, causing the following compiler warning: > > drivers/gpio/gpio-intel-mid.c:324:12: warning: ‘intel_gpio_runtime_idle’ > defined but not used [-Wunused-function] > static int intel_gpio_runtime_idle(struct device *dev) > > Fix it by annotating the function with __maybe_unused. > > Signed-off-by: Augusto Mecking Caringi Patch applied with Andy's ACK. Yours, Linus Walleij
Re: [PATCH] gpio: intel-mid: Fix build warning when !CONFIG_PM
On Mon, Jan 16, 2017 at 4:30 PM, Augusto Mecking Caringiwrote: > The only usage of function intel_gpio_runtime_idle() is here (in the > same file): > > static const struct dev_pm_ops intel_gpio_pm_ops = { > SET_RUNTIME_PM_OPS(NULL, NULL, intel_gpio_runtime_idle) > }; > > And when CONFIG_PM is not set, the macro SET_RUNTIME_PM_OPS expands to > nothing, causing the following compiler warning: > > drivers/gpio/gpio-intel-mid.c:324:12: warning: ‘intel_gpio_runtime_idle’ > defined but not used [-Wunused-function] > static int intel_gpio_runtime_idle(struct device *dev) > > Fix it by annotating the function with __maybe_unused. Acked-by: Andy Shevchenko > > Signed-off-by: Augusto Mecking Caringi > --- > drivers/gpio/gpio-intel-mid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c > index a1e44c2..b76ecee 100644 > --- a/drivers/gpio/gpio-intel-mid.c > +++ b/drivers/gpio/gpio-intel-mid.c > @@ -321,7 +321,7 @@ static void intel_mid_irq_init_hw(struct intel_mid_gpio > *priv) > } > } > > -static int intel_gpio_runtime_idle(struct device *dev) > +static int __maybe_unused intel_gpio_runtime_idle(struct device *dev) > { > int err = pm_schedule_suspend(dev, 500); > return err ?: -EBUSY; > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko
Re: [PATCH] gpio: intel-mid: Fix build warning when !CONFIG_PM
On Mon, Jan 16, 2017 at 4:30 PM, Augusto Mecking Caringi wrote: > The only usage of function intel_gpio_runtime_idle() is here (in the > same file): > > static const struct dev_pm_ops intel_gpio_pm_ops = { > SET_RUNTIME_PM_OPS(NULL, NULL, intel_gpio_runtime_idle) > }; > > And when CONFIG_PM is not set, the macro SET_RUNTIME_PM_OPS expands to > nothing, causing the following compiler warning: > > drivers/gpio/gpio-intel-mid.c:324:12: warning: ‘intel_gpio_runtime_idle’ > defined but not used [-Wunused-function] > static int intel_gpio_runtime_idle(struct device *dev) > > Fix it by annotating the function with __maybe_unused. Acked-by: Andy Shevchenko > > Signed-off-by: Augusto Mecking Caringi > --- > drivers/gpio/gpio-intel-mid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c > index a1e44c2..b76ecee 100644 > --- a/drivers/gpio/gpio-intel-mid.c > +++ b/drivers/gpio/gpio-intel-mid.c > @@ -321,7 +321,7 @@ static void intel_mid_irq_init_hw(struct intel_mid_gpio > *priv) > } > } > > -static int intel_gpio_runtime_idle(struct device *dev) > +static int __maybe_unused intel_gpio_runtime_idle(struct device *dev) > { > int err = pm_schedule_suspend(dev, 500); > return err ?: -EBUSY; > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko
[PATCH] gpio: intel-mid: Fix build warning when !CONFIG_PM
The only usage of function intel_gpio_runtime_idle() is here (in the same file): static const struct dev_pm_ops intel_gpio_pm_ops = { SET_RUNTIME_PM_OPS(NULL, NULL, intel_gpio_runtime_idle) }; And when CONFIG_PM is not set, the macro SET_RUNTIME_PM_OPS expands to nothing, causing the following compiler warning: drivers/gpio/gpio-intel-mid.c:324:12: warning: ‘intel_gpio_runtime_idle’ defined but not used [-Wunused-function] static int intel_gpio_runtime_idle(struct device *dev) Fix it by annotating the function with __maybe_unused. Signed-off-by: Augusto Mecking Caringi--- drivers/gpio/gpio-intel-mid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c index a1e44c2..b76ecee 100644 --- a/drivers/gpio/gpio-intel-mid.c +++ b/drivers/gpio/gpio-intel-mid.c @@ -321,7 +321,7 @@ static void intel_mid_irq_init_hw(struct intel_mid_gpio *priv) } } -static int intel_gpio_runtime_idle(struct device *dev) +static int __maybe_unused intel_gpio_runtime_idle(struct device *dev) { int err = pm_schedule_suspend(dev, 500); return err ?: -EBUSY; -- 2.7.4
[PATCH] gpio: intel-mid: Fix build warning when !CONFIG_PM
The only usage of function intel_gpio_runtime_idle() is here (in the same file): static const struct dev_pm_ops intel_gpio_pm_ops = { SET_RUNTIME_PM_OPS(NULL, NULL, intel_gpio_runtime_idle) }; And when CONFIG_PM is not set, the macro SET_RUNTIME_PM_OPS expands to nothing, causing the following compiler warning: drivers/gpio/gpio-intel-mid.c:324:12: warning: ‘intel_gpio_runtime_idle’ defined but not used [-Wunused-function] static int intel_gpio_runtime_idle(struct device *dev) Fix it by annotating the function with __maybe_unused. Signed-off-by: Augusto Mecking Caringi --- drivers/gpio/gpio-intel-mid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c index a1e44c2..b76ecee 100644 --- a/drivers/gpio/gpio-intel-mid.c +++ b/drivers/gpio/gpio-intel-mid.c @@ -321,7 +321,7 @@ static void intel_mid_irq_init_hw(struct intel_mid_gpio *priv) } } -static int intel_gpio_runtime_idle(struct device *dev) +static int __maybe_unused intel_gpio_runtime_idle(struct device *dev) { int err = pm_schedule_suspend(dev, 500); return err ?: -EBUSY; -- 2.7.4