Re: [PATCH] gpiolib: probe deferral error reporting

2018-07-29 Thread Linus Walleij 
On Fri, Jul 20, 2018 at 9:54 AM Marcel Ziswiler  wrote:

> From: Marcel Ziswiler 
>
> Actually report the error code from devm_regulator_get() which may as
> well just be a probe deferral.
>
> This is e.g. what one gets upon booting a Colibri T20:
>
> gpiochip_add_data_with_key: GPIOs 0..223 (tegra-gpio) failed to register
>
> Signed-off-by: Marcel Ziswiler 

Makes perfect sense.
Patch applied.

Yours,
Linus Walleij

Re: [PATCH] gpiolib: probe deferral error reporting

2018-07-29 Thread Linus Walleij 
On Fri, Jul 20, 2018 at 9:54 AM Marcel Ziswiler  wrote:

> From: Marcel Ziswiler 
>
> Actually report the error code from devm_regulator_get() which may as
> well just be a probe deferral.
>
> This is e.g. what one gets upon booting a Colibri T20:
>
> gpiochip_add_data_with_key: GPIOs 0..223 (tegra-gpio) failed to register
>
> Signed-off-by: Marcel Ziswiler 

Makes perfect sense.
Patch applied.

Yours,
Linus Walleij

[PATCH] gpiolib: probe deferral error reporting

2018-07-20 Thread Marcel Ziswiler 
From: Marcel Ziswiler 

Actually report the error code from devm_regulator_get() which may as
well just be a probe deferral.

This is e.g. what one gets upon booting a Colibri T20:

gpiochip_add_data_with_key: GPIOs 0..223 (tegra-gpio) failed to register

Signed-off-by: Marcel Ziswiler 

---

 drivers/gpio/gpiolib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 2e2a6f8db405..40c65eb1d97b 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1408,9 +1408,9 @@ int gpiochip_add_data_with_key(struct gpio_chip *chip, 
void *data,
 err_free_gdev:
ida_simple_remove(_ida, gdev->id);
/* failures here can mean systems won't boot... */
-   pr_err("%s: GPIOs %d..%d (%s) failed to register\n", __func__,
+   pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,
   gdev->base, gdev->base + gdev->ngpio - 1,
-  chip->label ? : "generic");
+  chip->label ? : "generic", status);
kfree(gdev);
return status;
 }
-- 
2.14.4

[PATCH] gpiolib: probe deferral error reporting

2018-07-20 Thread Marcel Ziswiler 
From: Marcel Ziswiler 

Actually report the error code from devm_regulator_get() which may as
well just be a probe deferral.

This is e.g. what one gets upon booting a Colibri T20:

gpiochip_add_data_with_key: GPIOs 0..223 (tegra-gpio) failed to register

Signed-off-by: Marcel Ziswiler 

---

 drivers/gpio/gpiolib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 2e2a6f8db405..40c65eb1d97b 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1408,9 +1408,9 @@ int gpiochip_add_data_with_key(struct gpio_chip *chip, 
void *data,
 err_free_gdev:
ida_simple_remove(_ida, gdev->id);
/* failures here can mean systems won't boot... */
-   pr_err("%s: GPIOs %d..%d (%s) failed to register\n", __func__,
+   pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__,
   gdev->base, gdev->base + gdev->ngpio - 1,
-  chip->label ? : "generic");
+  chip->label ? : "generic", status);
kfree(gdev);
return status;
 }
-- 
2.14.4