Re: [PATCH] gpiolib: remove unused variable

2017-05-30 Thread Linus Walleij 
On Tue, May 30, 2017 at 11:21 AM, Arnd Bergmann  wrote:

> This was left behind by a cleanup patch:
>
> drivers/gpio/gpiolib.c: In function 'gpiochip_irqchip_init_valid_mask':
> drivers/gpio/gpiolib.c:1474:6: error: unused variable 'i' 
> [-Werror=unused-variable]
>
> Fixes: 923a654c186c ("gpiolib: Re-use bitmap_fill() instead of open coded 
> loop")
> Signed-off-by: Arnd Bergmann 

Patch applied.

Yours,
Linus Walleij

Re: [PATCH] gpiolib: remove unused variable

2017-05-30 Thread Linus Walleij 
On Tue, May 30, 2017 at 11:21 AM, Arnd Bergmann  wrote:

> This was left behind by a cleanup patch:
>
> drivers/gpio/gpiolib.c: In function 'gpiochip_irqchip_init_valid_mask':
> drivers/gpio/gpiolib.c:1474:6: error: unused variable 'i' 
> [-Werror=unused-variable]
>
> Fixes: 923a654c186c ("gpiolib: Re-use bitmap_fill() instead of open coded 
> loop")
> Signed-off-by: Arnd Bergmann 

Patch applied.

Yours,
Linus Walleij

Re: [PATCH] gpiolib: remove unused variable 'i'

2017-05-30 Thread Colin Ian King 
On 30/05/17 11:58, Mark Brown wrote:
> On Tue, May 30, 2017 at 10:44:20AM +0100, Colin King wrote:
>> From: Colin Ian King 
>>
>> Fixes smatch warning: unused variable 'i' [-Wunused-variable]
>>
>> Signed-off-by: Colin Ian King 
>> ---
>>  drivers/gpio/gpiolib.c   | 2 --
>>  sound/soc/generic/audio-graph-scu-card.c | 2 +-
>>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> You've got two unrelated patches in one here (as a quick review of your
> CC list would probably have warned you...).
> 
Oops, my bad. V2 resent.



signature.asc
Description: OpenPGP digital signature

Re: [PATCH] gpiolib: remove unused variable 'i'

2017-05-30 Thread Colin Ian King 
On 30/05/17 11:58, Mark Brown wrote:
> On Tue, May 30, 2017 at 10:44:20AM +0100, Colin King wrote:
>> From: Colin Ian King 
>>
>> Fixes smatch warning: unused variable 'i' [-Wunused-variable]
>>
>> Signed-off-by: Colin Ian King 
>> ---
>>  drivers/gpio/gpiolib.c   | 2 --
>>  sound/soc/generic/audio-graph-scu-card.c | 2 +-
>>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> You've got two unrelated patches in one here (as a quick review of your
> CC list would probably have warned you...).
> 
Oops, my bad. V2 resent.



signature.asc
Description: OpenPGP digital signature

Re: [PATCH] gpiolib: remove unused variable 'i'

2017-05-30 Thread Mark Brown 
On Tue, May 30, 2017 at 10:44:20AM +0100, Colin King wrote:
> From: Colin Ian King 
> 
> Fixes smatch warning: unused variable 'i' [-Wunused-variable]
> 
> Signed-off-by: Colin Ian King 
> ---
>  drivers/gpio/gpiolib.c   | 2 --
>  sound/soc/generic/audio-graph-scu-card.c | 2 +-
>  2 files changed, 1 insertion(+), 3 deletions(-)

You've got two unrelated patches in one here (as a quick review of your
CC list would probably have warned you...).


signature.asc
Description: PGP signature

Re: [PATCH] gpiolib: remove unused variable 'i'

2017-05-30 Thread Mark Brown 
On Tue, May 30, 2017 at 10:44:20AM +0100, Colin King wrote:
> From: Colin Ian King 
> 
> Fixes smatch warning: unused variable 'i' [-Wunused-variable]
> 
> Signed-off-by: Colin Ian King 
> ---
>  drivers/gpio/gpiolib.c   | 2 --
>  sound/soc/generic/audio-graph-scu-card.c | 2 +-
>  2 files changed, 1 insertion(+), 3 deletions(-)

You've got two unrelated patches in one here (as a quick review of your
CC list would probably have warned you...).


signature.asc
Description: PGP signature

Re: [PATCH] gpiolib: remove unused variable

2017-05-30 Thread Andy Shevchenko 
On Tue, 2017-05-30 at 11:21 +0200, Arnd Bergmann wrote:
> This was left behind by a cleanup patch:
> 
> drivers/gpio/gpiolib.c: In function
> 'gpiochip_irqchip_init_valid_mask':
> drivers/gpio/gpiolib.c:1474:6: error: unused variable 'i' [-
> Werror=unused-variable]


Right, thanks for it!
Reviewed-by: Andy Shevchenko 

> 
> Fixes: 923a654c186c ("gpiolib: Re-use bitmap_fill() instead of open
> coded loop")
> Signed-off-by: Arnd Bergmann 
> ---
>  drivers/gpio/gpiolib.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index be8097097326..62ffb4e293d2 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const
> char *name)
>  
>  static int gpiochip_irqchip_init_valid_mask(struct gpio_chip
> *gpiochip)
>  {
> - int i;
> -
>   if (!gpiochip->irq_need_valid_mask)
>   return 0;
>  

-- 
Andy Shevchenko 
Intel Finland Oy

Re: [PATCH] gpiolib: remove unused variable

2017-05-30 Thread Andy Shevchenko 
On Tue, 2017-05-30 at 11:21 +0200, Arnd Bergmann wrote:
> This was left behind by a cleanup patch:
> 
> drivers/gpio/gpiolib.c: In function
> 'gpiochip_irqchip_init_valid_mask':
> drivers/gpio/gpiolib.c:1474:6: error: unused variable 'i' [-
> Werror=unused-variable]


Right, thanks for it!
Reviewed-by: Andy Shevchenko 

> 
> Fixes: 923a654c186c ("gpiolib: Re-use bitmap_fill() instead of open
> coded loop")
> Signed-off-by: Arnd Bergmann 
> ---
>  drivers/gpio/gpiolib.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index be8097097326..62ffb4e293d2 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const
> char *name)
>  
>  static int gpiochip_irqchip_init_valid_mask(struct gpio_chip
> *gpiochip)
>  {
> - int i;
> -
>   if (!gpiochip->irq_need_valid_mask)
>   return 0;
>  

-- 
Andy Shevchenko 
Intel Finland Oy

[PATCH] gpiolib: remove unused variable 'i'

2017-05-30 Thread Colin King 
From: Colin Ian King 

Fixes smatch warning: unused variable 'i' [-Wunused-variable]

Signed-off-by: Colin Ian King 
---
 drivers/gpio/gpiolib.c   | 2 --
 sound/soc/generic/audio-graph-scu-card.c | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index be8097097326..62ffb4e293d2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const char 
*name)
 
 static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip)
 {
-   int i;
-
if (!gpiochip->irq_need_valid_mask)
return 0;
 
diff --git a/sound/soc/generic/audio-graph-scu-card.c 
b/sound/soc/generic/audio-graph-scu-card.c
index c5c52d1f500c..e15f63c74f59 100644
--- a/sound/soc/generic/audio-graph-scu-card.c
+++ b/sound/soc/generic/audio-graph-scu-card.c
@@ -246,7 +246,7 @@ static int asoc_graph_card_parse_of(struct graph_card_data 
*priv)
continue;
 
if (rcpu_ep != cpu_ep) {
-   dev_err(dev, "remote-endpoint missmatch (%s/%s/%s)\n",
+   dev_err(dev, "remote-endpoint mismatch (%s/%s/%s)\n",
cpu_ep->name, codec_ep->name, rcpu_ep->name);
ret = -EINVAL;
goto parse_of_err;
-- 
2.11.0

[PATCH] gpiolib: remove unused variable 'i'

2017-05-30 Thread Colin King 
From: Colin Ian King 

Fixes smatch warning: unused variable 'i' [-Wunused-variable]

Signed-off-by: Colin Ian King 
---
 drivers/gpio/gpiolib.c   | 2 --
 sound/soc/generic/audio-graph-scu-card.c | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index be8097097326..62ffb4e293d2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const char 
*name)
 
 static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip)
 {
-   int i;
-
if (!gpiochip->irq_need_valid_mask)
return 0;
 
diff --git a/sound/soc/generic/audio-graph-scu-card.c 
b/sound/soc/generic/audio-graph-scu-card.c
index c5c52d1f500c..e15f63c74f59 100644
--- a/sound/soc/generic/audio-graph-scu-card.c
+++ b/sound/soc/generic/audio-graph-scu-card.c
@@ -246,7 +246,7 @@ static int asoc_graph_card_parse_of(struct graph_card_data 
*priv)
continue;
 
if (rcpu_ep != cpu_ep) {
-   dev_err(dev, "remote-endpoint missmatch (%s/%s/%s)\n",
+   dev_err(dev, "remote-endpoint mismatch (%s/%s/%s)\n",
cpu_ep->name, codec_ep->name, rcpu_ep->name);
ret = -EINVAL;
goto parse_of_err;
-- 
2.11.0

[PATCH] gpiolib: remove unused variable

2017-05-30 Thread Arnd Bergmann 
This was left behind by a cleanup patch:

drivers/gpio/gpiolib.c: In function 'gpiochip_irqchip_init_valid_mask':
drivers/gpio/gpiolib.c:1474:6: error: unused variable 'i' 
[-Werror=unused-variable]

Fixes: 923a654c186c ("gpiolib: Re-use bitmap_fill() instead of open coded loop")
Signed-off-by: Arnd Bergmann 
---
 drivers/gpio/gpiolib.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index be8097097326..62ffb4e293d2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const char 
*name)
 
 static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip)
 {
-   int i;
-
if (!gpiochip->irq_need_valid_mask)
return 0;
 
-- 
2.9.0

[PATCH] gpiolib: remove unused variable

2017-05-30 Thread Arnd Bergmann 
This was left behind by a cleanup patch:

drivers/gpio/gpiolib.c: In function 'gpiochip_irqchip_init_valid_mask':
drivers/gpio/gpiolib.c:1474:6: error: unused variable 'i' 
[-Werror=unused-variable]

Fixes: 923a654c186c ("gpiolib: Re-use bitmap_fill() instead of open coded loop")
Signed-off-by: Arnd Bergmann 
---
 drivers/gpio/gpiolib.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index be8097097326..62ffb4e293d2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const char 
*name)
 
 static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip)
 {
-   int i;
-
if (!gpiochip->irq_need_valid_mask)
return 0;
 
-- 
2.9.0