Re: [PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock

[Wolfram Sang]

On Thu, Feb 18, 2016 at 05:12:55PM -0800, Eric Anholt wrote:
> Fixes dmesg spam when we just need to wait a moment for the clock
> driver to probe.
> 
> Signed-off-by: Eric Anholt 

Applied to for-next, thanks!



signature.asc
Description: PGP signature

Re: [PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock

[Wolfram Sang]

On Thu, Feb 18, 2016 at 05:12:55PM -0800, Eric Anholt wrote:
> Fixes dmesg spam when we just need to wait a moment for the clock
> driver to probe.
> 
> Signed-off-by: Eric Anholt 

Applied to for-next, thanks!



signature.asc
Description: PGP signature

Re: [PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock

[Stefan Wahren]

Hi Eric,

> Eric Anholt  hat am 19. Februar 2016 um 02:12 geschrieben:
>
>
> Fixes dmesg spam when we just need to wait a moment for the clock
> driver to probe.
>
> Signed-off-by: Eric Anholt 
> ---
> drivers/i2c/busses/i2c-bcm2835.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-bcm2835.c
> b/drivers/i2c/busses/i2c-bcm2835.c
> index 818b051..d4f3239 100644
> --- a/drivers/i2c/busses/i2c-bcm2835.c
> +++ b/drivers/i2c/busses/i2c-bcm2835.c
> @@ -253,7 +253,8 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
>
> i2c_dev->clk = devm_clk_get(>dev, NULL);
> if (IS_ERR(i2c_dev->clk)) {
> - dev_err(>dev, "Could not get clock\n");
> + if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
> + dev_err(>dev, "Could not get clock\n");

i know it's something different, but how about printing the error code here?

Regards
Stefan

> return PTR_ERR(i2c_dev->clk);
> }
>
> --
> 2.7.0
>
>
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock

[Stefan Wahren]

Hi Eric,

> Eric Anholt  hat am 19. Februar 2016 um 02:12 geschrieben:
>
>
> Fixes dmesg spam when we just need to wait a moment for the clock
> driver to probe.
>
> Signed-off-by: Eric Anholt 
> ---
> drivers/i2c/busses/i2c-bcm2835.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-bcm2835.c
> b/drivers/i2c/busses/i2c-bcm2835.c
> index 818b051..d4f3239 100644
> --- a/drivers/i2c/busses/i2c-bcm2835.c
> +++ b/drivers/i2c/busses/i2c-bcm2835.c
> @@ -253,7 +253,8 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
>
> i2c_dev->clk = devm_clk_get(>dev, NULL);
> if (IS_ERR(i2c_dev->clk)) {
> - dev_err(>dev, "Could not get clock\n");
> + if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
> + dev_err(>dev, "Could not get clock\n");

i know it's something different, but how about printing the error code here?

Regards
Stefan

> return PTR_ERR(i2c_dev->clk);
> }
>
> --
> 2.7.0
>
>
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock

[Eric Anholt]

Fixes dmesg spam when we just need to wait a moment for the clock
driver to probe.

Signed-off-by: Eric Anholt 
---
 drivers/i2c/busses/i2c-bcm2835.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 818b051..d4f3239 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -253,7 +253,8 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
 
i2c_dev->clk = devm_clk_get(>dev, NULL);
if (IS_ERR(i2c_dev->clk)) {
-   dev_err(>dev, "Could not get clock\n");
+   if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
+   dev_err(>dev, "Could not get clock\n");
return PTR_ERR(i2c_dev->clk);
}
 
-- 
2.7.0

[PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock

[Eric Anholt]

Fixes dmesg spam when we just need to wait a moment for the clock
driver to probe.

Signed-off-by: Eric Anholt 
---
 drivers/i2c/busses/i2c-bcm2835.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 818b051..d4f3239 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -253,7 +253,8 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
 
i2c_dev->clk = devm_clk_get(>dev, NULL);
if (IS_ERR(i2c_dev->clk)) {
-   dev_err(>dev, "Could not get clock\n");
+   if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
+   dev_err(>dev, "Could not get clock\n");
return PTR_ERR(i2c_dev->clk);
}
 
-- 
2.7.0