Re: [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula

2019-03-12 Thread Wolfram Sang 

> > Do you have a Fixes tag for this?
> > 
> 
> Fixes: aeb068c57214858b638d5ee627bb4a831f98771e ("i2c: i2c-stm32f7: add 
> driver")
> 
> Will you change the commit message or do you want me to resend the patch?

I'll fix it. Thanks for this info!



signature.asc
Description: PGP signature

Re: [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula

2019-03-11 Thread Bich HEMON 
On 3/9/19 11:50 AM, Wolfram Sang wrote:
> On Sat, Mar 09, 2019 at 11:13:40AM +0100, Wolfram Sang wrote:
>> On Wed, Mar 06, 2019 at 03:12:16PM +, Bich HEMON wrote:
>>> From: Nicolas Le Bayon 
>>>
>>> It conforms with Reference Manual I2C timing section.
>>>
>>> Signed-off-by: Nicolas Le Bayon 
>>> Signed-off-by: Bich Hemon 
>>
>> Applied to for-current, thanks!
> 
> Do you have a Fixes tag for this?
> 
Hi Wolfram,

Fixes: aeb068c57214858b638d5ee627bb4a831f98771e ("i2c: i2c-stm32f7: add 
driver")

Will you change the commit message or do you want me to resend the patch?

BR,

Bich

Re: [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula

2019-03-09 Thread Wolfram Sang 
On Sat, Mar 09, 2019 at 11:13:40AM +0100, Wolfram Sang wrote:
> On Wed, Mar 06, 2019 at 03:12:16PM +, Bich HEMON wrote:
> > From: Nicolas Le Bayon 
> > 
> > It conforms with Reference Manual I2C timing section.
> > 
> > Signed-off-by: Nicolas Le Bayon 
> > Signed-off-by: Bich Hemon 
> 
> Applied to for-current, thanks!

Do you have a Fixes tag for this?



signature.asc
Description: PGP signature

Re: [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula

2019-03-09 Thread Wolfram Sang 
On Wed, Mar 06, 2019 at 03:12:16PM +, Bich HEMON wrote:
> From: Nicolas Le Bayon 
> 
> It conforms with Reference Manual I2C timing section.
> 
> Signed-off-by: Nicolas Le Bayon 
> Signed-off-by: Bich Hemon 

Applied to for-current, thanks!



signature.asc
Description: PGP signature

Re: [PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula

2019-03-07 Thread Pierre Yves MORDRET 
Hi

Reviewed-by: Pierre-Yves MORDRET 

Thanks

On 3/6/19 4:12 PM, Bich HEMON wrote:
> From: Nicolas Le Bayon 
> 
> It conforms with Reference Manual I2C timing section.
> 
> Signed-off-by: Nicolas Le Bayon 
> Signed-off-by: Bich Hemon 
> ---
>  drivers/i2c/busses/i2c-stm32f7.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c 
> b/drivers/i2c/busses/i2c-stm32f7.c
> index 13e1213..4284fc9 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -432,7 +432,7 @@ static int stm32f7_i2c_compute_timing(struct 
> stm32f7_i2c_dev *i2c_dev,
>STM32F7_I2C_ANALOG_FILTER_DELAY_MAX : 0);
>   dnf_delay = setup->dnf * i2cclk;
>  
> - sdadel_min = setup->fall_time - i2c_specs[setup->speed].hddat_min -
> + sdadel_min = i2c_specs[setup->speed].hddat_min + setup->fall_time -
>   af_delay_min - (setup->dnf + 3) * i2cclk;
>  
>   sdadel_max = i2c_specs[setup->speed].vddat_max - setup->rise_time -
>

[PATCH] i2c: i2c-stm32f7: Fix SDADEL minimum formula

2019-03-06 Thread Bich HEMON 
From: Nicolas Le Bayon 

It conforms with Reference Manual I2C timing section.

Signed-off-by: Nicolas Le Bayon 
Signed-off-by: Bich Hemon 
---
 drivers/i2c/busses/i2c-stm32f7.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index 13e1213..4284fc9 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -432,7 +432,7 @@ static int stm32f7_i2c_compute_timing(struct 
stm32f7_i2c_dev *i2c_dev,
 STM32F7_I2C_ANALOG_FILTER_DELAY_MAX : 0);
dnf_delay = setup->dnf * i2cclk;
 
-   sdadel_min = setup->fall_time - i2c_specs[setup->speed].hddat_min -
+   sdadel_min = i2c_specs[setup->speed].hddat_min + setup->fall_time -
af_delay_min - (setup->dnf + 3) * i2cclk;
 
sdadel_max = i2c_specs[setup->speed].vddat_max - setup->rise_time -
-- 
1.9.1