Re: [PATCH] i2c: iproc: Fix checkpatch warnings by using 'BIT' macro

[Wolfram Sang]

On Fri, Aug 14, 2020 at 03:40:08PM -0700, Ray Jui wrote:
> Fix additional checkpatch warnings in the iProc I2C driver by using
> 'BIT' marcro.
> 
> Reported-by: Wolfram Sang 
> Signed-off-by: Ray Jui 

Changed the commit msg a little. This is not about 'checkpatch', this is
about fixing undefined C behaviour.

Applied to for-current, thanks!



signature.asc
Description: PGP signature

Re: [PATCH] i2c: iproc: Fix checkpatch warnings by using 'BIT' macro

[Florian Fainelli]

On 8/14/2020 3:40 PM, Ray Jui wrote:

Fix additional checkpatch warnings in the iProc I2C driver by using
'BIT' marcro.

Reported-by: Wolfram Sang 
Signed-off-by: Ray Jui 


Acked-by: Florian Fainelli 
--
Florian

[PATCH] i2c: iproc: Fix checkpatch warnings by using 'BIT' macro

[Ray Jui]

Fix additional checkpatch warnings in the iProc I2C driver by using
'BIT' marcro.

Reported-by: Wolfram Sang 
Signed-off-by: Ray Jui 
---
 drivers/i2c/busses/i2c-bcm-iproc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c 
b/drivers/i2c/busses/i2c-bcm-iproc.c
index 688e92818821..d8295b1c379d 100644
--- a/drivers/i2c/busses/i2c-bcm-iproc.c
+++ b/drivers/i2c/busses/i2c-bcm-iproc.c
@@ -720,7 +720,7 @@ static int bcm_iproc_i2c_xfer_internal(struct 
bcm_iproc_i2c_dev *iproc_i2c,
 
/* mark the last byte */
if (!process_call && (i == msg->len - 1))
-   val |= 1 << M_TX_WR_STATUS_SHIFT;
+   val |= BIT(M_TX_WR_STATUS_SHIFT);
 
iproc_i2c_wr_reg(iproc_i2c, M_TX_OFFSET, val);
}
@@ -738,7 +738,7 @@ static int bcm_iproc_i2c_xfer_internal(struct 
bcm_iproc_i2c_dev *iproc_i2c,
 */
addr = i2c_8bit_addr_from_msg(msg);
/* mark it the last byte out */
-   val = addr | (1 << M_TX_WR_STATUS_SHIFT);
+   val = addr | BIT(M_TX_WR_STATUS_SHIFT);
iproc_i2c_wr_reg(iproc_i2c, M_TX_OFFSET, val);
}
 
-- 
2.17.1