Re: [PATCH] i2o: defined but not used.
Hi, On Saturday 21 July 2007, Andrew Morton wrote: > On Sat, 21 Jul 2007 00:58:01 +0200 Sebastian Siewior <[EMAIL PROTECTED]> wrote: > > Got with randconfig > > randconfig apparently generates impossible configs. Please always > run `make oldconfig' after the randconfig, then do the test build. If that should make any difference, that would be a bug and I'd like to see that .config. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] i2o: defined but not used.
On Sat, 21 Jul 2007 03:31:33 -0700 Andrew Morton wrote: > On Sat, 21 Jul 2007 00:58:01 +0200 Sebastian Siewior <[EMAIL PROTECTED]> > wrote: > > > Got with randconfig > > randconfig apparently generates impossible configs. Please always > run `make oldconfig' after the randconfig, then do the test build. This one is not impossible. Patch looks good. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] i2o: defined but not used.
* Andrew Morton | 2007-07-21 03:31:33 [-0700]: >On Sat, 21 Jul 2007 00:58:01 +0200 Sebastian Siewior <[EMAIL PROTECTED]> wrote: > >> Got with randconfig > >randconfig apparently generates impossible configs. Please always >run `make oldconfig' after the randconfig, then do the test build. Ah okey, I did not know this. CONFIG_I2O=y # CONFIG_I2O_LCT_NOTIFY_ON_CHANGES is not set Is still in my .config after oldconfig. Sebastian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] i2o: defined but not used.
On Sat, 21 Jul 2007 00:58:01 +0200 Sebastian Siewior <[EMAIL PROTECTED]> wrote: > Got with randconfig randconfig apparently generates impossible configs. Please always run `make oldconfig' after the randconfig, then do the test build. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] i2o: defined but not used.
Got with randconfig drivers/message/i2o/exec-osm.c:539: warning: 'i2o_exec_lct_notify' defined but not used Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]> Index: b/drivers/message/i2o/exec-osm.c === --- a/drivers/message/i2o/exec-osm.c +++ b/drivers/message/i2o/exec-osm.c @@ -389,9 +389,7 @@ static void i2o_exec_lct_modified(struct if (i2o_device_parse_lct(c) != -EAGAIN) change_ind = c->lct->change_ind + 1; -#ifdef CONFIG_I2O_LCT_NOTIFY_ON_CHANGES i2o_exec_lct_notify(c, change_ind); -#endif }; /** @@ -525,6 +523,7 @@ int i2o_exec_lct_get(struct i2o_controll return rc; } +#ifdef CONFIG_I2O_LCT_NOTIFY_ON_CHANGES /** * i2o_exec_lct_notify - Send a asynchronus LCT NOTIFY request * @c: I2O controller to which the request should be send @@ -570,6 +569,13 @@ static int i2o_exec_lct_notify(struct i2 return 0; }; +#else +static int i2o_exec_lct_notify(struct i2o_controller *c, u32 change_ind) +{ + return 0; +} +#endif + /* Exec OSM driver struct */ struct i2o_driver i2o_exec_driver = { .name = OSM_NAME, -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/