Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
On Wed, Nov 14, 2018 at 5:13 PM Loic WEI YU NENG wrote:
>
> Some Lenovo ideapad models lack a physical rfkill switch.
> On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
> radios as blocked by hardware which caused wireless network connections
> to fail.
> Add these models without an rfkill switch to the no_hw_rfkill list.
>
Pushed to my review and testing queue, thanks
> Signed-off-by: Loic WEI YU NENG
> ---
> drivers/platform/x86/ideapad-laptop.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c
> b/drivers/platform/x86/ideapad-laptop.c
> index b6489cba2985..1589dffab9fa 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1188,6 +1188,13 @@ static const struct dmi_system_id no_hw_rfkill_list[]
> = {
> DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
> },
> },
> + {
> + .ident = "Lenovo Yoga 2 13",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
> + },
> + },
> {
> .ident = "Lenovo Yoga 3 1170 / 1470",
> .matches = {
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
On Wed, Nov 14, 2018 at 5:13 PM Loic WEI YU NENG wrote:
>
> Some Lenovo ideapad models lack a physical rfkill switch.
> On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
> radios as blocked by hardware which caused wireless network connections
> to fail.
> Add these models without an rfkill switch to the no_hw_rfkill list.
>
Pushed to my review and testing queue, thanks
> Signed-off-by: Loic WEI YU NENG
> ---
> drivers/platform/x86/ideapad-laptop.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c
> b/drivers/platform/x86/ideapad-laptop.c
> index b6489cba2985..1589dffab9fa 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1188,6 +1188,13 @@ static const struct dmi_system_id no_hw_rfkill_list[]
> = {
> DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
> },
> },
> + {
> + .ident = "Lenovo Yoga 2 13",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
> + },
> + },
> {
> .ident = "Lenovo Yoga 3 1170 / 1470",
> .matches = {
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
Sounds good,
I can me my patch here now:
https://patchwork.kernel.org/patch/10682745/
Loic
On Wed, Nov 14, 2018 at 2:52 AM Andy Shevchenko
wrote:
>
> On Wed, Nov 14, 2018 at 9:48 AM Loic Wei-Yu-Neng wrote:
> >
> > Hello Darren,
> > Yes, the current driver fails to match match my laptop. I need to add this
> > patch to have wifi functional on my laptop.
> > Here is the dmidecode snippet from my laptop:
> >
> > Handle 0x0001, DMI type 1, 27 bytes
> > System Information
> > Manufacturer: LENOVO
> > Product Name: 20344
> > Version: Yoga 2 13
> > Serial Number: 3438666500284
> > UUID: 933A1748-ACE0-E311-A534-F8A9633129FA
> > Wake-up Type: Power Switch
> > SKU Number: LENOVO_MT_20344_BU_idea_FM_Yoga 2 13
> > Family: IDEAPAD
> >
>
> Yeah, it has slightly different Version string in your case.
>
> Since patchwork (*) still didn't catch your patch you need to resend
> with all maintainers and mailing lists included like Darren suggested.
>
> (*) patchwork is a database which is tracking patches and patch series
> that are communicated thru mailing lists. It makes maintainer's life
> easier and allow to keep a trail of what has been done and when.
> The web interface to our project is here
> https://patchwork.kernel.org/project/platform-driver-x86/list/
>
>
> > Loic
> >
> > On Tue, Nov 13, 2018 at 9:16 PM Darren Hart wrote:
> >>
> >> On Tue, Nov 13, 2018 at 06:22:45PM -0800, Loic WEI YU NENG wrote:
> >> > Some Lenovo ideapad models lack a physical rfkill switch.
> >> > On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
> >> > radios as blocked by hardware which caused wireless network connections
> >> > to fail.
> >> > Add these models without an rfkill switch to the no_hw_rfkill list.
> >> >
> >> > Signed-off-by: Loic WEI YU NENG
> >>
> >> Thank you for the patch.
> >>
> >> In the future, please be sure to check MAINTAINERS and include the
> >> relevant lists, now Cc'd.
> >>
> >> I see this in the context of your patch, but can you confirm the current
> >> driver fails to match your system? It contains the following, which I
> >> would expect to match:
> >>
> >>.ident = "Lenovo Yoga 2 11 / 13 / Pro",
> >> .matches = {
> >> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> >> DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
> >> },
> >>
> >> If it doesn't match, what does dmidecode report for SYS_VENDOR and
> >> BOARD_NAME on your system? Perhaps we need to make the above more
> >> generic.
> >>
> >> > ---
> >> > drivers/platform/x86/ideapad-laptop.c | 7 +++
> >> > 1 file changed, 7 insertions(+)
> >> >
> >> > diff --git a/drivers/platform/x86/ideapad-laptop.c
> >> > b/drivers/platform/x86/ideapad-laptop.c
> >> > index b6489cba2985..1589dffab9fa 100644
> >> > --- a/drivers/platform/x86/ideapad-laptop.c
> >> > +++ b/drivers/platform/x86/ideapad-laptop.c
> >> > @@ -1188,6 +1188,13 @@ static const struct dmi_system_id
> >> > no_hw_rfkill_list[] = {
> >> > DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
> >> > },
> >> > },
> >> > + {
> >> > + .ident = "Lenovo Yoga 2 13",
> >> > + .matches = {
> >> > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> >> > + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
> >> > + },
> >> > + },
> >> > {
> >> > .ident = "Lenovo Yoga 3 1170 / 1470",
> >> > .matches = {
> >> > --
> >> > 2.17.1
> >> >
> >> >
> >>
> >> --
> >> Darren Hart
> >> VMware Open Source Technology Center
> >
> >
> >
> > --
> > Loic WEI YU NENG
> > US phone: +1 408 218 2826
> > FR phone: +33 674201069
> > email: loic@gmail.com
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
--
Loic WEI YU NENG
US phone: +1 408 218 2826
FR phone: +33 674201069
email: loic@gmail.com
Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
Sounds good,
I can me my patch here now:
https://patchwork.kernel.org/patch/10682745/
Loic
On Wed, Nov 14, 2018 at 2:52 AM Andy Shevchenko
wrote:
>
> On Wed, Nov 14, 2018 at 9:48 AM Loic Wei-Yu-Neng wrote:
> >
> > Hello Darren,
> > Yes, the current driver fails to match match my laptop. I need to add this
> > patch to have wifi functional on my laptop.
> > Here is the dmidecode snippet from my laptop:
> >
> > Handle 0x0001, DMI type 1, 27 bytes
> > System Information
> > Manufacturer: LENOVO
> > Product Name: 20344
> > Version: Yoga 2 13
> > Serial Number: 3438666500284
> > UUID: 933A1748-ACE0-E311-A534-F8A9633129FA
> > Wake-up Type: Power Switch
> > SKU Number: LENOVO_MT_20344_BU_idea_FM_Yoga 2 13
> > Family: IDEAPAD
> >
>
> Yeah, it has slightly different Version string in your case.
>
> Since patchwork (*) still didn't catch your patch you need to resend
> with all maintainers and mailing lists included like Darren suggested.
>
> (*) patchwork is a database which is tracking patches and patch series
> that are communicated thru mailing lists. It makes maintainer's life
> easier and allow to keep a trail of what has been done and when.
> The web interface to our project is here
> https://patchwork.kernel.org/project/platform-driver-x86/list/
>
>
> > Loic
> >
> > On Tue, Nov 13, 2018 at 9:16 PM Darren Hart wrote:
> >>
> >> On Tue, Nov 13, 2018 at 06:22:45PM -0800, Loic WEI YU NENG wrote:
> >> > Some Lenovo ideapad models lack a physical rfkill switch.
> >> > On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
> >> > radios as blocked by hardware which caused wireless network connections
> >> > to fail.
> >> > Add these models without an rfkill switch to the no_hw_rfkill list.
> >> >
> >> > Signed-off-by: Loic WEI YU NENG
> >>
> >> Thank you for the patch.
> >>
> >> In the future, please be sure to check MAINTAINERS and include the
> >> relevant lists, now Cc'd.
> >>
> >> I see this in the context of your patch, but can you confirm the current
> >> driver fails to match your system? It contains the following, which I
> >> would expect to match:
> >>
> >>.ident = "Lenovo Yoga 2 11 / 13 / Pro",
> >> .matches = {
> >> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> >> DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
> >> },
> >>
> >> If it doesn't match, what does dmidecode report for SYS_VENDOR and
> >> BOARD_NAME on your system? Perhaps we need to make the above more
> >> generic.
> >>
> >> > ---
> >> > drivers/platform/x86/ideapad-laptop.c | 7 +++
> >> > 1 file changed, 7 insertions(+)
> >> >
> >> > diff --git a/drivers/platform/x86/ideapad-laptop.c
> >> > b/drivers/platform/x86/ideapad-laptop.c
> >> > index b6489cba2985..1589dffab9fa 100644
> >> > --- a/drivers/platform/x86/ideapad-laptop.c
> >> > +++ b/drivers/platform/x86/ideapad-laptop.c
> >> > @@ -1188,6 +1188,13 @@ static const struct dmi_system_id
> >> > no_hw_rfkill_list[] = {
> >> > DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
> >> > },
> >> > },
> >> > + {
> >> > + .ident = "Lenovo Yoga 2 13",
> >> > + .matches = {
> >> > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> >> > + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
> >> > + },
> >> > + },
> >> > {
> >> > .ident = "Lenovo Yoga 3 1170 / 1470",
> >> > .matches = {
> >> > --
> >> > 2.17.1
> >> >
> >> >
> >>
> >> --
> >> Darren Hart
> >> VMware Open Source Technology Center
> >
> >
> >
> > --
> > Loic WEI YU NENG
> > US phone: +1 408 218 2826
> > FR phone: +33 674201069
> > email: loic@gmail.com
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
--
Loic WEI YU NENG
US phone: +1 408 218 2826
FR phone: +33 674201069
email: loic@gmail.com
[PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
radios as blocked by hardware which caused wireless network connections
to fail.
Add these models without an rfkill switch to the no_hw_rfkill list.
Signed-off-by: Loic WEI YU NENG
---
drivers/platform/x86/ideapad-laptop.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/platform/x86/ideapad-laptop.c
b/drivers/platform/x86/ideapad-laptop.c
index b6489cba2985..1589dffab9fa 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -1188,6 +1188,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
},
},
+ {
+ .ident = "Lenovo Yoga 2 13",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
+ },
+ },
{
.ident = "Lenovo Yoga 3 1170 / 1470",
.matches = {
--
2.17.1
[PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
radios as blocked by hardware which caused wireless network connections
to fail.
Add these models without an rfkill switch to the no_hw_rfkill list.
Signed-off-by: Loic WEI YU NENG
---
drivers/platform/x86/ideapad-laptop.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/platform/x86/ideapad-laptop.c
b/drivers/platform/x86/ideapad-laptop.c
index b6489cba2985..1589dffab9fa 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -1188,6 +1188,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
},
},
+ {
+ .ident = "Lenovo Yoga 2 13",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
+ },
+ },
{
.ident = "Lenovo Yoga 3 1170 / 1470",
.matches = {
--
2.17.1
Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
On Wed, Nov 14, 2018 at 9:48 AM Loic Wei-Yu-Neng wrote:
>
> Hello Darren,
> Yes, the current driver fails to match match my laptop. I need to add this
> patch to have wifi functional on my laptop.
> Here is the dmidecode snippet from my laptop:
>
> Handle 0x0001, DMI type 1, 27 bytes
> System Information
> Manufacturer: LENOVO
> Product Name: 20344
> Version: Yoga 2 13
> Serial Number: 3438666500284
> UUID: 933A1748-ACE0-E311-A534-F8A9633129FA
> Wake-up Type: Power Switch
> SKU Number: LENOVO_MT_20344_BU_idea_FM_Yoga 2 13
> Family: IDEAPAD
>
Yeah, it has slightly different Version string in your case.
Since patchwork (*) still didn't catch your patch you need to resend
with all maintainers and mailing lists included like Darren suggested.
(*) patchwork is a database which is tracking patches and patch series
that are communicated thru mailing lists. It makes maintainer's life
easier and allow to keep a trail of what has been done and when.
The web interface to our project is here
https://patchwork.kernel.org/project/platform-driver-x86/list/
> Loic
>
> On Tue, Nov 13, 2018 at 9:16 PM Darren Hart wrote:
>>
>> On Tue, Nov 13, 2018 at 06:22:45PM -0800, Loic WEI YU NENG wrote:
>> > Some Lenovo ideapad models lack a physical rfkill switch.
>> > On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
>> > radios as blocked by hardware which caused wireless network connections
>> > to fail.
>> > Add these models without an rfkill switch to the no_hw_rfkill list.
>> >
>> > Signed-off-by: Loic WEI YU NENG
>>
>> Thank you for the patch.
>>
>> In the future, please be sure to check MAINTAINERS and include the
>> relevant lists, now Cc'd.
>>
>> I see this in the context of your patch, but can you confirm the current
>> driver fails to match your system? It contains the following, which I
>> would expect to match:
>>
>>.ident = "Lenovo Yoga 2 11 / 13 / Pro",
>> .matches = {
>> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
>> },
>>
>> If it doesn't match, what does dmidecode report for SYS_VENDOR and
>> BOARD_NAME on your system? Perhaps we need to make the above more
>> generic.
>>
>> > ---
>> > drivers/platform/x86/ideapad-laptop.c | 7 +++
>> > 1 file changed, 7 insertions(+)
>> >
>> > diff --git a/drivers/platform/x86/ideapad-laptop.c
>> > b/drivers/platform/x86/ideapad-laptop.c
>> > index b6489cba2985..1589dffab9fa 100644
>> > --- a/drivers/platform/x86/ideapad-laptop.c
>> > +++ b/drivers/platform/x86/ideapad-laptop.c
>> > @@ -1188,6 +1188,13 @@ static const struct dmi_system_id
>> > no_hw_rfkill_list[] = {
>> > DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
>> > },
>> > },
>> > + {
>> > + .ident = "Lenovo Yoga 2 13",
>> > + .matches = {
>> > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> > + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
>> > + },
>> > + },
>> > {
>> > .ident = "Lenovo Yoga 3 1170 / 1470",
>> > .matches = {
>> > --
>> > 2.17.1
>> >
>> >
>>
>> --
>> Darren Hart
>> VMware Open Source Technology Center
>
>
>
> --
> Loic WEI YU NENG
> US phone: +1 408 218 2826
> FR phone: +33 674201069
> email: loic@gmail.com
--
With Best Regards,
Andy Shevchenko
Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
On Wed, Nov 14, 2018 at 9:48 AM Loic Wei-Yu-Neng wrote:
>
> Hello Darren,
> Yes, the current driver fails to match match my laptop. I need to add this
> patch to have wifi functional on my laptop.
> Here is the dmidecode snippet from my laptop:
>
> Handle 0x0001, DMI type 1, 27 bytes
> System Information
> Manufacturer: LENOVO
> Product Name: 20344
> Version: Yoga 2 13
> Serial Number: 3438666500284
> UUID: 933A1748-ACE0-E311-A534-F8A9633129FA
> Wake-up Type: Power Switch
> SKU Number: LENOVO_MT_20344_BU_idea_FM_Yoga 2 13
> Family: IDEAPAD
>
Yeah, it has slightly different Version string in your case.
Since patchwork (*) still didn't catch your patch you need to resend
with all maintainers and mailing lists included like Darren suggested.
(*) patchwork is a database which is tracking patches and patch series
that are communicated thru mailing lists. It makes maintainer's life
easier and allow to keep a trail of what has been done and when.
The web interface to our project is here
https://patchwork.kernel.org/project/platform-driver-x86/list/
> Loic
>
> On Tue, Nov 13, 2018 at 9:16 PM Darren Hart wrote:
>>
>> On Tue, Nov 13, 2018 at 06:22:45PM -0800, Loic WEI YU NENG wrote:
>> > Some Lenovo ideapad models lack a physical rfkill switch.
>> > On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
>> > radios as blocked by hardware which caused wireless network connections
>> > to fail.
>> > Add these models without an rfkill switch to the no_hw_rfkill list.
>> >
>> > Signed-off-by: Loic WEI YU NENG
>>
>> Thank you for the patch.
>>
>> In the future, please be sure to check MAINTAINERS and include the
>> relevant lists, now Cc'd.
>>
>> I see this in the context of your patch, but can you confirm the current
>> driver fails to match your system? It contains the following, which I
>> would expect to match:
>>
>>.ident = "Lenovo Yoga 2 11 / 13 / Pro",
>> .matches = {
>> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
>> },
>>
>> If it doesn't match, what does dmidecode report for SYS_VENDOR and
>> BOARD_NAME on your system? Perhaps we need to make the above more
>> generic.
>>
>> > ---
>> > drivers/platform/x86/ideapad-laptop.c | 7 +++
>> > 1 file changed, 7 insertions(+)
>> >
>> > diff --git a/drivers/platform/x86/ideapad-laptop.c
>> > b/drivers/platform/x86/ideapad-laptop.c
>> > index b6489cba2985..1589dffab9fa 100644
>> > --- a/drivers/platform/x86/ideapad-laptop.c
>> > +++ b/drivers/platform/x86/ideapad-laptop.c
>> > @@ -1188,6 +1188,13 @@ static const struct dmi_system_id
>> > no_hw_rfkill_list[] = {
>> > DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
>> > },
>> > },
>> > + {
>> > + .ident = "Lenovo Yoga 2 13",
>> > + .matches = {
>> > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> > + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
>> > + },
>> > + },
>> > {
>> > .ident = "Lenovo Yoga 3 1170 / 1470",
>> > .matches = {
>> > --
>> > 2.17.1
>> >
>> >
>>
>> --
>> Darren Hart
>> VMware Open Source Technology Center
>
>
>
> --
> Loic WEI YU NENG
> US phone: +1 408 218 2826
> FR phone: +33 674201069
> email: loic@gmail.com
--
With Best Regards,
Andy Shevchenko
Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
On Tue, Nov 13, 2018 at 06:22:45PM -0800, Loic WEI YU NENG wrote:
> Some Lenovo ideapad models lack a physical rfkill switch.
> On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
> radios as blocked by hardware which caused wireless network connections
> to fail.
> Add these models without an rfkill switch to the no_hw_rfkill list.
>
> Signed-off-by: Loic WEI YU NENG
Thank you for the patch.
In the future, please be sure to check MAINTAINERS and include the
relevant lists, now Cc'd.
I see this in the context of your patch, but can you confirm the current
driver fails to match your system? It contains the following, which I
would expect to match:
.ident = "Lenovo Yoga 2 11 / 13 / Pro",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
},
If it doesn't match, what does dmidecode report for SYS_VENDOR and
BOARD_NAME on your system? Perhaps we need to make the above more
generic.
> ---
> drivers/platform/x86/ideapad-laptop.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c
> b/drivers/platform/x86/ideapad-laptop.c
> index b6489cba2985..1589dffab9fa 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1188,6 +1188,13 @@ static const struct dmi_system_id no_hw_rfkill_list[]
> = {
> DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
> },
> },
> + {
> + .ident = "Lenovo Yoga 2 13",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
> + },
> + },
> {
> .ident = "Lenovo Yoga 3 1170 / 1470",
> .matches = {
> --
> 2.17.1
>
>
--
Darren Hart
VMware Open Source Technology Center
Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
On Tue, Nov 13, 2018 at 06:22:45PM -0800, Loic WEI YU NENG wrote:
> Some Lenovo ideapad models lack a physical rfkill switch.
> On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
> radios as blocked by hardware which caused wireless network connections
> to fail.
> Add these models without an rfkill switch to the no_hw_rfkill list.
>
> Signed-off-by: Loic WEI YU NENG
Thank you for the patch.
In the future, please be sure to check MAINTAINERS and include the
relevant lists, now Cc'd.
I see this in the context of your patch, but can you confirm the current
driver fails to match your system? It contains the following, which I
would expect to match:
.ident = "Lenovo Yoga 2 11 / 13 / Pro",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
},
If it doesn't match, what does dmidecode report for SYS_VENDOR and
BOARD_NAME on your system? Perhaps we need to make the above more
generic.
> ---
> drivers/platform/x86/ideapad-laptop.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c
> b/drivers/platform/x86/ideapad-laptop.c
> index b6489cba2985..1589dffab9fa 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1188,6 +1188,13 @@ static const struct dmi_system_id no_hw_rfkill_list[]
> = {
> DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
> },
> },
> + {
> + .ident = "Lenovo Yoga 2 13",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
> + },
> + },
> {
> .ident = "Lenovo Yoga 3 1170 / 1470",
> .matches = {
> --
> 2.17.1
>
>
--
Darren Hart
VMware Open Source Technology Center
Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
+Cc: mailing lists
On Tue, Nov 13, 2018 at 5:21 AM Loic Wei-Yu-Neng wrote:
> Here you go,
> I attached my patch.
Thanks, though in a kernel we have not using attachments. Moreover,
since you forgot to include mailing lists the patchwork doesn't catch
this either.
Can you send it in a regular way, i.e. using `git format-patch ... &&
git send-email ...` ?
> I rebased it on top of today's latest:
> * 7946462d31a0 (HEAD -> test) ideapad-laptop: Add Lenovo Yoga 2 13 to the
> no_hw_rfkill DMI list
> * ccda4af0f4b9 (tag: v4.20-rc2, origin/master, origin/HEAD) Linux 4.20-rc2
> * 7a3765ed66d1 Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
> |\
> | * 7236ead1b149 act_mirred: clear skb->tstamp on redirect
> | * a9049ff9214d net: dsa: mv88e6xxx: Fix clearing of stats counters
> | * 7ab412d33b4c tipc: fix link re-establish failure
> | * 63c82997f5c0 net: sched: cls_flower: validate nested enc_opts_policy to
> avoid warning
> | * fbd1d5245372 net: mvneta: correct typo
> | * 62230715fd24 flow_dissector: do not dissect l4 ports for fragments
> | * d02854dc1999 net: qualcomm: rmnet: Fix incorrect assignment of real_dev
>
> Loic
>
> On Fri, Oct 19, 2018 at 7:10 AM Loic Wei-Yu-Neng wrote:
>>
>> Hello Andy,
>> Sure let me do that.
>> Loic
>>
>> On Fri, Oct 19, 2018, 4:29 AM Andy Shevchenko > wrote:
>>>
>>> On Wed, May 16, 2018 at 4:18 AM Loic WEI YU NENG wrote:
>>> >
>>> > Some Lenovo ideapad models lack a physical rfkill switch.
>>> > On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
>>> > radios as blocked by hardware which caused wireless network connections
>>> > to fail.
>>> > Add these models without an rfkill switch to the no_hw_rfkill list.
>>> >
>>>
>>> I'm very sorry, but by some unclear reason this patch is missed in the
>>> tree and in our patchwork.
>>> Does it still actual?
>>>
>>> May you resend it rebased on top of our for-next branch?
>>>
>>> > Signed-off-by: Loic WEI YU NENG
>>> > ---
>>> > drivers/platform/x86/ideapad-laptop.c | 7 +++
>>> > 1 file changed, 7 insertions(+)
>>> >
>>> > diff --git a/drivers/platform/x86/ideapad-laptop.c
>>> > b/drivers/platform/x86/ideapad-laptop.c
>>> > index 535199c9e6bc..0a843c4ca4fc 100644
>>> > --- a/drivers/platform/x86/ideapad-laptop.c
>>> > +++ b/drivers/platform/x86/ideapad-laptop.c
>>> > @@ -1114,6 +1114,13 @@ static const struct dmi_system_id
>>> > no_hw_rfkill_list[] = {
>>> > DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
>>> > },
>>> > },
>>> > + {
>>> > + .ident = "Lenovo Yoga 2 13",
>>> > + .matches = {
>>> > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>>> > + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
>>> > + },
>>> > + },
>>> > {
>>> > .ident = "Lenovo Yoga 3 1170 / 1470",
>>> > .matches = {
>>> > --
>>> > 2.17.0
>>> >
>>>
>>>
>>> --
>>> With Best Regards,
>>> Andy Shevchenko
>
>
>
> --
> Loic WEI YU NENG
> US phone: +1 408 218 2826
> FR phone: +33 674201069
> email: loic@gmail.com
--
With Best Regards,
Andy Shevchenko
Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
+Cc: mailing lists
On Tue, Nov 13, 2018 at 5:21 AM Loic Wei-Yu-Neng wrote:
> Here you go,
> I attached my patch.
Thanks, though in a kernel we have not using attachments. Moreover,
since you forgot to include mailing lists the patchwork doesn't catch
this either.
Can you send it in a regular way, i.e. using `git format-patch ... &&
git send-email ...` ?
> I rebased it on top of today's latest:
> * 7946462d31a0 (HEAD -> test) ideapad-laptop: Add Lenovo Yoga 2 13 to the
> no_hw_rfkill DMI list
> * ccda4af0f4b9 (tag: v4.20-rc2, origin/master, origin/HEAD) Linux 4.20-rc2
> * 7a3765ed66d1 Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
> |\
> | * 7236ead1b149 act_mirred: clear skb->tstamp on redirect
> | * a9049ff9214d net: dsa: mv88e6xxx: Fix clearing of stats counters
> | * 7ab412d33b4c tipc: fix link re-establish failure
> | * 63c82997f5c0 net: sched: cls_flower: validate nested enc_opts_policy to
> avoid warning
> | * fbd1d5245372 net: mvneta: correct typo
> | * 62230715fd24 flow_dissector: do not dissect l4 ports for fragments
> | * d02854dc1999 net: qualcomm: rmnet: Fix incorrect assignment of real_dev
>
> Loic
>
> On Fri, Oct 19, 2018 at 7:10 AM Loic Wei-Yu-Neng wrote:
>>
>> Hello Andy,
>> Sure let me do that.
>> Loic
>>
>> On Fri, Oct 19, 2018, 4:29 AM Andy Shevchenko > wrote:
>>>
>>> On Wed, May 16, 2018 at 4:18 AM Loic WEI YU NENG wrote:
>>> >
>>> > Some Lenovo ideapad models lack a physical rfkill switch.
>>> > On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all
>>> > radios as blocked by hardware which caused wireless network connections
>>> > to fail.
>>> > Add these models without an rfkill switch to the no_hw_rfkill list.
>>> >
>>>
>>> I'm very sorry, but by some unclear reason this patch is missed in the
>>> tree and in our patchwork.
>>> Does it still actual?
>>>
>>> May you resend it rebased on top of our for-next branch?
>>>
>>> > Signed-off-by: Loic WEI YU NENG
>>> > ---
>>> > drivers/platform/x86/ideapad-laptop.c | 7 +++
>>> > 1 file changed, 7 insertions(+)
>>> >
>>> > diff --git a/drivers/platform/x86/ideapad-laptop.c
>>> > b/drivers/platform/x86/ideapad-laptop.c
>>> > index 535199c9e6bc..0a843c4ca4fc 100644
>>> > --- a/drivers/platform/x86/ideapad-laptop.c
>>> > +++ b/drivers/platform/x86/ideapad-laptop.c
>>> > @@ -1114,6 +1114,13 @@ static const struct dmi_system_id
>>> > no_hw_rfkill_list[] = {
>>> > DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
>>> > },
>>> > },
>>> > + {
>>> > + .ident = "Lenovo Yoga 2 13",
>>> > + .matches = {
>>> > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>>> > + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
>>> > + },
>>> > + },
>>> > {
>>> > .ident = "Lenovo Yoga 3 1170 / 1470",
>>> > .matches = {
>>> > --
>>> > 2.17.0
>>> >
>>>
>>>
>>> --
>>> With Best Regards,
>>> Andy Shevchenko
>
>
>
> --
> Loic WEI YU NENG
> US phone: +1 408 218 2826
> FR phone: +33 674201069
> email: loic@gmail.com
--
With Best Regards,
Andy Shevchenko
