Re: [PATCH] iio: amplifiers: ad8366: Add the missed check for devm_gpiod_get()

[Markus Elfring]

> ad8366_probe() forgets to check the return value of devm_gpiod_get().
> Add the missed check

Thanks for another completion of the exception handling.


>  to fix it.

I suggest to replace this wording by the tag “Fixes” for the commit message.

Regards,
Markus

[PATCH] iio: amplifiers: ad8366: add the missed check for devm_gpiod_get

[Chuhong Yuan]

ad8366_probe() forgets to check the return value of devm_gpiod_get().
Add the missed check to fix it.

Signed-off-by: Chuhong Yuan 
---
 drivers/iio/amplifiers/ad8366.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad8366.c
index 62167b87caea..b996823c8d51 100644
--- a/drivers/iio/amplifiers/ad8366.c
+++ b/drivers/iio/amplifiers/ad8366.c
@@ -264,6 +264,10 @@ static int ad8366_probe(struct spi_device *spi)
case ID_HMC1119:
st->reset_gpio = devm_gpiod_get(&spi->dev, "reset",
GPIOD_OUT_HIGH);
+   if (IS_ERR(st->reset_gpio)) {
+   ret = PTR_ERR(st->reset_gpio);
+   goto error_disable_reg;
+   }
indio_dev->channels = ada4961_channels;
indio_dev->num_channels = ARRAY_SIZE(ada4961_channels);
break;
-- 
2.26.2