Re: [PATCH] iommu/msm: Use platform_register/unregister_drivers()

2015-12-14 Thread Joerg Roedel
On Wed, Dec 02, 2015 at 05:26:01PM +0100, Thierry Reding wrote:
> From: Thierry Reding 
> 
> These new helpers simplify implementing multi-driver modules and
> properly handle failure to register one driver by unregistering all
> previously registered drivers.
> 
> Signed-off-by: Thierry Reding 
> ---
>  drivers/iommu/msm_iommu_dev.c | 25 +++--
>  1 file changed, 7 insertions(+), 18 deletions(-)

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] iommu/msm: Use platform_register/unregister_drivers()

2015-12-02 Thread Thierry Reding
From: Thierry Reding 

These new helpers simplify implementing multi-driver modules and
properly handle failure to register one driver by unregistering all
previously registered drivers.

Signed-off-by: Thierry Reding 
---
 drivers/iommu/msm_iommu_dev.c | 25 +++--
 1 file changed, 7 insertions(+), 18 deletions(-)

diff --git a/drivers/iommu/msm_iommu_dev.c b/drivers/iommu/msm_iommu_dev.c
index b6d01f97e537..4b09e815accf 100644
--- a/drivers/iommu/msm_iommu_dev.c
+++ b/drivers/iommu/msm_iommu_dev.c
@@ -359,30 +359,19 @@ static struct platform_driver msm_iommu_ctx_driver = {
.remove = msm_iommu_ctx_remove,
 };
 
+static struct platform_driver * const drivers[] = {
+   &msm_iommu_driver,
+   &msm_iommu_ctx_driver,
+};
+
 static int __init msm_iommu_driver_init(void)
 {
-   int ret;
-   ret = platform_driver_register(&msm_iommu_driver);
-   if (ret != 0) {
-   pr_err("Failed to register IOMMU driver\n");
-   goto error;
-   }
-
-   ret = platform_driver_register(&msm_iommu_ctx_driver);
-   if (ret != 0) {
-   platform_driver_unregister(&msm_iommu_driver);
-   pr_err("Failed to register IOMMU context driver\n");
-   goto error;
-   }
-
-error:
-   return ret;
+   return platform_register_drivers(drivers, ARRAY_SIZE(drivers));
 }
 
 static void __exit msm_iommu_driver_exit(void)
 {
-   platform_driver_unregister(&msm_iommu_ctx_driver);
-   platform_driver_unregister(&msm_iommu_driver);
+   platform_unregister_drivers(drivers, ARRAY_SIZE(drivers));
 }
 
 subsys_initcall(msm_iommu_driver_init);
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/