Re: [PATCH] ipvs: remove unnecessary space
Pablo v2 has been sent I made the following changes: 1. remove all unnecessary spaces in one go 2. revert bitmap_alloc ( since it's irrelevant to this subject) 3. chenge subject to "net/netfiler:remove unnecessary space" thanks Pablo Neira Ayuso 于2019年7月15日周一 下午4:27写道: > > On Wed, Jul 10, 2019 at 10:06:09AM +0200, Simon Horman wrote: > > On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > > > --- > > > net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > > > index 94d9d34..98e358e 100644 > > > --- a/net/netfilter/ipvs/ip_vs_mh.c > > > +++ b/net/netfilter/ipvs/ip_vs_mh.c > > > @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > > > return 0; > > > } > > > > > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > > -sizeof(unsigned long), GFP_KERNEL); > > > + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > > + sizeof(unsigned long), GFP_KERNEL); > > May I ask one thing? :-) > > Please, remove all unnecessary spaces in one go, search for: > > git grep "= " > > in the netfilter tree, and send a v2 for this one. > > Thanks.
Re: [PATCH] ipvs: remove unnecessary space
ok I will remove all unnecessary spaces and send the v2 patch Thansk Pablo Pablo Neira Ayuso 于2019年7月15日周一 下午4:27写道: > > On Wed, Jul 10, 2019 at 10:06:09AM +0200, Simon Horman wrote: > > On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > > > --- > > > net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > > > index 94d9d34..98e358e 100644 > > > --- a/net/netfilter/ipvs/ip_vs_mh.c > > > +++ b/net/netfilter/ipvs/ip_vs_mh.c > > > @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > > > return 0; > > > } > > > > > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > > -sizeof(unsigned long), GFP_KERNEL); > > > + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > > + sizeof(unsigned long), GFP_KERNEL); > > May I ask one thing? :-) > > Please, remove all unnecessary spaces in one go, search for: > > git grep "= " > > in the netfilter tree, and send a v2 for this one. > > Thanks.
Re: [PATCH] ipvs: remove unnecessary space
On Wed, Jul 10, 2019 at 10:06:09AM +0200, Simon Horman wrote: > On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > > --- > > net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > > index 94d9d34..98e358e 100644 > > --- a/net/netfilter/ipvs/ip_vs_mh.c > > +++ b/net/netfilter/ipvs/ip_vs_mh.c > > @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > > return 0; > > } > > > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > -sizeof(unsigned long), GFP_KERNEL); > > + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > + sizeof(unsigned long), GFP_KERNEL); May I ask one thing? :-) Please, remove all unnecessary spaces in one go, search for: git grep "= " in the netfilter tree, and send a v2 for this one. Thanks.
Re: [PATCH] ipvs: remove unnecessary space
On Mon, Jul 15, 2019 at 09:57:03AM +0200, Pablo Neira Ayuso wrote: > On Fri, Jul 12, 2019 at 09:07:21PM +0800, yangxingwu wrote: > > this patch removes the extra space and use bitmap_zalloc instead > > > > Signed-off-by: yangxingwu > > --- > > net/netfilter/ipvs/ip_vs_mh.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > > index 94d9d34..3229867 100644 > > --- a/net/netfilter/ipvs/ip_vs_mh.c > > +++ b/net/netfilter/ipvs/ip_vs_mh.c > > @@ -174,8 +174,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > > return 0; > > } > > > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > -sizeof(unsigned long), GFP_KERNEL); > > + table = bitmap_zalloc(IP_VS_MH_TAB_SIZE, GFP_KERNEL); > > By doing: > > git grep "= " ... > > on the netfilter folders, I see more of these, it would be good if you > fix them at once or, probably, you want to use coccinelle for this. If patch subject is "remove unnecessary space" then just remove unnecessary spaces in the patch, otherwise I suggest you rename this to "ipvs: use bitmap_zalloc()" or such, since the space removal here is irrelevant.
Re: [PATCH] ipvs: remove unnecessary space
On Fri, Jul 12, 2019 at 09:07:21PM +0800, yangxingwu wrote: > this patch removes the extra space and use bitmap_zalloc instead > > Signed-off-by: yangxingwu > --- > net/netfilter/ipvs/ip_vs_mh.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > index 94d9d34..3229867 100644 > --- a/net/netfilter/ipvs/ip_vs_mh.c > +++ b/net/netfilter/ipvs/ip_vs_mh.c > @@ -174,8 +174,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > return 0; > } > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > - sizeof(unsigned long), GFP_KERNEL); > + table = bitmap_zalloc(IP_VS_MH_TAB_SIZE, GFP_KERNEL); By doing: git grep "= " ... on the netfilter folders, I see more of these, it would be good if you fix them at once or, probably, you want to use coccinelle for this. Thanks.
[PATCH] ipvs: remove unnecessary space
this patch removes the extra space and use bitmap_zalloc instead Signed-off-by: yangxingwu --- net/netfilter/ipvs/ip_vs_mh.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c index 94d9d34..3229867 100644 --- a/net/netfilter/ipvs/ip_vs_mh.c +++ b/net/netfilter/ipvs/ip_vs_mh.c @@ -174,8 +174,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, return 0; } - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), -sizeof(unsigned long), GFP_KERNEL); + table = bitmap_zalloc(IP_VS_MH_TAB_SIZE, GFP_KERNEL); if (!table) return -ENOMEM; -- 1.8.3.1
[PATCH] ipvs: remove unnecessary space
this patch removes the extra space and use bitmap_zalloc instead Signed-off-by: yangxingwu --- net/netfilter/ipvs/ip_vs_mh.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c index 94d9d34..3229867 100644 --- a/net/netfilter/ipvs/ip_vs_mh.c +++ b/net/netfilter/ipvs/ip_vs_mh.c @@ -174,8 +174,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, return 0; } - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), -sizeof(unsigned long), GFP_KERNEL); + table = bitmap_zalloc(IP_VS_MH_TAB_SIZE, GFP_KERNEL); if (!table) return -ENOMEM; -- 1.8.3.1
Re: [PATCH] ipvs: remove unnecessary space
On Wed, 2019-07-10 at 10:06 +0200, Simon Horman wrote: > On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > > this patch removes the extra space. > > > > Signed-off-by: yangxingwu > > Thanks, this looks good to me. > > Acked-by: Simon Horman > > Pablo, please consider including this in nf-next. > > > > --- > > net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > > index 94d9d34..98e358e 100644 > > --- a/net/netfilter/ipvs/ip_vs_mh.c > > +++ b/net/netfilter/ipvs/ip_vs_mh.c > > @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > > return 0; > > } > > > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > -sizeof(unsigned long), GFP_KERNEL); > > + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > + sizeof(unsigned long), GFP_KERNEL); bitmap_alloc? > > if (!table) > > return -ENOMEM; > > > > -- > > 1.8.3.1 > >
Re: [PATCH] ipvs: remove unnecessary space
On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > this patch removes the extra space. > > Signed-off-by: yangxingwu Thanks, this looks good to me. Acked-by: Simon Horman Pablo, please consider including this in nf-next. > --- > net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > index 94d9d34..98e358e 100644 > --- a/net/netfilter/ipvs/ip_vs_mh.c > +++ b/net/netfilter/ipvs/ip_vs_mh.c > @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > return 0; > } > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > - sizeof(unsigned long), GFP_KERNEL); > + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > + sizeof(unsigned long), GFP_KERNEL); > if (!table) > return -ENOMEM; > > -- > 1.8.3.1 >
[PATCH] ipvs: remove unnecessary space
this patch removes the extra space. Signed-off-by: yangxingwu --- net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c index 94d9d34..98e358e 100644 --- a/net/netfilter/ipvs/ip_vs_mh.c +++ b/net/netfilter/ipvs/ip_vs_mh.c @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, return 0; } - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), -sizeof(unsigned long), GFP_KERNEL); + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), + sizeof(unsigned long), GFP_KERNEL); if (!table) return -ENOMEM; -- 1.8.3.1