Re: [PATCH] kselftests: timers: Fix inconsistency-check to not ignore first timestamp
On Tue, Jun 13, 2017 at 3:57 AM, Miroslav Lichvarwrote: > When the first timestamp in the list of clock readings was later than > the second timestamp and all other timestamps were in order, the > inconsistency was not reported because the index of the out-of-order > timestamp was equal to the default value. > > Cc: John Stultz > Cc: Prarit Bhargava > Cc: Richard Cochran > Signed-off-by: Miroslav Lichvar Queued up in my tree for testing, targeting 4.13. thanks -john
Re: [PATCH] kselftests: timers: Fix inconsistency-check to not ignore first timestamp
On Tue, Jun 13, 2017 at 3:57 AM, Miroslav Lichvar wrote: > When the first timestamp in the list of clock readings was later than > the second timestamp and all other timestamps were in order, the > inconsistency was not reported because the index of the out-of-order > timestamp was equal to the default value. > > Cc: John Stultz > Cc: Prarit Bhargava > Cc: Richard Cochran > Signed-off-by: Miroslav Lichvar Queued up in my tree for testing, targeting 4.13. thanks -john
[PATCH] kselftests: timers: Fix inconsistency-check to not ignore first timestamp
When the first timestamp in the list of clock readings was later than the second timestamp and all other timestamps were in order, the inconsistency was not reported because the index of the out-of-order timestamp was equal to the default value. Cc: John StultzCc: Prarit Bhargava Cc: Richard Cochran Signed-off-by: Miroslav Lichvar --- tools/testing/selftests/timers/inconsistency-check.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/timers/inconsistency-check.c b/tools/testing/selftests/timers/inconsistency-check.c index caf1bc9..74c60e8 100644 --- a/tools/testing/selftests/timers/inconsistency-check.c +++ b/tools/testing/selftests/timers/inconsistency-check.c @@ -118,7 +118,7 @@ int consistency_test(int clock_type, unsigned long seconds) start_str = ctime(); while (seconds == -1 || now - then < seconds) { - inconsistent = 0; + inconsistent = -1; /* Fill list */ for (i = 0; i < CALLS_PER_LOOP; i++) @@ -130,7 +130,7 @@ int consistency_test(int clock_type, unsigned long seconds) inconsistent = i; /* display inconsistency */ - if (inconsistent) { + if (inconsistent >= 0) { unsigned long long delta; printf("\%s\n", start_str); -- 2.9.3
[PATCH] kselftests: timers: Fix inconsistency-check to not ignore first timestamp
When the first timestamp in the list of clock readings was later than the second timestamp and all other timestamps were in order, the inconsistency was not reported because the index of the out-of-order timestamp was equal to the default value. Cc: John Stultz Cc: Prarit Bhargava Cc: Richard Cochran Signed-off-by: Miroslav Lichvar --- tools/testing/selftests/timers/inconsistency-check.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/timers/inconsistency-check.c b/tools/testing/selftests/timers/inconsistency-check.c index caf1bc9..74c60e8 100644 --- a/tools/testing/selftests/timers/inconsistency-check.c +++ b/tools/testing/selftests/timers/inconsistency-check.c @@ -118,7 +118,7 @@ int consistency_test(int clock_type, unsigned long seconds) start_str = ctime(); while (seconds == -1 || now - then < seconds) { - inconsistent = 0; + inconsistent = -1; /* Fill list */ for (i = 0; i < CALLS_PER_LOOP; i++) @@ -130,7 +130,7 @@ int consistency_test(int clock_type, unsigned long seconds) inconsistent = i; /* display inconsistency */ - if (inconsistent) { + if (inconsistent >= 0) { unsigned long long delta; printf("\%s\n", start_str); -- 2.9.3