Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
Hi Ian,
On Thu, Oct 15, 2020 at 1:30 PM Ian Rogers wrote:
>
> On Wed, Oct 14, 2020 at 4:49 PM Vitor Massaru Iha wrote:
> >
> > Hi Ian,
> >
> >
> > On Wed, Jul 29, 2020 at 7:57 PM Ian Rogers wrote:
> > >
> > > On Wed, Jul 29, 2020 at 1:11 PM Vitor Massaru Iha
> > > wrote:
> > > >
> > > > This adds the conversion of the runtime tests of test_min_heap,
> > > > from `lib/test_min_heap.c` to KUnit tests.
> > > >
> > > > Please apply this commit first (linux-kselftest/kunit-fixes):
> > > > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix
> > > > parsing of CONFIG options with space
> > >
> > > Thanks for this, I'm a fan of testing frameworks :-)
> > >
> > > > Signed-off-by: Vitor Massaru Iha
> > > > ---
> > > > lib/Kconfig.debug | 29 --
> > > > lib/Makefile | 2 +-
> > > > lib/{test_min_heap.c => min_heap_kunit.c} | 117 --
> > > > 3 files changed, 83 insertions(+), 65 deletions(-)
> > > > rename lib/{test_min_heap.c => min_heap_kunit.c} (60%)
> > > >
> > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > > > index 9ad9210d70a1..46674fc4972c 100644
> > > > --- a/lib/Kconfig.debug
> > > > +++ b/lib/Kconfig.debug
> > > > @@ -1864,16 +1864,6 @@ config TEST_LIST_SORT
> > > >
> > > > If unsure, say N.
> > > >
> > > > -config TEST_MIN_HEAP
> > > > - tristate "Min heap test"
> > > > - depends on DEBUG_KERNEL || m
> > > > - help
> > > > - Enable this to turn on min heap function tests. This test is
> > > > - executed only once during system boot (so affects only boot
> > > > time),
> > > > - or at module load time.
> > > > -
> > > > - If unsure, say N.
> > > > -
> > > > config TEST_SORT
> > > > tristate "Array-based sort test"
> > > > depends on DEBUG_KERNEL || m
> > > > @@ -2185,6 +2175,25 @@ config LINEAR_RANGES_TEST
> > > >
> > > > If unsure, say N.
> > > >
> > > > +config MIN_HEAP_KUNIT
> > > > +tristate "KUnit test for Min heap"
> > > > +depends on KUNIT
> > > > +depends on DEBUG_KERNEL || m
> > > > +help
> > > > + Enable this to turn on min heap function tests. This test is
> > > > + executed only once during system boot (so affects only boot
> > > > time),
> > > > + or at module load time.
> > > > +
> > > > + KUnit tests run during boot and output the results to the
> > > > debug log
> > > > + in TAP format (http://testanything.org/). Only useful for
> > > > kernel devs
> > > > + running the KUnit test harness, and not intended for
> > > > inclusion into a
> > > > + production build.
> > > > +
> > > > + For more information on KUnit and unit tests in general
> > > > please refer
> > > > + to the KUnit documentation in Documentation/dev-tools/kunit/.
> > > > +
> > > > + If unsure, say N.
> > > > +
> > >
> > > It's a shame we need a config option for this. Could we have one
> > > option to cover all basic library tests?
> > >
> > > > config TEST_UDELAY
> > > > tristate "udelay test driver"
> > > > help
> > > > diff --git a/lib/Makefile b/lib/Makefile
> > > > index b1c42c10073b..748f57063160 100644
> > > > --- a/lib/Makefile
> > > > +++ b/lib/Makefile
> > > > @@ -72,7 +72,6 @@ CFLAGS_test_ubsan.o += $(call cc-disable-warning, vla)
> > > > UBSAN_SANITIZE_test_ubsan.o := y
> > > > obj-$(CONFIG_TEST_KSTRTOX) += test-kstrtox.o
> > > > obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o
> > > > -obj-$(CONFIG_TEST_MIN_HEAP) += test_min_heap.o
> > > > obj-$(CONFIG_TEST_LKM) += test_module.o
> > > > obj-$(CONFIG_TEST_VMALLOC) += test_vmalloc.o
> > > > obj-$(CONFIG_TEST_OVERFLOW) += test_overflow.o
> > > > @@ -318,3 +317,4 @@ obj-$(CONFIG_OBJAGG) += objagg.o
> > > > # KUnit tests
> > > > obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
> > > > obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
> > > > +obj-$(CONFIG_MIN_HEAP_KUNIT) += min_heap_kunit.o
> > > > diff --git a/lib/test_min_heap.c b/lib/min_heap_kunit.c
> > > > similarity index 60%
> > > > rename from lib/test_min_heap.c
> > > > rename to lib/min_heap_kunit.c
> > > > index d19c8080fd4d..398db1c63146 100644
> > > > --- a/lib/test_min_heap.c
> > > > +++ b/lib/min_heap_kunit.c
> > > > @@ -7,9 +7,8 @@
> > > >
> > > > #include
> > > > #include
> > > > -#include
> > > > -#include
> > > > #include
> > > > +#include
> > > >
> > > > static __init bool less_than(const void *lhs, const void *rhs)
> > > > {
> > > > @@ -29,37 +28,34 @@ static __init void swap_ints(void *lhs, void *rhs)
> > > > *(int *)rhs = temp;
> > > > }
> > > >
> > > > -static __init int pop_verify_heap(bool min_heap,
> > > > +static __init void pop_verify_heap(struct kunit *context,
> > > > + bool min_heap,
> > > > struct min_heap *heap,
> > > >
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
On Wed, Oct 14, 2020 at 4:49 PM Vitor Massaru Iha wrote:
>
> Hi Ian,
>
>
> On Wed, Jul 29, 2020 at 7:57 PM Ian Rogers wrote:
> >
> > On Wed, Jul 29, 2020 at 1:11 PM Vitor Massaru Iha wrote:
> > >
> > > This adds the conversion of the runtime tests of test_min_heap,
> > > from `lib/test_min_heap.c` to KUnit tests.
> > >
> > > Please apply this commit first (linux-kselftest/kunit-fixes):
> > > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing
> > > of CONFIG options with space
> >
> > Thanks for this, I'm a fan of testing frameworks :-)
> >
> > > Signed-off-by: Vitor Massaru Iha
> > > ---
> > > lib/Kconfig.debug | 29 --
> > > lib/Makefile | 2 +-
> > > lib/{test_min_heap.c => min_heap_kunit.c} | 117 --
> > > 3 files changed, 83 insertions(+), 65 deletions(-)
> > > rename lib/{test_min_heap.c => min_heap_kunit.c} (60%)
> > >
> > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > > index 9ad9210d70a1..46674fc4972c 100644
> > > --- a/lib/Kconfig.debug
> > > +++ b/lib/Kconfig.debug
> > > @@ -1864,16 +1864,6 @@ config TEST_LIST_SORT
> > >
> > > If unsure, say N.
> > >
> > > -config TEST_MIN_HEAP
> > > - tristate "Min heap test"
> > > - depends on DEBUG_KERNEL || m
> > > - help
> > > - Enable this to turn on min heap function tests. This test is
> > > - executed only once during system boot (so affects only boot
> > > time),
> > > - or at module load time.
> > > -
> > > - If unsure, say N.
> > > -
> > > config TEST_SORT
> > > tristate "Array-based sort test"
> > > depends on DEBUG_KERNEL || m
> > > @@ -2185,6 +2175,25 @@ config LINEAR_RANGES_TEST
> > >
> > > If unsure, say N.
> > >
> > > +config MIN_HEAP_KUNIT
> > > +tristate "KUnit test for Min heap"
> > > +depends on KUNIT
> > > +depends on DEBUG_KERNEL || m
> > > +help
> > > + Enable this to turn on min heap function tests. This test is
> > > + executed only once during system boot (so affects only boot
> > > time),
> > > + or at module load time.
> > > +
> > > + KUnit tests run during boot and output the results to the
> > > debug log
> > > + in TAP format (http://testanything.org/). Only useful for
> > > kernel devs
> > > + running the KUnit test harness, and not intended for inclusion
> > > into a
> > > + production build.
> > > +
> > > + For more information on KUnit and unit tests in general please
> > > refer
> > > + to the KUnit documentation in Documentation/dev-tools/kunit/.
> > > +
> > > + If unsure, say N.
> > > +
> >
> > It's a shame we need a config option for this. Could we have one
> > option to cover all basic library tests?
> >
> > > config TEST_UDELAY
> > > tristate "udelay test driver"
> > > help
> > > diff --git a/lib/Makefile b/lib/Makefile
> > > index b1c42c10073b..748f57063160 100644
> > > --- a/lib/Makefile
> > > +++ b/lib/Makefile
> > > @@ -72,7 +72,6 @@ CFLAGS_test_ubsan.o += $(call cc-disable-warning, vla)
> > > UBSAN_SANITIZE_test_ubsan.o := y
> > > obj-$(CONFIG_TEST_KSTRTOX) += test-kstrtox.o
> > > obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o
> > > -obj-$(CONFIG_TEST_MIN_HEAP) += test_min_heap.o
> > > obj-$(CONFIG_TEST_LKM) += test_module.o
> > > obj-$(CONFIG_TEST_VMALLOC) += test_vmalloc.o
> > > obj-$(CONFIG_TEST_OVERFLOW) += test_overflow.o
> > > @@ -318,3 +317,4 @@ obj-$(CONFIG_OBJAGG) += objagg.o
> > > # KUnit tests
> > > obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
> > > obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
> > > +obj-$(CONFIG_MIN_HEAP_KUNIT) += min_heap_kunit.o
> > > diff --git a/lib/test_min_heap.c b/lib/min_heap_kunit.c
> > > similarity index 60%
> > > rename from lib/test_min_heap.c
> > > rename to lib/min_heap_kunit.c
> > > index d19c8080fd4d..398db1c63146 100644
> > > --- a/lib/test_min_heap.c
> > > +++ b/lib/min_heap_kunit.c
> > > @@ -7,9 +7,8 @@
> > >
> > > #include
> > > #include
> > > -#include
> > > -#include
> > > #include
> > > +#include
> > >
> > > static __init bool less_than(const void *lhs, const void *rhs)
> > > {
> > > @@ -29,37 +28,34 @@ static __init void swap_ints(void *lhs, void *rhs)
> > > *(int *)rhs = temp;
> > > }
> > >
> > > -static __init int pop_verify_heap(bool min_heap,
> > > +static __init void pop_verify_heap(struct kunit *context,
> > > + bool min_heap,
> > > struct min_heap *heap,
> > > const struct min_heap_callbacks *funcs)
> > > {
> > > int *values = heap->data;
> > > - int err = 0;
> > > int last;
> > >
> > > last = values[0];
> > > min_heap_pop(heap, funcs);
> > > while (heap->nr > 0) {
> > > if (min_heap) {
> > > -
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
Hi Ian,
On Wed, Jul 29, 2020 at 7:57 PM Ian Rogers wrote:
>
> On Wed, Jul 29, 2020 at 1:11 PM Vitor Massaru Iha wrote:
> >
> > This adds the conversion of the runtime tests of test_min_heap,
> > from `lib/test_min_heap.c` to KUnit tests.
> >
> > Please apply this commit first (linux-kselftest/kunit-fixes):
> > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing
> > of CONFIG options with space
>
> Thanks for this, I'm a fan of testing frameworks :-)
>
> > Signed-off-by: Vitor Massaru Iha
> > ---
> > lib/Kconfig.debug | 29 --
> > lib/Makefile | 2 +-
> > lib/{test_min_heap.c => min_heap_kunit.c} | 117 --
> > 3 files changed, 83 insertions(+), 65 deletions(-)
> > rename lib/{test_min_heap.c => min_heap_kunit.c} (60%)
> >
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index 9ad9210d70a1..46674fc4972c 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -1864,16 +1864,6 @@ config TEST_LIST_SORT
> >
> > If unsure, say N.
> >
> > -config TEST_MIN_HEAP
> > - tristate "Min heap test"
> > - depends on DEBUG_KERNEL || m
> > - help
> > - Enable this to turn on min heap function tests. This test is
> > - executed only once during system boot (so affects only boot time),
> > - or at module load time.
> > -
> > - If unsure, say N.
> > -
> > config TEST_SORT
> > tristate "Array-based sort test"
> > depends on DEBUG_KERNEL || m
> > @@ -2185,6 +2175,25 @@ config LINEAR_RANGES_TEST
> >
> > If unsure, say N.
> >
> > +config MIN_HEAP_KUNIT
> > +tristate "KUnit test for Min heap"
> > +depends on KUNIT
> > +depends on DEBUG_KERNEL || m
> > +help
> > + Enable this to turn on min heap function tests. This test is
> > + executed only once during system boot (so affects only boot
> > time),
> > + or at module load time.
> > +
> > + KUnit tests run during boot and output the results to the debug
> > log
> > + in TAP format (http://testanything.org/). Only useful for kernel
> > devs
> > + running the KUnit test harness, and not intended for inclusion
> > into a
> > + production build.
> > +
> > + For more information on KUnit and unit tests in general please
> > refer
> > + to the KUnit documentation in Documentation/dev-tools/kunit/.
> > +
> > + If unsure, say N.
> > +
>
> It's a shame we need a config option for this. Could we have one
> option to cover all basic library tests?
>
> > config TEST_UDELAY
> > tristate "udelay test driver"
> > help
> > diff --git a/lib/Makefile b/lib/Makefile
> > index b1c42c10073b..748f57063160 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -72,7 +72,6 @@ CFLAGS_test_ubsan.o += $(call cc-disable-warning, vla)
> > UBSAN_SANITIZE_test_ubsan.o := y
> > obj-$(CONFIG_TEST_KSTRTOX) += test-kstrtox.o
> > obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o
> > -obj-$(CONFIG_TEST_MIN_HEAP) += test_min_heap.o
> > obj-$(CONFIG_TEST_LKM) += test_module.o
> > obj-$(CONFIG_TEST_VMALLOC) += test_vmalloc.o
> > obj-$(CONFIG_TEST_OVERFLOW) += test_overflow.o
> > @@ -318,3 +317,4 @@ obj-$(CONFIG_OBJAGG) += objagg.o
> > # KUnit tests
> > obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
> > obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
> > +obj-$(CONFIG_MIN_HEAP_KUNIT) += min_heap_kunit.o
> > diff --git a/lib/test_min_heap.c b/lib/min_heap_kunit.c
> > similarity index 60%
> > rename from lib/test_min_heap.c
> > rename to lib/min_heap_kunit.c
> > index d19c8080fd4d..398db1c63146 100644
> > --- a/lib/test_min_heap.c
> > +++ b/lib/min_heap_kunit.c
> > @@ -7,9 +7,8 @@
> >
> > #include
> > #include
> > -#include
> > -#include
> > #include
> > +#include
> >
> > static __init bool less_than(const void *lhs, const void *rhs)
> > {
> > @@ -29,37 +28,34 @@ static __init void swap_ints(void *lhs, void *rhs)
> > *(int *)rhs = temp;
> > }
> >
> > -static __init int pop_verify_heap(bool min_heap,
> > +static __init void pop_verify_heap(struct kunit *context,
> > + bool min_heap,
> > struct min_heap *heap,
> > const struct min_heap_callbacks *funcs)
> > {
> > int *values = heap->data;
> > - int err = 0;
> > int last;
> >
> > last = values[0];
> > min_heap_pop(heap, funcs);
> > while (heap->nr > 0) {
> > if (min_heap) {
> > - if (last > values[0]) {
> > - pr_err("error: expected %d <= %d\n", last,
> > - values[0]);
> > - err++;
> > - }
> > + KUNIT_EXPECT_FALSE_MSG(context,
> > +
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
On Wed, Oct 14, 2020 at 5:00 PM Peter Zijlstra wrote: > > On Wed, Oct 14, 2020 at 11:16:10AM -0700, Ian Rogers wrote: > > > There were some issues in the original patch, they should be easy to > > fix. I'm more concerned that Peter's issues are addressed about the > > general direction of the patch, verbosity and testing frameworks. I > > see Vitor followed up with Peter but I'm not sure that means the > > approach has been accepted. > > I kinda lost track, as long as it doesn't get more verbose I suppose I'm > fine. Ok. I'll send the v2 later with Ian's suggestions.
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
On Wed, Oct 14, 2020 at 11:16:10AM -0700, Ian Rogers wrote: > There were some issues in the original patch, they should be easy to > fix. I'm more concerned that Peter's issues are addressed about the > general direction of the patch, verbosity and testing frameworks. I > see Vitor followed up with Peter but I'm not sure that means the > approach has been accepted. I kinda lost track, as long as it doesn't get more verbose I suppose I'm fine.
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
On Mon, Oct 12, 2020 at 2:03 PM Brendan Higgins wrote: > > On Tue, Aug 4, 2020 at 9:22 AM Vitor Massaru Iha wrote: > > > > Hi Peter, > > > > On Tue, Aug 4, 2020 at 11:23 AM wrote: > > > > > > On Tue, Aug 04, 2020 at 10:46:21AM -0300, Vitor Massaru Iha wrote: > > > > On Tue, Aug 4, 2020 at 10:25 AM wrote: > > > > > On Wed, Jul 29, 2020 at 06:57:17PM -0300, Vitor Massaru Iha wrote: > > > > > > > > > > > The results can be seen this way: > > > > > > > > > > > > This is an excerpt from the test.log with the result in TAP format: > > > > > > [snip] > > > > > > ok 5 - example > > > > > > # Subtest: min-heap > > > > > > 1..6 > > > > > > ok 1 - test_heapify_all_true > > > > > > ok 2 - test_heapify_all_false > > > > > > ok 3 - test_heap_push_true > > > > > > ok 4 - test_heap_push_false > > > > > > ok 5 - test_heap_pop_push_true > > > > > > ok 6 - test_heap_pop_push_false > > > > > > [snip] > > > > > > So ^ is TAP format? > > > > Yep, you can see the spec here: > > https://testanything.org/tap-specification.html > > > > > > > > > > I don't care or care to use either; what does dmesg do? It used to be > > > > > that just building the self-tests was sufficient and any error would > > > > > show in dmesg when you boot the machine. > > > > > > > > > > But if I now have to use some damn tool, this is a regression. > > > > > > > > If you don't want to, you don't need to use the kunit-tool. If you > > > > compile the tests as builtin and run the Kernel on your machine > > > > the test result will be shown in dmesg in TAP format. > > > > > > That's seems a lot more verbose than it is now. I've recently even done > > > a bunch of tests that don't print anything on success, dmesg is clutter > > > enough already. > > > > What tests do you refer to? > > > > Running the test_min_heap.c, I got this from dmesg: > > > > min_heap_test: test passed > > > > And running min_heap_kunit.c: > > > > ok 1 - min-heap > > Gentle poke. I think Vitor was looking for a response. My guess is > that Ian was waiting for a follow up patch. There were some issues in the original patch, they should be easy to fix. I'm more concerned that Peter's issues are addressed about the general direction of the patch, verbosity and testing frameworks. I see Vitor followed up with Peter but I'm not sure that means the approach has been accepted. Thanks, Ian
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
On Tue, Aug 4, 2020 at 9:22 AM Vitor Massaru Iha wrote: > > Hi Peter, > > On Tue, Aug 4, 2020 at 11:23 AM wrote: > > > > On Tue, Aug 04, 2020 at 10:46:21AM -0300, Vitor Massaru Iha wrote: > > > On Tue, Aug 4, 2020 at 10:25 AM wrote: > > > > On Wed, Jul 29, 2020 at 06:57:17PM -0300, Vitor Massaru Iha wrote: > > > > > > > > > The results can be seen this way: > > > > > > > > > > This is an excerpt from the test.log with the result in TAP format: > > > > > [snip] > > > > > ok 5 - example > > > > > # Subtest: min-heap > > > > > 1..6 > > > > > ok 1 - test_heapify_all_true > > > > > ok 2 - test_heapify_all_false > > > > > ok 3 - test_heap_push_true > > > > > ok 4 - test_heap_push_false > > > > > ok 5 - test_heap_pop_push_true > > > > > ok 6 - test_heap_pop_push_false > > > > > [snip] > > > > So ^ is TAP format? > > Yep, you can see the spec here: > https://testanything.org/tap-specification.html > > > > > > > I don't care or care to use either; what does dmesg do? It used to be > > > > that just building the self-tests was sufficient and any error would > > > > show in dmesg when you boot the machine. > > > > > > > > But if I now have to use some damn tool, this is a regression. > > > > > > If you don't want to, you don't need to use the kunit-tool. If you > > > compile the tests as builtin and run the Kernel on your machine > > > the test result will be shown in dmesg in TAP format. > > > > That's seems a lot more verbose than it is now. I've recently even done > > a bunch of tests that don't print anything on success, dmesg is clutter > > enough already. > > What tests do you refer to? > > Running the test_min_heap.c, I got this from dmesg: > > min_heap_test: test passed > > And running min_heap_kunit.c: > > ok 1 - min-heap Gentle poke. I think Vitor was looking for a response. My guess is that Ian was waiting for a follow up patch.
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
Hi Peter, On Tue, Aug 4, 2020 at 11:23 AM wrote: > > On Tue, Aug 04, 2020 at 10:46:21AM -0300, Vitor Massaru Iha wrote: > > On Tue, Aug 4, 2020 at 10:25 AM wrote: > > > On Wed, Jul 29, 2020 at 06:57:17PM -0300, Vitor Massaru Iha wrote: > > > > > > > The results can be seen this way: > > > > > > > > This is an excerpt from the test.log with the result in TAP format: > > > > [snip] > > > > ok 5 - example > > > > # Subtest: min-heap > > > > 1..6 > > > > ok 1 - test_heapify_all_true > > > > ok 2 - test_heapify_all_false > > > > ok 3 - test_heap_push_true > > > > ok 4 - test_heap_push_false > > > > ok 5 - test_heap_pop_push_true > > > > ok 6 - test_heap_pop_push_false > > > > [snip] > > So ^ is TAP format? Yep, you can see the spec here: https://testanything.org/tap-specification.html > > > > I don't care or care to use either; what does dmesg do? It used to be > > > that just building the self-tests was sufficient and any error would > > > show in dmesg when you boot the machine. > > > > > > But if I now have to use some damn tool, this is a regression. > > > > If you don't want to, you don't need to use the kunit-tool. If you > > compile the tests as builtin and run the Kernel on your machine > > the test result will be shown in dmesg in TAP format. > > That's seems a lot more verbose than it is now. I've recently even done > a bunch of tests that don't print anything on success, dmesg is clutter > enough already. What tests do you refer to? Running the test_min_heap.c, I got this from dmesg: min_heap_test: test passed And running min_heap_kunit.c: ok 1 - min-heap BR, Vitor
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
On Tue, Aug 04, 2020 at 10:46:21AM -0300, Vitor Massaru Iha wrote: > On Tue, Aug 4, 2020 at 10:25 AM wrote: > > On Wed, Jul 29, 2020 at 06:57:17PM -0300, Vitor Massaru Iha wrote: > > > > > The results can be seen this way: > > > > > > This is an excerpt from the test.log with the result in TAP format: > > > [snip] > > > ok 5 - example > > > # Subtest: min-heap > > > 1..6 > > > ok 1 - test_heapify_all_true > > > ok 2 - test_heapify_all_false > > > ok 3 - test_heap_push_true > > > ok 4 - test_heap_push_false > > > ok 5 - test_heap_pop_push_true > > > ok 6 - test_heap_pop_push_false > > > [snip] So ^ is TAP format? > > I don't care or care to use either; what does dmesg do? It used to be > > that just building the self-tests was sufficient and any error would > > show in dmesg when you boot the machine. > > > > But if I now have to use some damn tool, this is a regression. > > If you don't want to, you don't need to use the kunit-tool. If you > compile the tests as builtin and run the Kernel on your machine > the test result will be shown in dmesg in TAP format. That's seems a lot more verbose than it is now. I've recently even done a bunch of tests that don't print anything on success, dmesg is clutter enough already.
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
Hi Peter, On Tue, Aug 4, 2020 at 10:25 AM wrote: > > On Wed, Jul 29, 2020 at 06:57:17PM -0300, Vitor Massaru Iha wrote: > > > The results can be seen this way: > > > > This is an excerpt from the test.log with the result in TAP format: > > [snip] > > ok 5 - example > > # Subtest: min-heap > > 1..6 > > ok 1 - test_heapify_all_true > > ok 2 - test_heapify_all_false > > ok 3 - test_heap_push_true > > ok 4 - test_heap_push_false > > ok 5 - test_heap_pop_push_true > > ok 6 - test_heap_pop_push_false > > [snip] > > > > And this from kunit-tool: > > [snip] > > [18:43:32] > > [18:43:32] [PASSED] min-heap > > [18:43:32] [PASSED] test_heapify_all_true > > [18:43:32] [PASSED] test_heapify_all_false > > [18:43:32] [PASSED] test_heap_push_true > > [18:43:32] [PASSED] test_heap_push_false > > [18:43:32] [PASSED] test_heap_pop_push_true > > [18:43:32] [PASSED] test_heap_pop_push_false > > [18:43:32] > > [18:43:32] Testing complete. 20 tests run. 0 failed. 0 crashed. > > [18:43:32] Elapsed time: 9.758s total, 0.001s configuring, 6.012s > > building, 0.000s running > > [snip] > > I don't care or care to use either; what does dmesg do? It used to be > that just building the self-tests was sufficient and any error would > show in dmesg when you boot the machine. > > But if I now have to use some damn tool, this is a regression. If you don't want to, you don't need to use the kunit-tool. If you compile the tests as builtin and run the Kernel on your machine the test result will be shown in dmesg in TAP format. BR, Vitor
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
On Wed, Jul 29, 2020 at 06:57:17PM -0300, Vitor Massaru Iha wrote: > The results can be seen this way: > > This is an excerpt from the test.log with the result in TAP format: > [snip] > ok 5 - example > # Subtest: min-heap > 1..6 > ok 1 - test_heapify_all_true > ok 2 - test_heapify_all_false > ok 3 - test_heap_push_true > ok 4 - test_heap_push_false > ok 5 - test_heap_pop_push_true > ok 6 - test_heap_pop_push_false > [snip] > > And this from kunit-tool: > [snip] > [18:43:32] > [18:43:32] [PASSED] min-heap > [18:43:32] [PASSED] test_heapify_all_true > [18:43:32] [PASSED] test_heapify_all_false > [18:43:32] [PASSED] test_heap_push_true > [18:43:32] [PASSED] test_heap_push_false > [18:43:32] [PASSED] test_heap_pop_push_true > [18:43:32] [PASSED] test_heap_pop_push_false > [18:43:32] > [18:43:32] Testing complete. 20 tests run. 0 failed. 0 crashed. > [18:43:32] Elapsed time: 9.758s total, 0.001s configuring, 6.012s > building, 0.000s running > [snip] I don't care or care to use either; what does dmesg do? It used to be that just building the self-tests was sufficient and any error would show in dmesg when you boot the machine. But if I now have to use some damn tool, this is a regression.
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
Hi Ian,
On Wed, Jul 29, 2020 at 7:57 PM 'Ian Rogers' via KUnit Development
wrote:
>
> On Wed, Jul 29, 2020 at 1:11 PM Vitor Massaru Iha wrote:
> >
> > This adds the conversion of the runtime tests of test_min_heap,
> > from `lib/test_min_heap.c` to KUnit tests.
> >
> > Please apply this commit first (linux-kselftest/kunit-fixes):
> > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing
> > of CONFIG options with space
>
> Thanks for this, I'm a fan of testing frameworks :-)
>
> > Signed-off-by: Vitor Massaru Iha
> > ---
> > lib/Kconfig.debug | 29 --
> > lib/Makefile | 2 +-
> > lib/{test_min_heap.c => min_heap_kunit.c} | 117 --
> > 3 files changed, 83 insertions(+), 65 deletions(-)
> > rename lib/{test_min_heap.c => min_heap_kunit.c} (60%)
> >
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index 9ad9210d70a1..46674fc4972c 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -1864,16 +1864,6 @@ config TEST_LIST_SORT
> >
> > If unsure, say N.
> >
> > -config TEST_MIN_HEAP
> > - tristate "Min heap test"
> > - depends on DEBUG_KERNEL || m
> > - help
> > - Enable this to turn on min heap function tests. This test is
> > - executed only once during system boot (so affects only boot time),
> > - or at module load time.
> > -
> > - If unsure, say N.
> > -
> > config TEST_SORT
> > tristate "Array-based sort test"
> > depends on DEBUG_KERNEL || m
> > @@ -2185,6 +2175,25 @@ config LINEAR_RANGES_TEST
> >
> > If unsure, say N.
> >
> > +config MIN_HEAP_KUNIT
> > +tristate "KUnit test for Min heap"
> > +depends on KUNIT
> > +depends on DEBUG_KERNEL || m
> > +help
> > + Enable this to turn on min heap function tests. This test is
> > + executed only once during system boot (so affects only boot
> > time),
> > + or at module load time.
> > +
> > + KUnit tests run during boot and output the results to the debug
> > log
> > + in TAP format (http://testanything.org/). Only useful for kernel
> > devs
> > + running the KUnit test harness, and not intended for inclusion
> > into a
> > + production build.
> > +
> > + For more information on KUnit and unit tests in general please
> > refer
> > + to the KUnit documentation in Documentation/dev-tools/kunit/.
> > +
> > + If unsure, say N.
> > +
>
> It's a shame we need a config option for this. Could we have one
> option to cover all basic library tests?
Sure, I think so.
>
> > config TEST_UDELAY
> > tristate "udelay test driver"
> > help
> > diff --git a/lib/Makefile b/lib/Makefile
> > index b1c42c10073b..748f57063160 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -72,7 +72,6 @@ CFLAGS_test_ubsan.o += $(call cc-disable-warning, vla)
> > UBSAN_SANITIZE_test_ubsan.o := y
> > obj-$(CONFIG_TEST_KSTRTOX) += test-kstrtox.o
> > obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o
> > -obj-$(CONFIG_TEST_MIN_HEAP) += test_min_heap.o
> > obj-$(CONFIG_TEST_LKM) += test_module.o
> > obj-$(CONFIG_TEST_VMALLOC) += test_vmalloc.o
> > obj-$(CONFIG_TEST_OVERFLOW) += test_overflow.o
> > @@ -318,3 +317,4 @@ obj-$(CONFIG_OBJAGG) += objagg.o
> > # KUnit tests
> > obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
> > obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
> > +obj-$(CONFIG_MIN_HEAP_KUNIT) += min_heap_kunit.o
> > diff --git a/lib/test_min_heap.c b/lib/min_heap_kunit.c
> > similarity index 60%
> > rename from lib/test_min_heap.c
> > rename to lib/min_heap_kunit.c
> > index d19c8080fd4d..398db1c63146 100644
> > --- a/lib/test_min_heap.c
> > +++ b/lib/min_heap_kunit.c
> > @@ -7,9 +7,8 @@
> >
> > #include
> > #include
> > -#include
> > -#include
> > #include
> > +#include
> >
> > static __init bool less_than(const void *lhs, const void *rhs)
> > {
> > @@ -29,37 +28,34 @@ static __init void swap_ints(void *lhs, void *rhs)
> > *(int *)rhs = temp;
> > }
> >
> > -static __init int pop_verify_heap(bool min_heap,
> > +static __init void pop_verify_heap(struct kunit *context,
> > + bool min_heap,
> > struct min_heap *heap,
> > const struct min_heap_callbacks *funcs)
> > {
> > int *values = heap->data;
> > - int err = 0;
> > int last;
> >
> > last = values[0];
> > min_heap_pop(heap, funcs);
> > while (heap->nr > 0) {
> > if (min_heap) {
> > - if (last > values[0]) {
> > - pr_err("error: expected %d <= %d\n", last,
> > - values[0]);
> > - err++;
> > - }
> > +
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
On Wed, Jul 29, 2020 at 1:11 PM Vitor Massaru Iha wrote:
>
> This adds the conversion of the runtime tests of test_min_heap,
> from `lib/test_min_heap.c` to KUnit tests.
>
> Please apply this commit first (linux-kselftest/kunit-fixes):
> 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of
> CONFIG options with space
Thanks for this, I'm a fan of testing frameworks :-)
> Signed-off-by: Vitor Massaru Iha
> ---
> lib/Kconfig.debug | 29 --
> lib/Makefile | 2 +-
> lib/{test_min_heap.c => min_heap_kunit.c} | 117 --
> 3 files changed, 83 insertions(+), 65 deletions(-)
> rename lib/{test_min_heap.c => min_heap_kunit.c} (60%)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 9ad9210d70a1..46674fc4972c 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1864,16 +1864,6 @@ config TEST_LIST_SORT
>
> If unsure, say N.
>
> -config TEST_MIN_HEAP
> - tristate "Min heap test"
> - depends on DEBUG_KERNEL || m
> - help
> - Enable this to turn on min heap function tests. This test is
> - executed only once during system boot (so affects only boot time),
> - or at module load time.
> -
> - If unsure, say N.
> -
> config TEST_SORT
> tristate "Array-based sort test"
> depends on DEBUG_KERNEL || m
> @@ -2185,6 +2175,25 @@ config LINEAR_RANGES_TEST
>
> If unsure, say N.
>
> +config MIN_HEAP_KUNIT
> +tristate "KUnit test for Min heap"
> +depends on KUNIT
> +depends on DEBUG_KERNEL || m
> +help
> + Enable this to turn on min heap function tests. This test is
> + executed only once during system boot (so affects only boot time),
> + or at module load time.
> +
> + KUnit tests run during boot and output the results to the debug log
> + in TAP format (http://testanything.org/). Only useful for kernel
> devs
> + running the KUnit test harness, and not intended for inclusion
> into a
> + production build.
> +
> + For more information on KUnit and unit tests in general please
> refer
> + to the KUnit documentation in Documentation/dev-tools/kunit/.
> +
> + If unsure, say N.
> +
It's a shame we need a config option for this. Could we have one
option to cover all basic library tests?
> config TEST_UDELAY
> tristate "udelay test driver"
> help
> diff --git a/lib/Makefile b/lib/Makefile
> index b1c42c10073b..748f57063160 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -72,7 +72,6 @@ CFLAGS_test_ubsan.o += $(call cc-disable-warning, vla)
> UBSAN_SANITIZE_test_ubsan.o := y
> obj-$(CONFIG_TEST_KSTRTOX) += test-kstrtox.o
> obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o
> -obj-$(CONFIG_TEST_MIN_HEAP) += test_min_heap.o
> obj-$(CONFIG_TEST_LKM) += test_module.o
> obj-$(CONFIG_TEST_VMALLOC) += test_vmalloc.o
> obj-$(CONFIG_TEST_OVERFLOW) += test_overflow.o
> @@ -318,3 +317,4 @@ obj-$(CONFIG_OBJAGG) += objagg.o
> # KUnit tests
> obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
> obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
> +obj-$(CONFIG_MIN_HEAP_KUNIT) += min_heap_kunit.o
> diff --git a/lib/test_min_heap.c b/lib/min_heap_kunit.c
> similarity index 60%
> rename from lib/test_min_heap.c
> rename to lib/min_heap_kunit.c
> index d19c8080fd4d..398db1c63146 100644
> --- a/lib/test_min_heap.c
> +++ b/lib/min_heap_kunit.c
> @@ -7,9 +7,8 @@
>
> #include
> #include
> -#include
> -#include
> #include
> +#include
>
> static __init bool less_than(const void *lhs, const void *rhs)
> {
> @@ -29,37 +28,34 @@ static __init void swap_ints(void *lhs, void *rhs)
> *(int *)rhs = temp;
> }
>
> -static __init int pop_verify_heap(bool min_heap,
> +static __init void pop_verify_heap(struct kunit *context,
> + bool min_heap,
> struct min_heap *heap,
> const struct min_heap_callbacks *funcs)
> {
> int *values = heap->data;
> - int err = 0;
> int last;
>
> last = values[0];
> min_heap_pop(heap, funcs);
> while (heap->nr > 0) {
> if (min_heap) {
> - if (last > values[0]) {
> - pr_err("error: expected %d <= %d\n", last,
> - values[0]);
> - err++;
> - }
> + KUNIT_EXPECT_FALSE_MSG(context,
> + last > values[0],
> + "expected %d <= %d\n",
> + last, values[0]);
I'm not familiar with kunit, is there a reason not to prefer:
KUNIT_EXPECT_LT(context, last, values[0]);
> } else {
> - if
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
Hi Peter,
On Wed, Jul 29, 2020 at 5:39 PM wrote:
>
> On Wed, Jul 29, 2020 at 05:11:46PM -0300, Vitor Massaru Iha wrote:
> > This adds the conversion of the runtime tests of test_min_heap,
> > from `lib/test_min_heap.c` to KUnit tests.
> >
> > Please apply this commit first (linux-kselftest/kunit-fixes):
> > 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing
> > of CONFIG options with space
> >
> > Signed-off-by: Vitor Massaru Iha
> > ---
> > lib/Kconfig.debug | 29 --
> > lib/Makefile | 2 +-
> > lib/{test_min_heap.c => min_heap_kunit.c} | 117 --
> > 3 files changed, 83 insertions(+), 65 deletions(-)
> > rename lib/{test_min_heap.c => min_heap_kunit.c} (60%)
>
> So where's the win? What's KUnit, why should I care and more lines.
KUnit is a unit testing and mocking framework for the Linux kernel. [0]
In Kconfig.debug you only have some more information about KUnit.
If the number of lines is a parameter that should be considered, I can
change sections like this
- if (last > values[0]) {
- pr_err("error: expected %d <= %d\n", last,
- values[0]);
- err++;
- }
+ KUNIT_EXPECT_FALSE_MSG(context,
+ last > values[0],
+ "expected %d <= %d\n",
+ last, values[0]);
To this:
- if (last > values[0]) {
- pr_err("error: expected %d <= %d\n", last,
- values[0]);
- err++;
- }
+ KUNIT_EXPECT_FALSE_MSG(context, last >
values[0], "expected %d <= %d\n", last, values[0]);
And from this:
+static struct kunit_case __refdata min_heap_test_cases[] = {
+ KUNIT_CASE(test_heapify_all_true),
+ KUNIT_CASE(test_heapify_all_false),
+ KUNIT_CASE(test_heap_push_true),
+ KUNIT_CASE(test_heap_push_false),
+ KUNIT_CASE(test_heap_pop_push_true),
+ KUNIT_CASE(test_heap_pop_push_false),
+ {}
To this:
+static struct kunit_case __refdata min_heap_test_cases[] = {
+ KUNIT_CASE(test_min_heap),
+ {}
I did the latter this way to be more informative, but if the goal is
to reduce lines of code, this is possible.
The results can be seen this way:
This is an excerpt from the test.log with the result in TAP format:
[snip]
ok 5 - example
# Subtest: min-heap
1..6
ok 1 - test_heapify_all_true
ok 2 - test_heapify_all_false
ok 3 - test_heap_push_true
ok 4 - test_heap_push_false
ok 5 - test_heap_pop_push_true
ok 6 - test_heap_pop_push_false
[snip]
And this from kunit-tool:
[snip]
[18:43:32]
[18:43:32] [PASSED] min-heap
[18:43:32] [PASSED] test_heapify_all_true
[18:43:32] [PASSED] test_heapify_all_false
[18:43:32] [PASSED] test_heap_push_true
[18:43:32] [PASSED] test_heap_push_false
[18:43:32] [PASSED] test_heap_pop_push_true
[18:43:32] [PASSED] test_heap_pop_push_false
[18:43:32]
[18:43:32] Testing complete. 20 tests run. 0 failed. 0 crashed.
[18:43:32] Elapsed time: 9.758s total, 0.001s configuring, 6.012s
building, 0.000s running
[snip]
BR,
Vitor
[0]
https://www.kernel.org/doc/html/latest/dev-tools/kunit/index.html#what-is-kunit
Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit
On Wed, Jul 29, 2020 at 05:11:46PM -0300, Vitor Massaru Iha wrote:
> This adds the conversion of the runtime tests of test_min_heap,
> from `lib/test_min_heap.c` to KUnit tests.
>
> Please apply this commit first (linux-kselftest/kunit-fixes):
> 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of
> CONFIG options with space
>
> Signed-off-by: Vitor Massaru Iha
> ---
> lib/Kconfig.debug | 29 --
> lib/Makefile | 2 +-
> lib/{test_min_heap.c => min_heap_kunit.c} | 117 --
> 3 files changed, 83 insertions(+), 65 deletions(-)
> rename lib/{test_min_heap.c => min_heap_kunit.c} (60%)
So where's the win? What's KUnit, why should I care and more lines.
[PATCH] lib: kunit: add test_min_heap test conversion to KUnit
This adds the conversion of the runtime tests of test_min_heap,
from `lib/test_min_heap.c` to KUnit tests.
Please apply this commit first (linux-kselftest/kunit-fixes):
3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of
CONFIG options with space
Signed-off-by: Vitor Massaru Iha
---
lib/Kconfig.debug | 29 --
lib/Makefile | 2 +-
lib/{test_min_heap.c => min_heap_kunit.c} | 117 --
3 files changed, 83 insertions(+), 65 deletions(-)
rename lib/{test_min_heap.c => min_heap_kunit.c} (60%)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 9ad9210d70a1..46674fc4972c 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1864,16 +1864,6 @@ config TEST_LIST_SORT
If unsure, say N.
-config TEST_MIN_HEAP
- tristate "Min heap test"
- depends on DEBUG_KERNEL || m
- help
- Enable this to turn on min heap function tests. This test is
- executed only once during system boot (so affects only boot time),
- or at module load time.
-
- If unsure, say N.
-
config TEST_SORT
tristate "Array-based sort test"
depends on DEBUG_KERNEL || m
@@ -2185,6 +2175,25 @@ config LINEAR_RANGES_TEST
If unsure, say N.
+config MIN_HEAP_KUNIT
+tristate "KUnit test for Min heap"
+depends on KUNIT
+depends on DEBUG_KERNEL || m
+help
+ Enable this to turn on min heap function tests. This test is
+ executed only once during system boot (so affects only boot time),
+ or at module load time.
+
+ KUnit tests run during boot and output the results to the debug log
+ in TAP format (http://testanything.org/). Only useful for kernel devs
+ running the KUnit test harness, and not intended for inclusion into a
+ production build.
+
+ For more information on KUnit and unit tests in general please refer
+ to the KUnit documentation in Documentation/dev-tools/kunit/.
+
+ If unsure, say N.
+
config TEST_UDELAY
tristate "udelay test driver"
help
diff --git a/lib/Makefile b/lib/Makefile
index b1c42c10073b..748f57063160 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -72,7 +72,6 @@ CFLAGS_test_ubsan.o += $(call cc-disable-warning, vla)
UBSAN_SANITIZE_test_ubsan.o := y
obj-$(CONFIG_TEST_KSTRTOX) += test-kstrtox.o
obj-$(CONFIG_TEST_LIST_SORT) += test_list_sort.o
-obj-$(CONFIG_TEST_MIN_HEAP) += test_min_heap.o
obj-$(CONFIG_TEST_LKM) += test_module.o
obj-$(CONFIG_TEST_VMALLOC) += test_vmalloc.o
obj-$(CONFIG_TEST_OVERFLOW) += test_overflow.o
@@ -318,3 +317,4 @@ obj-$(CONFIG_OBJAGG) += objagg.o
# KUnit tests
obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
+obj-$(CONFIG_MIN_HEAP_KUNIT) += min_heap_kunit.o
diff --git a/lib/test_min_heap.c b/lib/min_heap_kunit.c
similarity index 60%
rename from lib/test_min_heap.c
rename to lib/min_heap_kunit.c
index d19c8080fd4d..398db1c63146 100644
--- a/lib/test_min_heap.c
+++ b/lib/min_heap_kunit.c
@@ -7,9 +7,8 @@
#include
#include
-#include
-#include
#include
+#include
static __init bool less_than(const void *lhs, const void *rhs)
{
@@ -29,37 +28,34 @@ static __init void swap_ints(void *lhs, void *rhs)
*(int *)rhs = temp;
}
-static __init int pop_verify_heap(bool min_heap,
+static __init void pop_verify_heap(struct kunit *context,
+ bool min_heap,
struct min_heap *heap,
const struct min_heap_callbacks *funcs)
{
int *values = heap->data;
- int err = 0;
int last;
last = values[0];
min_heap_pop(heap, funcs);
while (heap->nr > 0) {
if (min_heap) {
- if (last > values[0]) {
- pr_err("error: expected %d <= %d\n", last,
- values[0]);
- err++;
- }
+ KUNIT_EXPECT_FALSE_MSG(context,
+ last > values[0],
+ "expected %d <= %d\n",
+ last, values[0]);
} else {
- if (last < values[0]) {
- pr_err("error: expected %d >= %d\n", last,
- values[0]);
- err++;
- }
+ KUNIT_EXPECT_FALSE_MSG(context,
+ last < values[0],
+ "expected %d >= %d\n",
+ last, values[0]);
}
last = values[0];
min_heap_pop(heap, funcs);
}
-
