Re: [PATCH] lightnvm: remove duplicate include in lightnvm.h

2021-04-13 Thread Matias Bjørling

On 13/03/2021 12.22, menglong8.d...@gmail.com wrote:

From: Zhang Yunkai 

'linux/ioctl.h' included in 'lightnvm.h' is duplicated.
It is also included in the 33th line.

Signed-off-by: Zhang Yunkai 
---
  include/uapi/linux/lightnvm.h | 1 -
  1 file changed, 1 deletion(-)

diff --git a/include/uapi/linux/lightnvm.h b/include/uapi/linux/lightnvm.h
index ead2e72e5c88..2745afd9b8fa 100644
--- a/include/uapi/linux/lightnvm.h
+++ b/include/uapi/linux/lightnvm.h
@@ -22,7 +22,6 @@
  
  #ifdef __KERNEL__

  #include 
-#include 
  #else /* __KERNEL__ */
  #include 
  #include 
Thanks, Yunkai. I've pulled it. Note that I've merged your two patches 
into one.


[PATCH] lightnvm: remove duplicate include in lightnvm.h

2021-03-13 Thread menglong8 . dong
From: Zhang Yunkai 

'linux/ioctl.h' included in 'lightnvm.h' is duplicated.
It is also included in the 33th line.

Signed-off-by: Zhang Yunkai 
---
 include/uapi/linux/lightnvm.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/uapi/linux/lightnvm.h b/include/uapi/linux/lightnvm.h
index ead2e72e5c88..2745afd9b8fa 100644
--- a/include/uapi/linux/lightnvm.h
+++ b/include/uapi/linux/lightnvm.h
@@ -22,7 +22,6 @@
 
 #ifdef __KERNEL__
 #include 
-#include 
 #else /* __KERNEL__ */
 #include 
 #include 
-- 
2.25.1



[PATCH] lightnvm: remove duplicate include in lightnvm.h

2021-03-13 Thread menglong8 . dong
From: Zhang Yunkai 

'linux/blkdev.h' and 'uapi/linux/lightnvm.h' included in 'lightnvm.h'
is duplicated.It is also included in the 5th and 7th line.

Signed-off-by: Zhang Yunkai 
---
 include/linux/lightnvm.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
index 1db223710b28..0908abda9c1b 100644
--- a/include/linux/lightnvm.h
+++ b/include/linux/lightnvm.h
@@ -112,10 +112,8 @@ struct nvm_dev_ops {
 
 #ifdef CONFIG_NVM
 
-#include 
 #include 
 #include 
-#include 
 
 enum {
/* HW Responsibilities */
-- 
2.25.1