Re: [PATCH] mac802154: select CRYPTO when needed
Hi Arnd, > The mac802154 subsystem uses functions from the crypto layer and correctly > selects the individual crypto algorithms, but fails to build when the > crypto layer is disabled altogether: > > crypto/built-in.o: In function `crypto_ctr_free': > :(.text+0x80): undefined reference to `crypto_drop_spawn' > crypto/built-in.o: In function `crypto_rfc3686_free': > :(.text+0xac): undefined reference to `crypto_drop_spawn' > crypto/built-in.o: In function `crypto_ctr_crypt': > :(.text+0x2f0): undefined reference to `blkcipher_walk_virt_block' > :(.text+0x2f8): undefined reference to `crypto_inc' > > To solve that, this patch also selects the core crypto code, > like all other users of that code do. > > Signed-off-by: Arnd Bergmann patch has been applied to bluetooth-next tree. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mac802154: select CRYPTO when needed
Hello. On 19/05/15 14:18, Arnd Bergmann wrote: The mac802154 subsystem uses functions from the crypto layer and correctly selects the individual crypto algorithms, but fails to build when the crypto layer is disabled altogether: crypto/built-in.o: In function `crypto_ctr_free': :(.text+0x80): undefined reference to `crypto_drop_spawn' crypto/built-in.o: In function `crypto_rfc3686_free': :(.text+0xac): undefined reference to `crypto_drop_spawn' crypto/built-in.o: In function `crypto_ctr_crypt': :(.text+0x2f0): undefined reference to `blkcipher_walk_virt_block' :(.text+0x2f8): undefined reference to `crypto_inc' To solve that, this patch also selects the core crypto code, like all other users of that code do. Signed-off-by: Arnd Bergmann --- Found in ARM randconfig testing diff --git a/net/mac802154/Kconfig b/net/mac802154/Kconfig index aa462b480a39..b355989c63b3 100644 --- a/net/mac802154/Kconfig +++ b/net/mac802154/Kconfig @@ -1,6 +1,7 @@ config MAC802154 tristate "Generic IEEE 802.15.4 Soft Networking Stack (mac802154)" depends on IEEE802154 + select CRYPTO select CRC_CCITT select CRYPTO_AUTHENC select CRYPTO_CCM Good point. I thought that would have been pulled in by CRYPTO_* automatically. Nicely spotted. Reviewed-by: Stefan Schmidt regards Stefan Schmidt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] mac802154: select CRYPTO when needed
The mac802154 subsystem uses functions from the crypto layer and correctly selects the individual crypto algorithms, but fails to build when the crypto layer is disabled altogether: crypto/built-in.o: In function `crypto_ctr_free': :(.text+0x80): undefined reference to `crypto_drop_spawn' crypto/built-in.o: In function `crypto_rfc3686_free': :(.text+0xac): undefined reference to `crypto_drop_spawn' crypto/built-in.o: In function `crypto_ctr_crypt': :(.text+0x2f0): undefined reference to `blkcipher_walk_virt_block' :(.text+0x2f8): undefined reference to `crypto_inc' To solve that, this patch also selects the core crypto code, like all other users of that code do. Signed-off-by: Arnd Bergmann --- Found in ARM randconfig testing diff --git a/net/mac802154/Kconfig b/net/mac802154/Kconfig index aa462b480a39..b355989c63b3 100644 --- a/net/mac802154/Kconfig +++ b/net/mac802154/Kconfig @@ -1,6 +1,7 @@ config MAC802154 tristate "Generic IEEE 802.15.4 Soft Networking Stack (mac802154)" depends on IEEE802154 + select CRYPTO select CRC_CCITT select CRYPTO_AUTHENC select CRYPTO_CCM -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] mac802154: select CRYPTO when needed
The mac802154 subsystem uses functions from the crypto layer and correctly selects the individual crypto algorithms, but fails to build when the crypto layer is disabled altogether: crypto/built-in.o: In function `crypto_ctr_free': :(.text+0x80): undefined reference to `crypto_drop_spawn' crypto/built-in.o: In function `crypto_rfc3686_free': :(.text+0xac): undefined reference to `crypto_drop_spawn' crypto/built-in.o: In function `crypto_ctr_crypt': :(.text+0x2f0): undefined reference to `blkcipher_walk_virt_block' :(.text+0x2f8): undefined reference to `crypto_inc' To solve that, this patch also selects the core crypto code, like all other users of that code do. Signed-off-by: Arnd Bergmann a...@arndb.de --- Found in ARM randconfig testing diff --git a/net/mac802154/Kconfig b/net/mac802154/Kconfig index aa462b480a39..b355989c63b3 100644 --- a/net/mac802154/Kconfig +++ b/net/mac802154/Kconfig @@ -1,6 +1,7 @@ config MAC802154 tristate Generic IEEE 802.15.4 Soft Networking Stack (mac802154) depends on IEEE802154 + select CRYPTO select CRC_CCITT select CRYPTO_AUTHENC select CRYPTO_CCM -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mac802154: select CRYPTO when needed
Hello. On 19/05/15 14:18, Arnd Bergmann wrote: The mac802154 subsystem uses functions from the crypto layer and correctly selects the individual crypto algorithms, but fails to build when the crypto layer is disabled altogether: crypto/built-in.o: In function `crypto_ctr_free': :(.text+0x80): undefined reference to `crypto_drop_spawn' crypto/built-in.o: In function `crypto_rfc3686_free': :(.text+0xac): undefined reference to `crypto_drop_spawn' crypto/built-in.o: In function `crypto_ctr_crypt': :(.text+0x2f0): undefined reference to `blkcipher_walk_virt_block' :(.text+0x2f8): undefined reference to `crypto_inc' To solve that, this patch also selects the core crypto code, like all other users of that code do. Signed-off-by: Arnd Bergmann a...@arndb.de --- Found in ARM randconfig testing diff --git a/net/mac802154/Kconfig b/net/mac802154/Kconfig index aa462b480a39..b355989c63b3 100644 --- a/net/mac802154/Kconfig +++ b/net/mac802154/Kconfig @@ -1,6 +1,7 @@ config MAC802154 tristate Generic IEEE 802.15.4 Soft Networking Stack (mac802154) depends on IEEE802154 + select CRYPTO select CRC_CCITT select CRYPTO_AUTHENC select CRYPTO_CCM Good point. I thought that would have been pulled in by CRYPTO_* automatically. Nicely spotted. Reviewed-by: Stefan Schmidt ste...@osg.samsung.com regards Stefan Schmidt -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mac802154: select CRYPTO when needed
Hi Arnd, The mac802154 subsystem uses functions from the crypto layer and correctly selects the individual crypto algorithms, but fails to build when the crypto layer is disabled altogether: crypto/built-in.o: In function `crypto_ctr_free': :(.text+0x80): undefined reference to `crypto_drop_spawn' crypto/built-in.o: In function `crypto_rfc3686_free': :(.text+0xac): undefined reference to `crypto_drop_spawn' crypto/built-in.o: In function `crypto_ctr_crypt': :(.text+0x2f0): undefined reference to `blkcipher_walk_virt_block' :(.text+0x2f8): undefined reference to `crypto_inc' To solve that, this patch also selects the core crypto code, like all other users of that code do. Signed-off-by: Arnd Bergmann a...@arndb.de patch has been applied to bluetooth-next tree. Regards Marcel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/