Re: [PATCH] mfd: pcf50633: Init pcf->dev before using it
Hi Axel, On Fri, Jan 25, 2013 at 11:08:00AM +0800, Axel Lin wrote: > 2013/1/22 Samuel Ortiz > > > Hi Axel, > > > > On Tue, Dec 25, 2012 at 10:52:49AM +0800, Axel Lin wrote: > > > Current code uses pcf->dev in the dev_err call before setting it to > > > >dev. Fix it. > > > > > > Signed-off-by: Axel Lin > > > --- > > > drivers/mfd/pcf50633-core.c |5 ++--- > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > Applied to my for-linus branch, thanks. > > > > Hi Samuel, > Seems the patches queued in your for-linus branch does not (yet) appear in > linux-next? for-linus goes to Linus and then they show up in linux-next. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mfd: pcf50633: Init pcf-dev before using it
Hi Axel, On Fri, Jan 25, 2013 at 11:08:00AM +0800, Axel Lin wrote: 2013/1/22 Samuel Ortiz sa...@linux.intel.com Hi Axel, On Tue, Dec 25, 2012 at 10:52:49AM +0800, Axel Lin wrote: Current code uses pcf-dev in the dev_err call before setting it to client-dev. Fix it. Signed-off-by: Axel Lin axel@ingics.com --- drivers/mfd/pcf50633-core.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Applied to my for-linus branch, thanks. Hi Samuel, Seems the patches queued in your for-linus branch does not (yet) appear in linux-next? for-linus goes to Linus and then they show up in linux-next. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mfd: pcf50633: Init pcf->dev before using it
Hi Axel, On Tue, Dec 25, 2012 at 10:52:49AM +0800, Axel Lin wrote: > Current code uses pcf->dev in the dev_err call before setting it to > >dev. Fix it. > > Signed-off-by: Axel Lin > --- > drivers/mfd/pcf50633-core.c |5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Applied to my for-linus branch, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mfd: pcf50633: Init pcf-dev before using it
Hi Axel, On Tue, Dec 25, 2012 at 10:52:49AM +0800, Axel Lin wrote: Current code uses pcf-dev in the dev_err call before setting it to client-dev. Fix it. Signed-off-by: Axel Lin axel@ingics.com --- drivers/mfd/pcf50633-core.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Applied to my for-linus branch, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] mfd: pcf50633: Init pcf->dev before using it
Current code uses pcf->dev in the dev_err call before setting it to
>dev. Fix it.
Signed-off-by: Axel Lin
---
drivers/mfd/pcf50633-core.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
index 64803f1..d115673 100644
--- a/drivers/mfd/pcf50633-core.c
+++ b/drivers/mfd/pcf50633-core.c
@@ -208,6 +208,8 @@ static int pcf50633_probe(struct i2c_client *client,
if (!pcf)
return -ENOMEM;
+ i2c_set_clientdata(client, pcf);
+ pcf->dev = >dev;
pcf->pdata = pdata;
mutex_init(>lock);
@@ -219,9 +221,6 @@ static int pcf50633_probe(struct i2c_client *client,
return ret;
}
- i2c_set_clientdata(client, pcf);
- pcf->dev = >dev;
-
version = pcf50633_reg_read(pcf, 0);
variant = pcf50633_reg_read(pcf, 1);
if (version < 0 || variant < 0) {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] mfd: pcf50633: Init pcf-dev before using it
Current code uses pcf-dev in the dev_err call before setting it to
client-dev. Fix it.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/mfd/pcf50633-core.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
index 64803f1..d115673 100644
--- a/drivers/mfd/pcf50633-core.c
+++ b/drivers/mfd/pcf50633-core.c
@@ -208,6 +208,8 @@ static int pcf50633_probe(struct i2c_client *client,
if (!pcf)
return -ENOMEM;
+ i2c_set_clientdata(client, pcf);
+ pcf-dev = client-dev;
pcf-pdata = pdata;
mutex_init(pcf-lock);
@@ -219,9 +221,6 @@ static int pcf50633_probe(struct i2c_client *client,
return ret;
}
- i2c_set_clientdata(client, pcf);
- pcf-dev = client-dev;
-
version = pcf50633_reg_read(pcf, 0);
variant = pcf50633_reg_read(pcf, 1);
if (version 0 || variant 0) {
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
