Re: [PATCH] mm/compaction: Remove duplicated VM_BUG_ON_PAGE !PageLocked

[David Hildenbrand]

On 09.01.21 09:14, Miaohe Lin wrote:
> The VM_BUG_ON_PAGE(!PageLocked(page), page) is also done in PageMovable.
> Remove this explicitly one.
> 
> Signed-off-by: Miaohe Lin 
> ---
>  mm/compaction.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 02af220fb992..6d316eb99913 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -137,7 +137,6 @@ EXPORT_SYMBOL(__SetPageMovable);
>  
>  void __ClearPageMovable(struct page *page)
>  {
> - VM_BUG_ON_PAGE(!PageLocked(page), page);
>   VM_BUG_ON_PAGE(!PageMovable(page), page);
>   /*
>* Clear registered address_space val with keeping PAGE_MAPPING_MOVABLE
> 

Reviewed-by: David Hildenbrand 

-- 
Thanks,

David / dhildenb

[PATCH] mm/compaction: Remove duplicated VM_BUG_ON_PAGE !PageLocked

[Miaohe Lin]

The VM_BUG_ON_PAGE(!PageLocked(page), page) is also done in PageMovable.
Remove this explicitly one.

Signed-off-by: Miaohe Lin 
---
 mm/compaction.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 02af220fb992..6d316eb99913 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -137,7 +137,6 @@ EXPORT_SYMBOL(__SetPageMovable);
 
 void __ClearPageMovable(struct page *page)
 {
-   VM_BUG_ON_PAGE(!PageLocked(page), page);
VM_BUG_ON_PAGE(!PageMovable(page), page);
/*
 * Clear registered address_space val with keeping PAGE_MAPPING_MOVABLE
-- 
2.19.1