Re: [PATCH] mm/zsmalloc.c: Convert to use kmem_cache_zalloc in cache_alloc_zspage()

[Sergey Senozhatsky]

On (21/01/14 07:00), Miaohe Lin wrote:
>
> We always memset the zspage allocated via cache_alloc_zspage. So it's more
> convenient to use kmem_cache_zalloc in cache_alloc_zspage than caller do it
> manually.
>
> Signed-off-by: Miaohe Lin 

Reviewed-by: Sergey Senozhatsky 

-ss

[PATCH] mm/zsmalloc.c: Convert to use kmem_cache_zalloc in cache_alloc_zspage()

[Miaohe Lin]

We always memset the zspage allocated via cache_alloc_zspage. So it's more
convenient to use kmem_cache_zalloc in cache_alloc_zspage than caller do it
manually.

Signed-off-by: Miaohe Lin 
---
 mm/zsmalloc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 7289f502ffac..cf0ed0e4e911 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -357,7 +357,7 @@ static void cache_free_handle(struct zs_pool *pool, 
unsigned long handle)
 
 static struct zspage *cache_alloc_zspage(struct zs_pool *pool, gfp_t flags)
 {
-   return kmem_cache_alloc(pool->zspage_cachep,
+   return kmem_cache_zalloc(pool->zspage_cachep,
flags & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
 }
 
@@ -1064,7 +1064,6 @@ static struct zspage *alloc_zspage(struct zs_pool *pool,
if (!zspage)
return NULL;
 
-   memset(zspage, 0, sizeof(struct zspage));
zspage->magic = ZSPAGE_MAGIC;
migrate_lock_init(zspage);
 
-- 
2.19.1