Re: [PATCH] mm: Move HOLES_IN_ZONE into mm

[Catalin Marinas]

On Sat, Apr 17, 2021 at 03:59:46PM +0800, Kefeng Wang wrote:
> commit a55749639dc1 ("ia64: drop marked broken DISCONTIGMEM and 
> VIRTUAL_MEM_MAP")
> drop VIRTUAL_MEM_MAP, so there is no need HOLES_IN_ZONE on ia64.
> 
> Also move HOLES_IN_ZONE into mm/Kconfig, select it if architecture needs
> this feature.
> 
> Signed-off-by: Kefeng Wang 
> ---
>  arch/arm64/Kconfig | 4 +---
>  arch/ia64/Kconfig  | 3 ---
>  arch/mips/Kconfig  | 3 ---
>  mm/Kconfig | 3 +++
>  4 files changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index f0b17d758912..3c5a53e0db91 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -202,6 +202,7 @@ config ARM64
>   select HAVE_KPROBES
>   select HAVE_KRETPROBES
>   select HAVE_GENERIC_VDSO
> + select HOLES_IN_ZONE
>   select IOMMU_DMA if IOMMU_SUPPORT
>   select IRQ_DOMAIN
>   select IRQ_FORCED_THREADING
> @@ -1053,9 +1054,6 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
>   def_bool y
>   depends on NUMA
>  
> -config HOLES_IN_ZONE
> - def_bool y
> -
>  source "kernel/Kconfig.hz"

For arm64:

Acked-by: Catalin Marinas 

[PATCH] mm: Move HOLES_IN_ZONE into mm

[Kefeng Wang]

commit a55749639dc1 ("ia64: drop marked broken DISCONTIGMEM and 
VIRTUAL_MEM_MAP")
drop VIRTUAL_MEM_MAP, so there is no need HOLES_IN_ZONE on ia64.

Also move HOLES_IN_ZONE into mm/Kconfig, select it if architecture needs
this feature.

Signed-off-by: Kefeng Wang 
---
 arch/arm64/Kconfig | 4 +---
 arch/ia64/Kconfig  | 3 ---
 arch/mips/Kconfig  | 3 ---
 mm/Kconfig | 3 +++
 4 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index f0b17d758912..3c5a53e0db91 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -202,6 +202,7 @@ config ARM64
select HAVE_KPROBES
select HAVE_KRETPROBES
select HAVE_GENERIC_VDSO
+   select HOLES_IN_ZONE
select IOMMU_DMA if IOMMU_SUPPORT
select IRQ_DOMAIN
select IRQ_FORCED_THREADING
@@ -1053,9 +1054,6 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
def_bool y
depends on NUMA
 
-config HOLES_IN_ZONE
-   def_bool y
-
 source "kernel/Kconfig.hz"
 
 config ARCH_SPARSEMEM_ENABLE
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index 279252e3e0f7..36499e99102d 100644
--- a/arch/ia64/Kconfig
+++ b/arch/ia64/Kconfig
@@ -308,9 +308,6 @@ config NODES_SHIFT
  MAX_NUMNODES will be 2^(This value).
  If in doubt, use the default.
 
-config HOLES_IN_ZONE
-   bool
-
 config HAVE_ARCH_NODEDATA_EXTENSION
def_bool y
depends on NUMA
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 7a174ea61ca5..c6d522fbd67d 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1233,9 +1233,6 @@ config HAVE_PLAT_MEMCPY
 config ISA_DMA_API
bool
 
-config HOLES_IN_ZONE
-   bool
-
 config SYS_SUPPORTS_RELOCATABLE
bool
help
diff --git a/mm/Kconfig b/mm/Kconfig
index a8a367c30053..afc57cbf1cea 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -128,6 +128,9 @@ config HAVE_FAST_GUP
depends on MMU
bool
 
+config HOLES_IN_ZONE
+   bool
+
 # Don't discard allocated memory used to track "memory" and "reserved" 
memblocks
 # after early boot, so it can still be used to test for validity of memory.
 # Also, memblocks are updated with memory hot(un)plug.
-- 
2.26.2