Re: [PATCH] mm: cleaning per architecture MM hook header files
On 30/06/2015 09:28, Vineet Gupta wrote: >> diff --git a/arch/arc/include/asm/Kbuild b/arch/arc/include/asm/Kbuild >> index 769b312c1abb..2febe6ff32ed 100644 >> --- a/arch/arc/include/asm/Kbuild >> +++ b/arch/arc/include/asm/Kbuild >> @@ -49,3 +49,4 @@ generic-y += ucontext.h >> generic-y += user.h >> generic-y += vga.h >> generic-y += xor.h >> +generic-y += mm-arch-hooks.h >> diff --git a/arch/arc/include/asm/mm-arch-hooks.h >> b/arch/arc/include/asm/mm-arch-hooks.h >> deleted file mode 100644 >> index c37541c5f8ba.. >> --- a/arch/arc/include/asm/mm-arch-hooks.h >> +++ /dev/null >> @@ -1,15 +0,0 @@ >> -/* >> - * Architecture specific mm hooks >> - * >> - * Copyright (C) 2015, IBM Corporation >> - * Author: Laurent Dufour >> - * >> - * This program is free software; you can redistribute it and/or modify >> - * it under the terms of the GNU General Public License version 2 as >> - * published by the Free Software Foundation. >> - */ >> - >> -#ifndef _ASM_ARC_MM_ARCH_HOOKS_H >> -#define _ASM_ARC_MM_ARCH_HOOKS_H >> - >> -#endif /* _ASM_ARC_MM_ARCH_HOOKS_H */ >> diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild >> index 83c50193626c..870a2f7cbada 100644 >> --- a/arch/arm/include/asm/Kbuild >> +++ b/arch/arm/include/asm/Kbuild >> @@ -36,3 +36,4 @@ generic-y += termios.h >> generic-y += timex.h >> generic-y += trace_clock.h >> generic-y += unaligned.h >> +generic-y += mm-arch-hooks.h > > We keep this file sorted by headers so please can u respin with right > ordering ! Sure, I will send a new version. Thanks for the review, Laurent. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mm: cleaning per architecture MM hook header files
On Monday 29 June 2015 07:55 PM, Laurent Dufour wrote:
> The commit 2ae416b142b6 ("mm: new mm hook framework") introduced an empty
> header file (mm-arch-hooks.h) for every architecture, even those which
> doesn't need to define mm hooks.
>
> As suggested by Geert Uytterhoeven, this could be cleaned through the use
> of a generic header file included via each per architecture
> asm/include/Kbuild file.
>
> The powerpc architecture is not impacted here since this architecture has
> to defined the arch_remap MM hook.
>
> Signed-off-by: Laurent Dufour
> Suggested-by: Geert Uytterhoeven
> CC: Andrew Morton
> CC: linux-a...@vger.kernel.org
> CC: linux...@kvack.org
> CC: linux-kernel@vger.kernel.org
> ---
snipped
> diff --git a/arch/arc/include/asm/Kbuild b/arch/arc/include/asm/Kbuild
> index 769b312c1abb..2febe6ff32ed 100644
> --- a/arch/arc/include/asm/Kbuild
> +++ b/arch/arc/include/asm/Kbuild
> @@ -49,3 +49,4 @@ generic-y += ucontext.h
> generic-y += user.h
> generic-y += vga.h
> generic-y += xor.h
> +generic-y += mm-arch-hooks.h
> diff --git a/arch/arc/include/asm/mm-arch-hooks.h
> b/arch/arc/include/asm/mm-arch-hooks.h
> deleted file mode 100644
> index c37541c5f8ba..
> --- a/arch/arc/include/asm/mm-arch-hooks.h
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -/*
> - * Architecture specific mm hooks
> - *
> - * Copyright (C) 2015, IBM Corporation
> - * Author: Laurent Dufour
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - */
> -
> -#ifndef _ASM_ARC_MM_ARCH_HOOKS_H
> -#define _ASM_ARC_MM_ARCH_HOOKS_H
> -
> -#endif /* _ASM_ARC_MM_ARCH_HOOKS_H */
> diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild
> index 83c50193626c..870a2f7cbada 100644
> --- a/arch/arm/include/asm/Kbuild
> +++ b/arch/arm/include/asm/Kbuild
> @@ -36,3 +36,4 @@ generic-y += termios.h
> generic-y += timex.h
> generic-y += trace_clock.h
> generic-y += unaligned.h
> +generic-y += mm-arch-hooks.h
We keep this file sorted by headers so please can u respin with right ordering !
Thx,
-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mm: cleaning per architecture MM hook header files
On Monday 29 June 2015 07:55 PM, Laurent Dufour wrote: The commit 2ae416b142b6 (mm: new mm hook framework) introduced an empty header file (mm-arch-hooks.h) for every architecture, even those which doesn't need to define mm hooks. As suggested by Geert Uytterhoeven, this could be cleaned through the use of a generic header file included via each per architecture asm/include/Kbuild file. The powerpc architecture is not impacted here since this architecture has to defined the arch_remap MM hook. Signed-off-by: Laurent Dufour lduf...@linux.vnet.ibm.com Suggested-by: Geert Uytterhoeven ge...@linux-m68k.org CC: Andrew Morton a...@linux-foundation.org CC: linux-a...@vger.kernel.org CC: linux...@kvack.org CC: linux-kernel@vger.kernel.org --- snipped diff --git a/arch/arc/include/asm/Kbuild b/arch/arc/include/asm/Kbuild index 769b312c1abb..2febe6ff32ed 100644 --- a/arch/arc/include/asm/Kbuild +++ b/arch/arc/include/asm/Kbuild @@ -49,3 +49,4 @@ generic-y += ucontext.h generic-y += user.h generic-y += vga.h generic-y += xor.h +generic-y += mm-arch-hooks.h diff --git a/arch/arc/include/asm/mm-arch-hooks.h b/arch/arc/include/asm/mm-arch-hooks.h deleted file mode 100644 index c37541c5f8ba.. --- a/arch/arc/include/asm/mm-arch-hooks.h +++ /dev/null @@ -1,15 +0,0 @@ -/* - * Architecture specific mm hooks - * - * Copyright (C) 2015, IBM Corporation - * Author: Laurent Dufour lduf...@linux.vnet.ibm.com - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - */ - -#ifndef _ASM_ARC_MM_ARCH_HOOKS_H -#define _ASM_ARC_MM_ARCH_HOOKS_H - -#endif /* _ASM_ARC_MM_ARCH_HOOKS_H */ diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild index 83c50193626c..870a2f7cbada 100644 --- a/arch/arm/include/asm/Kbuild +++ b/arch/arm/include/asm/Kbuild @@ -36,3 +36,4 @@ generic-y += termios.h generic-y += timex.h generic-y += trace_clock.h generic-y += unaligned.h +generic-y += mm-arch-hooks.h We keep this file sorted by headers so please can u respin with right ordering ! Thx, -Vineet -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mm: cleaning per architecture MM hook header files
On 30/06/2015 09:28, Vineet Gupta wrote: diff --git a/arch/arc/include/asm/Kbuild b/arch/arc/include/asm/Kbuild index 769b312c1abb..2febe6ff32ed 100644 --- a/arch/arc/include/asm/Kbuild +++ b/arch/arc/include/asm/Kbuild @@ -49,3 +49,4 @@ generic-y += ucontext.h generic-y += user.h generic-y += vga.h generic-y += xor.h +generic-y += mm-arch-hooks.h diff --git a/arch/arc/include/asm/mm-arch-hooks.h b/arch/arc/include/asm/mm-arch-hooks.h deleted file mode 100644 index c37541c5f8ba.. --- a/arch/arc/include/asm/mm-arch-hooks.h +++ /dev/null @@ -1,15 +0,0 @@ -/* - * Architecture specific mm hooks - * - * Copyright (C) 2015, IBM Corporation - * Author: Laurent Dufour lduf...@linux.vnet.ibm.com - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - */ - -#ifndef _ASM_ARC_MM_ARCH_HOOKS_H -#define _ASM_ARC_MM_ARCH_HOOKS_H - -#endif /* _ASM_ARC_MM_ARCH_HOOKS_H */ diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild index 83c50193626c..870a2f7cbada 100644 --- a/arch/arm/include/asm/Kbuild +++ b/arch/arm/include/asm/Kbuild @@ -36,3 +36,4 @@ generic-y += termios.h generic-y += timex.h generic-y += trace_clock.h generic-y += unaligned.h +generic-y += mm-arch-hooks.h We keep this file sorted by headers so please can u respin with right ordering ! Sure, I will send a new version. Thanks for the review, Laurent. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] mm: cleaning per architecture MM hook header files
The commit 2ae416b142b6 ("mm: new mm hook framework") introduced an empty
header file (mm-arch-hooks.h) for every architecture, even those which
doesn't need to define mm hooks.
As suggested by Geert Uytterhoeven, this could be cleaned through the use
of a generic header file included via each per architecture
asm/include/Kbuild file.
The powerpc architecture is not impacted here since this architecture has
to defined the arch_remap MM hook.
Signed-off-by: Laurent Dufour
Suggested-by: Geert Uytterhoeven
CC: Andrew Morton
CC: linux-a...@vger.kernel.org
CC: linux...@kvack.org
CC: linux-kernel@vger.kernel.org
---
arch/alpha/include/asm/Kbuild | 1 +
arch/alpha/include/asm/mm-arch-hooks.h | 15 ---
arch/arc/include/asm/Kbuild | 1 +
arch/arc/include/asm/mm-arch-hooks.h| 15 ---
arch/arm/include/asm/Kbuild | 1 +
arch/arm/include/asm/mm-arch-hooks.h| 15 ---
arch/arm64/include/asm/Kbuild | 1 +
arch/arm64/include/asm/mm-arch-hooks.h | 15 ---
arch/avr32/include/asm/Kbuild | 1 +
arch/avr32/include/asm/mm-arch-hooks.h | 15 ---
arch/blackfin/include/asm/Kbuild| 1 +
arch/blackfin/include/asm/mm-arch-hooks.h | 15 ---
arch/c6x/include/asm/Kbuild | 1 +
arch/c6x/include/asm/mm-arch-hooks.h| 15 ---
arch/cris/include/asm/Kbuild| 1 +
arch/cris/include/asm/mm-arch-hooks.h | 15 ---
arch/frv/include/asm/Kbuild | 1 +
arch/frv/include/asm/mm-arch-hooks.h| 15 ---
arch/hexagon/include/asm/Kbuild | 1 +
arch/hexagon/include/asm/mm-arch-hooks.h| 15 ---
arch/ia64/include/asm/Kbuild| 1 +
arch/ia64/include/asm/mm-arch-hooks.h | 15 ---
arch/m32r/include/asm/Kbuild| 1 +
arch/m32r/include/asm/mm-arch-hooks.h | 15 ---
arch/m68k/include/asm/Kbuild| 1 +
arch/m68k/include/asm/mm-arch-hooks.h | 15 ---
arch/metag/include/asm/Kbuild | 1 +
arch/metag/include/asm/mm-arch-hooks.h | 15 ---
arch/microblaze/include/asm/Kbuild | 1 +
arch/microblaze/include/asm/mm-arch-hooks.h | 15 ---
arch/mips/include/asm/Kbuild| 1 +
arch/mips/include/asm/mm-arch-hooks.h | 15 ---
arch/mn10300/include/asm/Kbuild | 1 +
arch/mn10300/include/asm/mm-arch-hooks.h| 15 ---
arch/nios2/include/asm/Kbuild | 1 +
arch/nios2/include/asm/mm-arch-hooks.h | 15 ---
arch/openrisc/include/asm/Kbuild| 1 +
arch/openrisc/include/asm/mm-arch-hooks.h | 15 ---
arch/parisc/include/asm/Kbuild | 1 +
arch/parisc/include/asm/mm-arch-hooks.h | 15 ---
arch/s390/include/asm/Kbuild| 1 +
arch/s390/include/asm/mm-arch-hooks.h | 15 ---
arch/score/include/asm/Kbuild | 1 +
arch/score/include/asm/mm-arch-hooks.h | 15 ---
arch/sh/include/asm/Kbuild | 1 +
arch/sh/include/asm/mm-arch-hooks.h | 15 ---
arch/sparc/include/asm/Kbuild | 1 +
arch/sparc/include/asm/mm-arch-hooks.h | 15 ---
arch/tile/include/asm/Kbuild| 1 +
arch/tile/include/asm/mm-arch-hooks.h | 15 ---
arch/um/include/asm/Kbuild | 1 +
arch/um/include/asm/mm-arch-hooks.h | 15 ---
arch/unicore32/include/asm/Kbuild | 1 +
arch/unicore32/include/asm/mm-arch-hooks.h | 15 ---
arch/x86/include/asm/Kbuild | 1 +
arch/x86/include/asm/mm-arch-hooks.h| 15 ---
arch/xtensa/include/asm/Kbuild | 1 +
arch/xtensa/include/asm/mm-arch-hooks.h | 15 ---
include/asm-generic/mm-arch-hooks.h | 16
59 files changed, 45 insertions(+), 435 deletions(-)
delete mode 100644 arch/alpha/include/asm/mm-arch-hooks.h
delete mode 100644 arch/arc/include/asm/mm-arch-hooks.h
delete mode 100644 arch/arm/include/asm/mm-arch-hooks.h
delete mode 100644 arch/arm64/include/asm/mm-arch-hooks.h
delete mode 100644 arch/avr32/include/asm/mm-arch-hooks.h
delete mode 100644 arch/blackfin/include/asm/mm-arch-hooks.h
delete mode 100644 arch/c6x/include/asm/mm-arch-hooks.h
delete mode 100644 arch/cris/include/asm/mm-arch-hooks.h
delete mode 100644 arch/frv/include/asm/mm-arch-hooks.h
delete mode 100644 arch/hexagon/include/asm/mm-arch-hooks.h
delete mode 100644 arch/ia64/include/asm/mm-arch-hooks.h
delete mode 100644 arch/m32r/include/asm/mm-arch-hooks.h
delete mode 100644 arch/m68k/include/asm/mm-arch-hooks.h
delete mode 100644 arch/metag/include/asm/mm-arch-hooks.h
delete mode
[PATCH] mm: cleaning per architecture MM hook header files
The commit 2ae416b142b6 (mm: new mm hook framework) introduced an empty header file (mm-arch-hooks.h) for every architecture, even those which doesn't need to define mm hooks. As suggested by Geert Uytterhoeven, this could be cleaned through the use of a generic header file included via each per architecture asm/include/Kbuild file. The powerpc architecture is not impacted here since this architecture has to defined the arch_remap MM hook. Signed-off-by: Laurent Dufour lduf...@linux.vnet.ibm.com Suggested-by: Geert Uytterhoeven ge...@linux-m68k.org CC: Andrew Morton a...@linux-foundation.org CC: linux-a...@vger.kernel.org CC: linux...@kvack.org CC: linux-kernel@vger.kernel.org --- arch/alpha/include/asm/Kbuild | 1 + arch/alpha/include/asm/mm-arch-hooks.h | 15 --- arch/arc/include/asm/Kbuild | 1 + arch/arc/include/asm/mm-arch-hooks.h| 15 --- arch/arm/include/asm/Kbuild | 1 + arch/arm/include/asm/mm-arch-hooks.h| 15 --- arch/arm64/include/asm/Kbuild | 1 + arch/arm64/include/asm/mm-arch-hooks.h | 15 --- arch/avr32/include/asm/Kbuild | 1 + arch/avr32/include/asm/mm-arch-hooks.h | 15 --- arch/blackfin/include/asm/Kbuild| 1 + arch/blackfin/include/asm/mm-arch-hooks.h | 15 --- arch/c6x/include/asm/Kbuild | 1 + arch/c6x/include/asm/mm-arch-hooks.h| 15 --- arch/cris/include/asm/Kbuild| 1 + arch/cris/include/asm/mm-arch-hooks.h | 15 --- arch/frv/include/asm/Kbuild | 1 + arch/frv/include/asm/mm-arch-hooks.h| 15 --- arch/hexagon/include/asm/Kbuild | 1 + arch/hexagon/include/asm/mm-arch-hooks.h| 15 --- arch/ia64/include/asm/Kbuild| 1 + arch/ia64/include/asm/mm-arch-hooks.h | 15 --- arch/m32r/include/asm/Kbuild| 1 + arch/m32r/include/asm/mm-arch-hooks.h | 15 --- arch/m68k/include/asm/Kbuild| 1 + arch/m68k/include/asm/mm-arch-hooks.h | 15 --- arch/metag/include/asm/Kbuild | 1 + arch/metag/include/asm/mm-arch-hooks.h | 15 --- arch/microblaze/include/asm/Kbuild | 1 + arch/microblaze/include/asm/mm-arch-hooks.h | 15 --- arch/mips/include/asm/Kbuild| 1 + arch/mips/include/asm/mm-arch-hooks.h | 15 --- arch/mn10300/include/asm/Kbuild | 1 + arch/mn10300/include/asm/mm-arch-hooks.h| 15 --- arch/nios2/include/asm/Kbuild | 1 + arch/nios2/include/asm/mm-arch-hooks.h | 15 --- arch/openrisc/include/asm/Kbuild| 1 + arch/openrisc/include/asm/mm-arch-hooks.h | 15 --- arch/parisc/include/asm/Kbuild | 1 + arch/parisc/include/asm/mm-arch-hooks.h | 15 --- arch/s390/include/asm/Kbuild| 1 + arch/s390/include/asm/mm-arch-hooks.h | 15 --- arch/score/include/asm/Kbuild | 1 + arch/score/include/asm/mm-arch-hooks.h | 15 --- arch/sh/include/asm/Kbuild | 1 + arch/sh/include/asm/mm-arch-hooks.h | 15 --- arch/sparc/include/asm/Kbuild | 1 + arch/sparc/include/asm/mm-arch-hooks.h | 15 --- arch/tile/include/asm/Kbuild| 1 + arch/tile/include/asm/mm-arch-hooks.h | 15 --- arch/um/include/asm/Kbuild | 1 + arch/um/include/asm/mm-arch-hooks.h | 15 --- arch/unicore32/include/asm/Kbuild | 1 + arch/unicore32/include/asm/mm-arch-hooks.h | 15 --- arch/x86/include/asm/Kbuild | 1 + arch/x86/include/asm/mm-arch-hooks.h| 15 --- arch/xtensa/include/asm/Kbuild | 1 + arch/xtensa/include/asm/mm-arch-hooks.h | 15 --- include/asm-generic/mm-arch-hooks.h | 16 59 files changed, 45 insertions(+), 435 deletions(-) delete mode 100644 arch/alpha/include/asm/mm-arch-hooks.h delete mode 100644 arch/arc/include/asm/mm-arch-hooks.h delete mode 100644 arch/arm/include/asm/mm-arch-hooks.h delete mode 100644 arch/arm64/include/asm/mm-arch-hooks.h delete mode 100644 arch/avr32/include/asm/mm-arch-hooks.h delete mode 100644 arch/blackfin/include/asm/mm-arch-hooks.h delete mode 100644 arch/c6x/include/asm/mm-arch-hooks.h delete mode 100644 arch/cris/include/asm/mm-arch-hooks.h delete mode 100644 arch/frv/include/asm/mm-arch-hooks.h delete mode 100644 arch/hexagon/include/asm/mm-arch-hooks.h delete mode 100644 arch/ia64/include/asm/mm-arch-hooks.h delete mode 100644 arch/m32r/include/asm/mm-arch-hooks.h delete mode 100644 arch/m68k/include/asm/mm-arch-hooks.h
