Re: [PATCH] mm: cma: Use pr_err_ratelimited for CMA warning

[Minchan Kim]

On Tue, Mar 09, 2021 at 05:16:06PM +0800, Baolin Wang wrote:
> If we did not reserve extra CMA memory, the log buffer can be
> easily filled up by CMA failure warning when the devices calling
> dmam_alloc_coherent() to alloc DMA memory. Thus we can use
> pr_err_ratelimited() instead to reduce the duplicate CMA warning.
> 
> Signed-off-by: Baolin Wang 
Acked-by: Minchan Kim 

Re: [PATCH] mm: cma: Use pr_err_ratelimited for CMA warning

[David Hildenbrand]

On 09.03.21 10:16, Baolin Wang wrote:

If we did not reserve extra CMA memory, the log buffer can be
easily filled up by CMA failure warning when the devices calling
dmam_alloc_coherent() to alloc DMA memory. Thus we can use
pr_err_ratelimited() instead to reduce the duplicate CMA warning.

Signed-off-by: Baolin Wang 
---
  mm/cma.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/cma.c b/mm/cma.c
index 54eee21..d101bdb 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -500,8 +500,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, 
unsigned int align,
}
  
  	if (ret && !no_warn) {

-   pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n",
-  __func__, cma->name, count, ret);
+   pr_err_ratelimited("%s: %s: alloc failed, req-size: %zu pages, ret: 
%d\n",
+  __func__, cma->name, count, ret);
cma_debug_show_areas(cma);
}
  



Reviewed-by: David Hildenbrand 

--
Thanks,

David / dhildenb

[PATCH] mm: cma: Use pr_err_ratelimited for CMA warning

[Baolin Wang]

If we did not reserve extra CMA memory, the log buffer can be
easily filled up by CMA failure warning when the devices calling
dmam_alloc_coherent() to alloc DMA memory. Thus we can use
pr_err_ratelimited() instead to reduce the duplicate CMA warning.

Signed-off-by: Baolin Wang 
---
 mm/cma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/cma.c b/mm/cma.c
index 54eee21..d101bdb 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -500,8 +500,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, 
unsigned int align,
}
 
if (ret && !no_warn) {
-   pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n",
-  __func__, cma->name, count, ret);
+   pr_err_ratelimited("%s: %s: alloc failed, req-size: %zu pages, 
ret: %d\n",
+  __func__, cma->name, count, ret);
cma_debug_show_areas(cma);
}
 
-- 
1.8.3.1