Re: [PATCH] mm: remove unused page state adjustment macro

2018-12-14 Thread David Hildenbrand 
On 14.12.18 07:32, Wei Yang wrote:
> These four macro are not used anymore.
> 
> Just remove them.
> 
> Signed-off-by: Wei Yang 
> ---
>  include/linux/vmstat.h | 5 -
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h
> index f25cef84b41d..2db8d60981fe 100644
> --- a/include/linux/vmstat.h
> +++ b/include/linux/vmstat.h
> @@ -239,11 +239,6 @@ extern unsigned long node_page_state(struct pglist_data 
> *pgdat,
>  #define node_page_state(node, item) global_node_page_state(item)
>  #endif /* CONFIG_NUMA */
>  
> -#define add_zone_page_state(__z, __i, __d) mod_zone_page_state(__z, __i, __d)
> -#define sub_zone_page_state(__z, __i, __d) mod_zone_page_state(__z, __i, 
> -(__d))
> -#define add_node_page_state(__p, __i, __d) mod_node_page_state(__p, __i, __d)
> -#define sub_node_page_state(__p, __i, __d) mod_node_page_state(__p, __i, 
> -(__d))
> -
>  #ifdef CONFIG_SMP
>  void __mod_zone_page_state(struct zone *, enum zone_stat_item item, long);
>  void __inc_zone_page_state(struct page *, enum zone_stat_item);
> 

Reviewed-by: David Hildenbrand 

-- 

Thanks,

David / dhildenb

Re: [PATCH] mm: remove unused page state adjustment macro

2018-12-14 Thread Michal Hocko 
On Fri 14-12-18 14:32:11, Wei Yang wrote:
> These four macro are not used anymore.
> 
> Just remove them.
> 
> Signed-off-by: Wei Yang 

Acked-by: Michal Hocko 

> ---
>  include/linux/vmstat.h | 5 -
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h
> index f25cef84b41d..2db8d60981fe 100644
> --- a/include/linux/vmstat.h
> +++ b/include/linux/vmstat.h
> @@ -239,11 +239,6 @@ extern unsigned long node_page_state(struct pglist_data 
> *pgdat,
>  #define node_page_state(node, item) global_node_page_state(item)
>  #endif /* CONFIG_NUMA */
>  
> -#define add_zone_page_state(__z, __i, __d) mod_zone_page_state(__z, __i, __d)
> -#define sub_zone_page_state(__z, __i, __d) mod_zone_page_state(__z, __i, 
> -(__d))
> -#define add_node_page_state(__p, __i, __d) mod_node_page_state(__p, __i, __d)
> -#define sub_node_page_state(__p, __i, __d) mod_node_page_state(__p, __i, 
> -(__d))
> -
>  #ifdef CONFIG_SMP
>  void __mod_zone_page_state(struct zone *, enum zone_stat_item item, long);
>  void __inc_zone_page_state(struct page *, enum zone_stat_item);
> -- 
> 2.15.1
> 

-- 
Michal Hocko
SUSE Labs

[PATCH] mm: remove unused page state adjustment macro

2018-12-13 Thread Wei Yang 
These four macro are not used anymore.

Just remove them.

Signed-off-by: Wei Yang 
---
 include/linux/vmstat.h | 5 -
 1 file changed, 5 deletions(-)

diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h
index f25cef84b41d..2db8d60981fe 100644
--- a/include/linux/vmstat.h
+++ b/include/linux/vmstat.h
@@ -239,11 +239,6 @@ extern unsigned long node_page_state(struct pglist_data 
*pgdat,
 #define node_page_state(node, item) global_node_page_state(item)
 #endif /* CONFIG_NUMA */
 
-#define add_zone_page_state(__z, __i, __d) mod_zone_page_state(__z, __i, __d)
-#define sub_zone_page_state(__z, __i, __d) mod_zone_page_state(__z, __i, 
-(__d))
-#define add_node_page_state(__p, __i, __d) mod_node_page_state(__p, __i, __d)
-#define sub_node_page_state(__p, __i, __d) mod_node_page_state(__p, __i, 
-(__d))
-
 #ifdef CONFIG_SMP
 void __mod_zone_page_state(struct zone *, enum zone_stat_item item, long);
 void __inc_zone_page_state(struct page *, enum zone_stat_item);
-- 
2.15.1