Re: [PATCH] module: remove duplicate include in ./arch/arm/include/asm/pgtable.h
On Tue, Mar 02, 2021 at 06:04:22PM -0800, menglong8.d...@gmail.com wrote: > From: Zhang Yunkai > > 'asm-generic/pgtable-nopud.h' included in 'pgtable.h' is duplicated. > > Signed-off-by: Zhang Yunkai I don't see this change has anything to do with module code, so what is the reason for "module:" in the subject line? What am I missing here? I also think that this patch needs a better explanation, since it's not a removal of a redundant include, whereas your other similarly described changes are. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Re: [PATCH] module: remove duplicate include in ./arch/arm/include/asm/pgtable.h
On Wed, Mar 3, 2021 at 3:04 AM wrote:
> From: Zhang Yunkai
>
> 'asm-generic/pgtable-nopud.h' included in 'pgtable.h' is duplicated.
>
> Signed-off-by: Zhang Yunkai
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[PATCH] module: remove duplicate include in ./arch/arm/include/asm/pgtable.h
From: Zhang Yunkai 'asm-generic/pgtable-nopud.h' included in 'pgtable.h' is duplicated. Signed-off-by: Zhang Yunkai --- arch/arm/include/asm/pgtable.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h index c02f24400369..f3124e57be83 100644 --- a/arch/arm/include/asm/pgtable.h +++ b/arch/arm/include/asm/pgtable.h @@ -9,15 +9,14 @@ #include #include +#include #ifndef CONFIG_MMU -#include #include #else -#include #include #include -- 2.25.1
