Re: [PATCH] mtd: cfi: enforce valid geometry configuration
On Mon, Nov 23, 2015 at 02:39:33PM +0100, Arnd Bergmann wrote: > MTD allows compile-time configuration of the possible CFI geometry > settings that are allowed by the kernel, but that includes a couple of > invalid configurations, where no bank width or no interleave setting > is allowed. These are then caught with a compile-time warning: > > include/linux/mtd/cfi.h:76:2: warning: #warning No CONFIG_MTD_CFI_Ix > selected. No NOR chip support can work. > include/linux/mtd/map.h:145:2: warning: #warning "No > CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work" > > This is a bit annoying for randconfig tests, and can be avoided if > we change the Kconfig logic to always select the simplest configuration > when no other one is enabled. > > Signed-off-by: Arnd Bergmann Pushed to l2-mtd.git. Thanks for fixing this one! I guess an ugly fix is better than nothing here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mtd: cfi: enforce valid geometry configuration
On Monday 23 November 2015 14:39:33 Arnd Bergmann wrote: > MTD allows compile-time configuration of the possible CFI geometry > settings that are allowed by the kernel, but that includes a couple of > invalid configurations, where no bank width or no interleave setting > is allowed. These are then caught with a compile-time warning: > > include/linux/mtd/cfi.h:76:2: warning: #warning No CONFIG_MTD_CFI_Ix > selected. No NOR chip support can work. > include/linux/mtd/map.h:145:2: warning: #warning "No > CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work" > I'm actually still getting the warnings for any file that includes while CONFIG_MTD is disabled. I have a fix now that I'm testing overnight and plan to post tomorrow, then we can decide whether it should be part of the same patch, or we should have two separate patches. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] mtd: cfi: enforce valid geometry configuration
MTD allows compile-time configuration of the possible CFI geometry settings that are allowed by the kernel, but that includes a couple of invalid configurations, where no bank width or no interleave setting is allowed. These are then caught with a compile-time warning: include/linux/mtd/cfi.h:76:2: warning: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. include/linux/mtd/map.h:145:2: warning: #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work" This is a bit annoying for randconfig tests, and can be avoided if we change the Kconfig logic to always select the simplest configuration when no other one is enabled. Signed-off-by: Arnd Bergmann diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig index 63b6b536b044..741ec69e0b46 100644 --- a/drivers/mtd/chips/Kconfig +++ b/drivers/mtd/chips/Kconfig @@ -69,6 +69,10 @@ endchoice config MTD_CFI_GEOMETRY bool "Specific CFI Flash geometry selection" depends on MTD_CFI_ADV_OPTIONS + select MTD_MAP_BANK_WIDTH_1 if !(MTD_MAP_BANK_WIDTH_2 || \ +MTD_MAP_BANK_WIDTH_4 || MTD_MAP_BANK_WIDTH_8 || \ +MTD_MAP_BANK_WIDTH_16 || MTD_MAP_BANK_WIDTH_32) + select MTD_CFI_I1 if !(MTD_CFI_I2 || MTD_CFI_I4 || MTD_CFI_I8) help This option does not affect the code directly, but will enable some other configuration options which would allow you to reduce -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
