Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
On Thu, Aug 28, 2014 at 7:33 AM, David Miller wrote: > From: Ley Foon Tan > Date: Tue, 26 Aug 2014 15:11:16 +0800 > >> @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac >> *dwmac, struct device * >> return -EINVAL; >> } >> >> - dwmac->splitter_base = (void *)devm_ioremap_resource(dev, >> + dwmac->splitter_base = >> + (void __iomem *)devm_ioremap_resource(dev, >> _splitter); > > Please either put this entire call on one line (it'll only be slightly > over 80 columns, which is fine), or indent it properly. > > And by properly I meant that the second and subsequent lines of a function > call must be indented precisely to the first column after the openning > parenthesis of the function call on the first line. You must use the > appropriate number of TAB and SPACE characters necessary to do so. > > If it is indented using only TAB characters, it is very likely that you > are doing it wrong. Okay, will send in new patch to fix this. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
From: Ley Foon Tan Date: Tue, 26 Aug 2014 15:11:16 +0800 > @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac > *dwmac, struct device * > return -EINVAL; > } > > - dwmac->splitter_base = (void *)devm_ioremap_resource(dev, > + dwmac->splitter_base = > + (void __iomem *)devm_ioremap_resource(dev, > _splitter); Please either put this entire call on one line (it'll only be slightly over 80 columns, which is fine), or indent it properly. And by properly I meant that the second and subsequent lines of a function call must be indented precisely to the first column after the openning parenthesis of the function call on the first line. You must use the appropriate number of TAB and SPACE characters necessary to do so. If it is indented using only TAB characters, it is very likely that you are doing it wrong. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
From: Ley Foon Tan lf...@altera.com Date: Tue, 26 Aug 2014 15:11:16 +0800 @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device * return -EINVAL; } - dwmac-splitter_base = (void *)devm_ioremap_resource(dev, + dwmac-splitter_base = + (void __iomem *)devm_ioremap_resource(dev, res_splitter); Please either put this entire call on one line (it'll only be slightly over 80 columns, which is fine), or indent it properly. And by properly I meant that the second and subsequent lines of a function call must be indented precisely to the first column after the openning parenthesis of the function call on the first line. You must use the appropriate number of TAB and SPACE characters necessary to do so. If it is indented using only TAB characters, it is very likely that you are doing it wrong. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
On Thu, Aug 28, 2014 at 7:33 AM, David Miller da...@davemloft.net wrote: From: Ley Foon Tan lf...@altera.com Date: Tue, 26 Aug 2014 15:11:16 +0800 @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device * return -EINVAL; } - dwmac-splitter_base = (void *)devm_ioremap_resource(dev, + dwmac-splitter_base = + (void __iomem *)devm_ioremap_resource(dev, res_splitter); Please either put this entire call on one line (it'll only be slightly over 80 columns, which is fine), or indent it properly. And by properly I meant that the second and subsequent lines of a function call must be indented precisely to the first column after the openning parenthesis of the function call on the first line. You must use the appropriate number of TAB and SPACE characters necessary to do so. If it is indented using only TAB characters, it is very likely that you are doing it wrong. Okay, will send in new patch to fix this. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
On Sel, 2014-08-26 at 10:04 +0200, Giuseppe CAVALLARO wrote: > > > > >> > >> patch should be for net-next > > Do you mean the patch need based on net-next git? > > yes I do. > > > I'm using linux-next git now. > > ok, can you signal it in the subject (e.g. [PATCH (net-next)] > This can help on reviewing and IIRC required by Maintainer too Sure, will do it in next revision. Thanks. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
On 8/26/2014 9:47 AM, Ley Foon Tan wrote: On Tue, Aug 26, 2014 at 3:24 PM, Giuseppe CAVALLARO wrote: @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device * return -EINVAL; } - dwmac->splitter_base = (void *)devm_ioremap_resource(dev, + dwmac->splitter_base = + (void __iomem *)devm_ioremap_resource(dev, I think, no casting should be done: dwmac->splitter_base = devm_ioremap_resource(dev, Oh ya, since both are same type. Will send new patch. thx a lot patch should be for net-next Do you mean the patch need based on net-next git? yes I do. I'm using linux-next git now. ok, can you signal it in the subject (e.g. [PATCH (net-next)] This can help on reviewing and IIRC required by Maintainer too Thanks. welcome BR peppe Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
On Tue, Aug 26, 2014 at 3:24 PM, Giuseppe CAVALLARO wrote: >> @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct >> socfpga_dwmac *dwmac, struct device * >> return -EINVAL; >> } >> >> - dwmac->splitter_base = (void *)devm_ioremap_resource(dev, >> + dwmac->splitter_base = >> + (void __iomem *)devm_ioremap_resource(dev, > > > I think, no casting should be done: > >dwmac->splitter_base = devm_ioremap_resource(dev, Oh ya, since both are same type. Will send new patch. > > patch should be for net-next Do you mean the patch need based on net-next git? I'm using linux-next git now. Thanks. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
On 8/26/2014 9:11 AM, Ley Foon Tan wrote:
Warning:
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
sparse: cast removes address space of expression
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
sparse: incorrect type in assignment (different address spaces)
Signed-off-by: Ley Foon Tan
---
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index cd613d7..c1addce 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac
*dwmac, struct device *
return -EINVAL;
}
- dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
+ dwmac->splitter_base =
+ (void __iomem *)devm_ioremap_resource(dev,
I think, no casting should be done:
dwmac->splitter_base = devm_ioremap_resource(dev,
patch should be for net-next
peppe
_splitter);
if (!dwmac->splitter_base) {
dev_info(dev, "Failed to mapping emac splitter\n");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] net: stmmac: fix warning from Sparse for socfpga
Warning:
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
sparse: cast removes address space of expression
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
sparse: incorrect type in assignment (different address spaces)
Signed-off-by: Ley Foon Tan
---
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index cd613d7..c1addce 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac
*dwmac, struct device *
return -EINVAL;
}
- dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
+ dwmac->splitter_base =
+ (void __iomem *)devm_ioremap_resource(dev,
_splitter);
if (!dwmac->splitter_base) {
dev_info(dev, "Failed to mapping emac splitter\n");
--
1.8.2.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] net: stmmac: fix warning from Sparse for socfpga
Warning:
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
sparse: cast removes address space of expression
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
sparse: incorrect type in assignment (different address spaces)
Signed-off-by: Ley Foon Tan lf...@altera.com
---
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index cd613d7..c1addce 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac
*dwmac, struct device *
return -EINVAL;
}
- dwmac-splitter_base = (void *)devm_ioremap_resource(dev,
+ dwmac-splitter_base =
+ (void __iomem *)devm_ioremap_resource(dev,
res_splitter);
if (!dwmac-splitter_base) {
dev_info(dev, Failed to mapping emac splitter\n);
--
1.8.2.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
On 8/26/2014 9:11 AM, Ley Foon Tan wrote:
Warning:
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
sparse: cast removes address space of expression
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
sparse: incorrect type in assignment (different address spaces)
Signed-off-by: Ley Foon Tan lf...@altera.com
---
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index cd613d7..c1addce 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac
*dwmac, struct device *
return -EINVAL;
}
- dwmac-splitter_base = (void *)devm_ioremap_resource(dev,
+ dwmac-splitter_base =
+ (void __iomem *)devm_ioremap_resource(dev,
I think, no casting should be done:
dwmac-splitter_base = devm_ioremap_resource(dev,
patch should be for net-next
peppe
res_splitter);
if (!dwmac-splitter_base) {
dev_info(dev, Failed to mapping emac splitter\n);
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
On Tue, Aug 26, 2014 at 3:24 PM, Giuseppe CAVALLARO peppe.cavall...@st.com wrote: @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device * return -EINVAL; } - dwmac-splitter_base = (void *)devm_ioremap_resource(dev, + dwmac-splitter_base = + (void __iomem *)devm_ioremap_resource(dev, I think, no casting should be done: dwmac-splitter_base = devm_ioremap_resource(dev, Oh ya, since both are same type. Will send new patch. patch should be for net-next Do you mean the patch need based on net-next git? I'm using linux-next git now. Thanks. Regards Ley Foon -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
On 8/26/2014 9:47 AM, Ley Foon Tan wrote: On Tue, Aug 26, 2014 at 3:24 PM, Giuseppe CAVALLARO peppe.cavall...@st.com wrote: @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device * return -EINVAL; } - dwmac-splitter_base = (void *)devm_ioremap_resource(dev, + dwmac-splitter_base = + (void __iomem *)devm_ioremap_resource(dev, I think, no casting should be done: dwmac-splitter_base = devm_ioremap_resource(dev, Oh ya, since both are same type. Will send new patch. thx a lot patch should be for net-next Do you mean the patch need based on net-next git? yes I do. I'm using linux-next git now. ok, can you signal it in the subject (e.g. [PATCH (net-next)] This can help on reviewing and IIRC required by Maintainer too Thanks. welcome BR peppe Regards Ley Foon -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
On Sel, 2014-08-26 at 10:04 +0200, Giuseppe CAVALLARO wrote: patch should be for net-next Do you mean the patch need based on net-next git? yes I do. I'm using linux-next git now. ok, can you signal it in the subject (e.g. [PATCH (net-next)] This can help on reviewing and IIRC required by Maintainer too Sure, will do it in next revision. Thanks. Regards Ley Foon -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
