Re: [PATCH] net: tsi108: use NULL for pointer-typed argument

[David Miller]

From: Julia Lawall 
Date: Sat, 23 Apr 2016 11:07:02 +0200

> The first argument of pci_free_consistent has type struct pci_dev *, so use
> NULL instead of 0.
> 
> The semantic patch that performs this transformation is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // 
> @@
> @@
> pci_free_consistent(
> - 0
> + NULL
>   , ...)
> // 
> 
> Signed-off-by: Julia Lawall 

Applied.

Re: [PATCH] net: tsi108: use NULL for pointer-typed argument

[David Miller]

From: Julia Lawall 
Date: Sat, 23 Apr 2016 11:07:02 +0200

> The first argument of pci_free_consistent has type struct pci_dev *, so use
> NULL instead of 0.
> 
> The semantic patch that performs this transformation is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // 
> @@
> @@
> pci_free_consistent(
> - 0
> + NULL
>   , ...)
> // 
> 
> Signed-off-by: Julia Lawall 

Applied.

[PATCH] net: tsi108: use NULL for pointer-typed argument

[Julia Lawall]

The first argument of pci_free_consistent has type struct pci_dev *, so use
NULL instead of 0.

The semantic patch that performs this transformation is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
@@
pci_free_consistent(
- 0
+ NULL
  , ...)
// 

Signed-off-by: Julia Lawall 

---
 drivers/net/ethernet/tundra/tsi108_eth.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -u -p a/drivers/net/ethernet/tundra/tsi108_eth.c 
b/drivers/net/ethernet/tundra/tsi108_eth.c
--- a/drivers/net/ethernet/tundra/tsi108_eth.c
+++ b/drivers/net/ethernet/tundra/tsi108_eth.c
@@ -1314,7 +1314,8 @@ static int tsi108_open(struct net_device
data->txring = dma_zalloc_coherent(NULL, txring_size, >txdma,
   GFP_KERNEL);
if (!data->txring) {
-   pci_free_consistent(0, rxring_size, data->rxring, data->rxdma);
+   pci_free_consistent(NULL, rxring_size, data->rxring,
+   data->rxdma);
return -ENOMEM;
}
 

[PATCH] net: tsi108: use NULL for pointer-typed argument

[Julia Lawall]

The first argument of pci_free_consistent has type struct pci_dev *, so use
NULL instead of 0.

The semantic patch that performs this transformation is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
@@
pci_free_consistent(
- 0
+ NULL
  , ...)
// 

Signed-off-by: Julia Lawall 

---
 drivers/net/ethernet/tundra/tsi108_eth.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -u -p a/drivers/net/ethernet/tundra/tsi108_eth.c 
b/drivers/net/ethernet/tundra/tsi108_eth.c
--- a/drivers/net/ethernet/tundra/tsi108_eth.c
+++ b/drivers/net/ethernet/tundra/tsi108_eth.c
@@ -1314,7 +1314,8 @@ static int tsi108_open(struct net_device
data->txring = dma_zalloc_coherent(NULL, txring_size, >txdma,
   GFP_KERNEL);
if (!data->txring) {
-   pci_free_consistent(0, rxring_size, data->rxring, data->rxdma);
+   pci_free_consistent(NULL, rxring_size, data->rxring,
+   data->rxdma);
return -ENOMEM;
}